add tests

Author: reshnm

internal/deployment-repo/deploymentRepoManager.go

@@ -3,21 +3,25 @@ package deploymentrepo
 import (
 	"context"
 	"fmt"
+	"io"
 	"os"
 	"path/filepath"
+	"strings"
 
 	"github.com/go-git/go-billy/v5"
 	"github.com/go-git/go-git/v5"
+	"github.com/openmcp-project/bootstrapper/internal/config"
 	"github.com/openmcp-project/controller-utils/pkg/clusters"
 	"sigs.k8s.io/kustomize/api/krusty"
 	"sigs.k8s.io/kustomize/kyaml/filesys"
-
-	"github.com/openmcp-project/bootstrapper/internal/config"
+	"sigs.k8s.io/yaml"
 
 	gitconfig "github.com/openmcp-project/bootstrapper/internal/git-config"
 	"github.com/openmcp-project/bootstrapper/internal/log"
 	ocmcli "github.com/openmcp-project/bootstrapper/internal/ocm-cli"
 	"github.com/openmcp-project/bootstrapper/internal/util"
+
+	"k8s.io/apimachinery/pkg/apis/meta/v1/unstructured"
 )
 
 const (
@@ -296,49 +300,94 @@ func (m *DeploymentRepoManager) ApplyCustomResourceDefinitions(ctx context.Conte
 		return nil
 	}
 
+	crdDirectory := filepath.Join(m.gitRepoDir, ResourcesDirectoryName, OpenMCPDirectoryName, CRDsDirectoryName)
+
 	logger.Infof("Applying Custom Resource Definitions to deployment repository")
 
-	crdsDownloadDir := filepath.Join(m.gitRepoDir, ResourcesDirectoryName, OpenMCPDirectoryName, CRDsDirectoryName)
+	err := m.applyCRDsForComponentVersion(ctx, m.openMCPOperatorCV, crdDirectory)
 
-	// if the CRDs directory already exists, remove it to ensure a clean state
-	if _, err := os.Stat(crdsDownloadDir); err == nil {
-		err = os.RemoveAll(crdsDownloadDir)
+	for _, clusterProvider := range m.Config.Providers.ClusterProviders {
+		clusterProviderCV, err := m.compGetter.GetReferencedComponentVersionRecursive(ctx, m.compGetter.RootComponentVersion(), "cluster-provider-"+clusterProvider)
 		if err != nil {
-			return fmt.Errorf("failed to remove existing CRD directory: %w", err)
+			return fmt.Errorf("failed to get component version for cluster provider %s: %w", clusterProvider, err)
+		}
+
+		err = m.applyCRDsForComponentVersion(ctx, clusterProviderCV, crdDirectory)
+		if err != nil {
+			logger.Warnf("Failed to apply CRDs for cluster provider %s: %v", clusterProvider, err)
 		}
 	}
 
-	err := os.Mkdir(crdsDownloadDir, 0o755)
-	if err != nil {
-		return fmt.Errorf("failed to create CRD download directory: %w", err)
+	for _, serviceProvider := range m.Config.Providers.ServiceProviders {
+		serviceProviderCV, err := m.compGetter.GetReferencedComponentVersionRecursive(ctx, m.compGetter.RootComponentVersion(), "service-provider-"+serviceProvider)
+		if err != nil {
+			return fmt.Errorf("failed to get component version for service provider %s: %w", serviceProvider, err)
+		}
+		err = m.applyCRDsForComponentVersion(ctx, serviceProviderCV, crdDirectory)
+		if err != nil {
+			logger.Warnf("Failed to apply CRDs for service provider %s: %v", serviceProvider, err)
+		}
 	}
 
-	err = m.compGetter.DownloadDirectoryResource(ctx, m.openMCPOperatorCV, "openmcp-operator-crds", crdsDownloadDir)
-	if err != nil {
-		return fmt.Errorf("failed to download CRD resource: %w", err)
+	for _, platformService := range m.Config.Providers.PlatformServices {
+		platformServiceCV, err := m.compGetter.GetReferencedComponentVersionRecursive(ctx, m.compGetter.RootComponentVersion(), "platform-service-"+platformService)
+		if err != nil {
+			return fmt.Errorf("failed to get component version for platform service %s: %w", platformService, err)
+		}
+		err = m.applyCRDsForComponentVersion(ctx, platformServiceCV, crdDirectory)
+		if err != nil {
+			logger.Warnf("Failed to apply CRDs for platform service %s: %v", platformService, err)
+		}
 	}
 
-	// List all YAML files in the CRDs download directory
-	entries, err := os.ReadDir(crdsDownloadDir)
+	entries, err := os.ReadDir(crdDirectory)
 	if err != nil {
 		return fmt.Errorf("failed to read CRD download directory: %w", err)
 	}
 
-	m.crdFiles = make([]string, 0)
 	for _, entry := range entries {
 		if !entry.IsDir() {
 			fileName := entry.Name()
-			// Check if file has .yaml or .yml extension
 			if filepath.Ext(fileName) == ".yaml" || filepath.Ext(fileName) == ".yml" {
-				filePath := filepath.Join(crdsDownloadDir, fileName)
-				m.crdFiles = append(m.crdFiles, filePath)
-				logger.Tracef("Added CRD file: %s", filePath)
+				// parse file into unstructured object
+				filePath := filepath.Join(crdDirectory, fileName)
+				file, err := os.Open(filePath)
+				if err != nil {
+					return fmt.Errorf("failed to open CRD file %s: %w", filePath, err)
+				}
+				defer func(path string) {
+					err := file.Close()
+					if err != nil {
+						_, _ = fmt.Fprintf(os.Stderr, "failed to close CRD file %s: %v\n", path, err)
+					}
+				}(filePath)
+
+				manifestBytes, err := io.ReadAll(file)
+				if err != nil {
+					return fmt.Errorf("failed to read CRD file %s: %w", filePath, err)
+				}
+
+				var manifest unstructured.Unstructured
+				err = yaml.Unmarshal(manifestBytes, &manifest)
+				if err != nil {
+					return fmt.Errorf("failed to unmarshal CRD file %s: %w", filePath, err)
+				}
+
+				if !crdIsForPlatformCluster(&manifest) {
+					// if the CRD is not for the platform cluster, remove it
+					logger.Tracef("Removing CRD file %s as it is not for the platform cluster", filePath)
+					err = os.Remove(filePath)
+					if err != nil {
+						return fmt.Errorf("failed to remove CRD file %s: %w", filePath, err)
+					}
+				} else {
+					logger.Tracef("Added CRD file: %s", filePath)
+					m.crdFiles = append(m.crdFiles, filePath)
+				}
 			}
 		}
 	}
 
-	logger.Infof("Found %d CRD files", len(m.crdFiles))
-
 	workTree, err := m.gitRepo.Worktree()
 	if err != nil {
 		return fmt.Errorf("failed to get worktree: %w", err)
@@ -352,6 +401,37 @@ func (m *DeploymentRepoManager) ApplyCustomResourceDefinitions(ctx context.Conte
 	return nil
 }
 
+func (m *DeploymentRepoManager) applyCRDsForComponentVersion(ctx context.Context, cv *ocmcli.ComponentVersion, targetDirectory string) error {
+	logger := log.GetLogger()
+
+	lastSlash := strings.LastIndex(cv.Component.Name, "/")
+	if lastSlash == -1 {
+		return fmt.Errorf("invalid component name: %s", cv.Component.Name)
+	}
+
+	crdResourceName := cv.Component.Name[lastSlash+1:] + "-crds"
+
+	logger.Debugf("Applying CRDs for component %s from resource %s to directory %s", cv.Component.Name, crdResourceName, targetDirectory)
+
+	err := m.compGetter.DownloadDirectoryResource(ctx, cv, crdResourceName, targetDirectory)
+	if err != nil {
+		return fmt.Errorf("failed to download CRD resource: %w", err)
+	}
+
+	return nil
+}
+
+func crdIsForPlatformCluster(crd *unstructured.Unstructured) bool {
+	labels := crd.GetLabels()
+	if labels == nil {
+		return false
+	}
+	if val, ok := labels["openmcp.cloud/cluster"]; ok && val == "platform" {
+		return true
+	}
+	return false
+}
+
 // ApplyExtraManifests copies extra manifests from the specified directory to the deployment repository and stages them for commit.
 func (m *DeploymentRepoManager) ApplyExtraManifests(_ context.Context) error {
 	logger := log.GetLogger()
@@ -405,7 +485,9 @@ func (m *DeploymentRepoManager) UpdateResourcesKustomization() error {
 			len(m.extraManifests))
 
 	for _, crdFile := range m.crdFiles {
-		files = append(files, filepath.Join(CRDsDirectoryName, filepath.Base(crdFile)))
+		// get the path relative to the git repo dir
+		crdFile = strings.TrimPrefix(crdFile, filepath.Join(m.gitRepoDir, ResourcesDirectoryName, OpenMCPDirectoryName)+string(os.PathSeparator))
+		files = append(files, crdFile)
 	}
 
 	for _, clusterProvider := range m.Config.Providers.ClusterProviders {