Skip to content

Commit 97cc96a

Browse files
committed
restructure task variables
1 parent d31ac26 commit 97cc96a

File tree

3 files changed

+22
-24
lines changed

3 files changed

+22
-24
lines changed

Taskfile_library.yaml

Lines changed: 2 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -42,27 +42,16 @@ vars:
4242
sh: 'cat "{{.ROOT_DIR2}}/go.mod" | grep "module " | sed "s/module //" | sed -E "s/[[:blank:]].*//"'
4343
NESTED_MODULES: '{{.NESTED_MODULES | default "" }}'
4444

45-
LOCALBIN: '{{ .LOCALBIN | default (print .ROOT_DIR2 "/bin") }}'
46-
LOCALTMP: '{{ .LOCALTMP | default (print .ROOT_DIR2 "/tmp") }}'
45+
LOCALBIN: '{{ env "LOCALBIN" | default ( .LOCALBIN | default (print .ROOT_DIR2 "/bin") ) }}'
46+
LOCALTMP: '{{ env "LOCALTMP" | default ( .LOCALTMP | default (print .ROOT_DIR2 "/tmp") ) }}'
4747
CONTROLLER_GEN: '{{ .CONTROLLER_GEN | default (print .LOCALBIN "/controller-gen") }}'
48-
CONTROLLER_GEN_VERSION: '{{ .CONTROLLER_GEN_VERSION | default "v0.16.4" }}'
4948
FORMATTER: '{{ .FORMATTER | default (print .LOCALBIN "/goimports") }}'
50-
FORMATTER_VERSION: '{{ .FORMATTER_VERSION | default "v0.26.0" }}'
5149
LINTER: '{{ .LINTER | default (print .LOCALBIN "/golangci-lint") }}'
52-
LINTER_VERSION: '{{ .LINTER_VERSION | default "v1.64.4" }}'
5350
JQ: '{{ .JQ | default (print .LOCALBIN "/jq") }}'
54-
JQ_VERSION: '{{ .JQ_VERSION | default "v1.7.1" }}'
5551
HELM: '{{ .HELM | default (print .LOCALBIN "/helm") }}'
56-
HELM_VERSION: '{{ .HELM_VERSION | default "v3.17.1" }}'
5752
YAML2JSON: '{{ .YAML2JSON | default (print .LOCALBIN "/yaml2json") }}'
58-
YAML2JSON_VERSION: '{{ .YAML2JSON_VERSION | default "v1.3.5" }}'
5953
OCM: '{{ .OCM | default (print .LOCALBIN "/ocm") }}'
60-
OCM_VERSION: '{{ .OCM_VERSION | default "v0.21.0" }}'
6154
ENVTEST: '{{ .ENVTEST | default (print .LOCALBIN "/setup-envtest") }}'
62-
ENVTEST_VERSION: '{{ .ENVTEST_VERSION | default "release-0.16" }}'
63-
64-
DOCKER_BUILDER_NAME: # move to build taskfile later
65-
sh: 'echo -n ${DOCKER_BUILDER_NAME:-"openmcp-multiarch-builder"}'
6655

6756
# separator strings
6857
SEP_MSG: "This is just a separator, what did you expect to happen?"

tasks_build_img.yaml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,10 @@ includes:
55
taskfile: tasks_build_bin.yaml
66
internal: true
77

8+
vars:
9+
DOCKER_BUILDER_NAME:
10+
sh: 'echo -n ${DOCKER_BUILDER_NAME:-"openmcp-multiarch-builder"}'
11+
812
tasks:
913
# This is a dummy task that serves as a separator between task namespaces in the 'task -l' output.
1014
"---":

tasks_tools.yaml

Lines changed: 16 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -33,9 +33,10 @@ tasks:
3333
requires:
3434
vars:
3535
- CONTROLLER_GEN
36-
- CONTROLLER_GEN_VERSION
3736
deps:
3837
- localbin
38+
vars:
39+
CONTROLLER_GEN_VERSION: '{{ env "CONTROLLER_GEN_VERSION" | default ( .CONTROLLER_GEN_VERSION | default "v0.16.4" ) }}'
3940
status:
4041
- test -x {{.CONTROLLER_GEN}}
4142
- '{{.CONTROLLER_GEN}} --version | grep -q "{{.CONTROLLER_GEN_VERSION}}"'
@@ -49,9 +50,10 @@ tasks:
4950
requires:
5051
vars:
5152
- FORMATTER
52-
- FORMATTER_VERSION
5353
deps:
5454
- localbin
55+
vars:
56+
FORMATTER_VERSION: '{{ env "FORMATTER_VERSION" | default ( .FORMATTER_VERSION | default "v0.26.0" ) }}'
5557
status:
5658
- test -x {{.FORMATTER}}
5759
- test -f {{.LOCALBIN}}/formatter_version
@@ -67,9 +69,10 @@ tasks:
6769
requires:
6870
vars:
6971
- LINTER
70-
- LINTER_VERSION
7172
deps:
7273
- localbin
74+
vars:
75+
LINTER_VERSION: '{{ env "LINTER_VERSION" | default ( .LINTER_VERSION | default "v1.64.4" ) }}'
7376
status:
7477
- test -x {{.LINTER}}
7578
- '{{.LINTER}} --version | grep -q {{.LINTER_VERSION | trimPrefix "v"}}'
@@ -83,10 +86,10 @@ tasks:
8386
requires:
8487
vars:
8588
- JQ
86-
- JQ_VERSION
8789
deps:
8890
- localbin
8991
vars:
92+
JQ_VERSION: '{{ env "JQ_VERSION" | default ( .JQ_VERSION | default "v1.7.1" ) }}'
9093
JQ_OS:
9194
sh: 'if [[ "{{.OS}}" == "darwin" ]]; then echo "macos"; else echo "{{.OS}}"; fi' # jq uses 'macos' instead of 'darwin'
9295
status:
@@ -103,15 +106,15 @@ tasks:
103106
requires:
104107
vars:
105108
- HELM
106-
- HELM_VERSION
107109
deps:
108110
- localbin
109-
status:
110-
- test -x "{{.HELM}}"
111-
- '"{{.HELM}}" version --short | grep -q {{.HELM_VERSION}}'
112111
vars:
112+
HELM_VERSION: '{{ env "HELM_VERSION" | default ( .HELM_VERSION | default "v3.17.1" ) }}'
113113
tmpdir:
114114
sh: 'mktemp -d'
115+
status:
116+
- test -x "{{.HELM}}"
117+
- '"{{.HELM}}" version --short | grep -q {{.HELM_VERSION}}'
115118
cmds:
116119
- 'mkdir -p {{.tmpdir}}/helm-unpacked'
117120
- 'curl -sfL "https://get.helm.sh/helm-{{.HELM_VERSION}}-{{.OS}}-{{.ARCH}}.tar.gz" --output "{{.tmpdir}}/helm.tar.gz"'
@@ -127,9 +130,10 @@ tasks:
127130
requires:
128131
vars:
129132
- YAML2JSON
130-
- YAML2JSON_VERSION
131133
deps:
132134
- localbin
135+
vars:
136+
YAML2JSON_VERSION: '{{ env "YAML2JSON_VERSION" | default ( .YAML2JSON_VERSION | default "v1.3.5" ) }}'
133137
status:
134138
- 'test -x "{{.YAML2JSON}}"'
135139
- '"{{.YAML2JSON}}" --version | grep -q "{{.YAML2JSON_VERSION | trimPrefix "v"}}"'
@@ -144,13 +148,13 @@ tasks:
144148
requires:
145149
vars:
146150
- OCM
147-
- OCM_VERSION
148151
deps:
149152
- localbin
150153
status:
151154
- 'test -x "{{.OCM}}"'
152155
- '"{{.OCM}}" --version | grep -q "{{.OCM_VERSION | trimPrefix "v"}}"'
153156
vars:
157+
OCM_VERSION: '{{ env "OCM_VERSION" | default ( .OCM_VERSION | default "v0.21.0" ) }}'
154158
tmpdir:
155159
sh: 'mktemp -d'
156160
cmds:
@@ -164,9 +168,10 @@ tasks:
164168
requires:
165169
vars:
166170
- ENVTEST
167-
- ENVTEST_VERSION
168171
deps:
169172
- localbin
173+
vars:
174+
ENVTEST_VERSION: '{{ env "ENVTEST_VERSION" | default ( .ENVTEST_VERSION | default "release-0.16" ) }}'
170175
status:
171176
- 'test -x "{{.ENVTEST}}"'
172177
- test -f {{.LOCALBIN}}/envtest_version

0 commit comments

Comments
 (0)