fix: use linux as default when builing image #22
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reshnm
changed the title
Diaphteiros
approved these changes
May 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Previously the (non-multi) image tasks have build images based on the
OSvariable which was defaulted to$(go env GOOS).When run on macOS this resulted in
darwin. Neither othe base image that is being used nor docker under macOS supports darwin images. In general docker always runs linux images even under macOS or windows in a virtual environment.Therefore id doesn't make sense to build images based on the
$(go env GOOS)result.Instead there is now a seperate variable
IMAGE_OSwhich is set tolinuxby default, but can be overwritten by the user.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note: