chore: integrate build repository

Author: maximiliantech

Taskfile.yaml

@@ -4,7 +4,7 @@ vars:
   NESTED_MODULES: api
   API_DIRS: '{{.ROOT_DIR}}/api/v1alpha1/...'
   MANIFEST_OUT: '{{.ROOT_DIR}}/config/crd/bases'
-  CODE_DIRS: '{{.ROOT_DIR}}/cmd/... {{.ROOT_DIR}}/internal/... {{.ROOT_DIR}}/test/... {{.ROOT_DIR}}/api/v1alpha1/...'
+  CODE_DIRS: '{{.ROOT_DIR}}/cmd/... {{.ROOT_DIR}}/internal/... {{.ROOT_DIR}}/api/v1alpha1/...'
   COMPONENTS: 'cluster-provider-kind'
   REPO_NAME: 'https://github.com/openmcp-project/cluster-provider-kind'
   GENERATE_DOCS_INDEX: "false"

api/v1alpha1/accessrequest_types.go

@@ -33,12 +33,14 @@ type AccessRequestStatus struct {
 	Kubeconfig *Kubeconfig `json:"kubeconfig,omitempty"`
 }
 
+// Kubeconfig contains the information needed to access a cluster.
 type Kubeconfig struct {
 	SecretRef      corev1.SecretReference `json:"secretRef,omitempty"`
 	ExpiresAt      metav1.Time            `json:"expiresAt,omitempty"`
 	ServiceAccount ServiceAccountRef      `json:"serviceAccount,omitempty"`
 }
 
+// ServiceAccountRef contains the information needed to access a service account.
 type ServiceAccountRef struct {
 	Name      string `json:"name"`
 	Namespace string `json:"namespace"`

api/v1alpha1/cluster_types.go

@@ -33,8 +33,10 @@ const (
 	Unknown     Phase = "Unknown"
 )
 
+// ClusterConditionType is a custom type representing the condition type of a cluster.
 type ClusterConditionType string
 
+// Constants representing the conditions of a cluster.
 const (
 	ClusterReady ClusterConditionType = "Ready"
 	KindReady    ClusterConditionType = "KindReady"

cmd/main.go cmd/cluster-provider-kind/main.gocmd/main.go renamed to cmd/cluster-provider-kind/main.go

@@ -111,6 +111,8 @@ spec:
             description: AccessRequestStatus defines the observed state of AccessRequest.
             properties:
               kubeconfig:
+                description: Kubeconfig contains the information needed to access
+                  a cluster.
                 properties:
                   expiresAt:
                     format: date-time
@@ -131,6 +133,8 @@ spec:
                     type: object
                     x-kubernetes-map-type: atomic
                   serviceAccount:
+                    description: ServiceAccountRef contains the information needed
+                      to access a service account.
                     properties:
                       name:
                         type: string

config/crd/bases/kind.clusters.openmcp.cloud_accessrequests.yaml

@@ -37,6 +37,7 @@ import (
 )
 
 var (
+	// Finalizer is the finalizer for Cluster
 	Finalizer = v1alpha1.GroupVersion.Group + "/finalizer"
 )
 
@@ -68,7 +69,8 @@ func (r *ClusterReconciler) Reconcile(ctx context.Context, req ctrl.Request) (ct
 	}
 
 	// Always try to update the status
-	defer r.Status().Update(ctx, cluster)
+	// FIXME: error handling at the end?
+	defer r.Status().Update(ctx, cluster) //nolint:errcheck
 
 	ctx = smartrequeue.NewContext(ctx, r.RequeueStore.For(cluster))
 
@@ -109,6 +111,7 @@ func (r *ClusterReconciler) handleDelete(ctx context.Context, cluster *v1alpha1.
 	return requeue.Progressing()
 }
 
+//nolint:gocyclo
 func (r *ClusterReconciler) handleCreateOrUpdate(ctx context.Context, cluster *v1alpha1.Cluster) (ctrl.Result, error) {
 	requeue := smartrequeue.FromContext(ctx)
 	cluster.Status.Phase = v1alpha1.Progressing

internal/controller/accessrequest_controller_test.go

@@ -24,7 +24,7 @@ import (
 	"os/exec"
 	"strings"
 
-	. "github.com/onsi/ginkgo/v2" //nolint:golint,revive
+	. "github.com/onsi/ginkgo/v2" //nolint:golint,revive,staticcheck
 )
 
 const (
@@ -197,7 +197,7 @@ func GetProjectDir() (string, error) {
 	if err != nil {
 		return wd, err
 	}
-	wd = strings.Replace(wd, "/test/e2e", "", -1)
+	wd = strings.ReplaceAll(wd, "/test/e2e", "")
 	return wd, nil
 }