chore: simplify codebase (#23)

* docs: add comments

* chore: update generated files

* feat: add environment variable to properly read kubeconfig

* chore: update .gitignore

* chore: update build repo

* feat(fixme): use openmcp-operator/api

* docs: add code comments

* chore: update build repo

* docs: add more comments

* test: add context_test.go

* test: add more tests

* refactor: code

* test: increase coverage

* test(smartrequeue): increase coverage to 90%

* fix(example): typo

* fix: phase declaration

* chore: remove errors

* chore: update PROJECT file

* chore: register openmcp-operator v1alpha1 scheme

* chore: update sample

* docs: add todo

* fix: imports

Author: maximiliantech

.gitignore

@@ -27,3 +27,6 @@ go.work
 *~
 
 *.html
+
+# VS Code Go debug binaries
+bin/debug_bin*

Dockerfile

@@ -29,5 +29,7 @@ RUN apk add --no-cache docker-cli kind
 WORKDIR /
 COPY --from=builder /workspace/manager .
 USER 65532:65532
+# Set the default command to execute when running the container
+ENV KIND_IN_CONTAINER=true
 
 ENTRYPOINT ["/manager"]

PROJECT

@@ -16,12 +16,4 @@ resources:
   kind: Cluster
   path: github.com/openmcp-project/cluster-provider-kind/api/v1alpha1
   version: v1alpha1
-- api:
-    crdVersion: v1
-    namespaced: true
-  controller: true
-  domain: kind.clusters.openmcp.cloud
-  kind: AccessRequest
-  path: github.com/openmcp-project/cluster-provider-kind/api/v1alpha1
-  version: v1alpha1
 version: "3"

api/v1alpha1/accessrequest_types.go

@@ -18,6 +18,7 @@ package v1alpha1
 
 import (
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
+	runtime "k8s.io/apimachinery/pkg/runtime"
 )
 
 // Phase is a custom type representing the phase of a cluster.
@@ -48,10 +49,32 @@ type ClusterSpec struct{}
 
 // ClusterStatus defines the observed state of Cluster.
 type ClusterStatus struct {
+	// Reason is expected to contain a CamelCased string that provides further information in a machine-readable format.
+	// +optional
+	Reason string `json:"reason,omitempty"`
+
+	// Message contains further details in a human-readable format.
+	// +optional
+	Message string `json:"message,omitempty"`
+
+	// Conditions is a list of conditions that apply to the cluster.
+	// +optional
 	Conditions []metav1.Condition `json:"conditions,omitempty"`
 
+	// ObservedGeneration is the generation of this resource that was last reconciled by the controller.
+	ObservedGeneration int64 `json:"observedGeneration"`
+
 	// +kubebuilder:default=Unknown
 	Phase Phase `json:"phase"`
+
+	// APIServer is the API server endpoint of the cluster.
+	// +optional
+	APIServer string `json:"apiServer,omitempty"`
+
+	// ProviderStatus is the provider-specific status of the cluster.
+	// x-kubernetes-preserve-unknown-fields: true
+	// +optional
+	ProviderStatus *runtime.RawExtension `json:"providerStatus,omitempty"`
 }
 
 // Cluster is the Schema for the clusters API.
@@ -79,3 +102,12 @@ type ClusterList struct {
 func init() {
 	SchemeBuilder.Register(&Cluster{}, &ClusterList{})
 }
+
+const (
+	// StatusPhaseReady indicates that the resource is ready. All conditions are met and are in status "True".
+	StatusPhaseReady = "Ready"
+	// StatusPhaseProgressing indicates that the resource is not ready and being created or updated. At least one condition is not met and is in status "False".
+	StatusPhaseProgressing = "Progressing"
+	// StatusPhaseTerminating indicates that the resource is not ready and in deletion. At least one condition is not met and is in status "False".
+	StatusPhaseTerminating = "Terminating"
+)

api/v1alpha1/cluster_types.go

@@ -38,6 +38,8 @@ import (
 	metricsserver "sigs.k8s.io/controller-runtime/pkg/metrics/server"
 	"sigs.k8s.io/controller-runtime/pkg/webhook"
 
+	openv1alpha1 "github.com/openmcp-project/openmcp-operator/api/clusters/v1alpha1"
+
 	kindclustersopenmcpcloudv1alpha1 "github.com/openmcp-project/cluster-provider-kind/api/v1alpha1"
 	"github.com/openmcp-project/cluster-provider-kind/internal/controller"
 	"github.com/openmcp-project/cluster-provider-kind/pkg/kind"
@@ -54,6 +56,8 @@ func init() {
 	utilruntime.Must(clientgoscheme.AddToScheme(scheme))
 
 	utilruntime.Must(kindclustersopenmcpcloudv1alpha1.AddToScheme(scheme))
+	utilruntime.Must(openv1alpha1.AddToScheme(scheme))
+
 	// +kubebuilder:scaffold:scheme
 }
 
@@ -181,7 +185,7 @@ func main() {
 		})
 	}
 
-	kindProvider := kind.NewDockerProvider()
+	kindProvider := kind.NewKindProvider()
 
 	mgr, err := ctrl.NewManager(ctrl.GetConfigOrDie(), ctrl.Options{
 		Scheme:                 scheme,