Skip to content

Commit 93c2f45

Browse files
refactor(imports): openv1alpha1 to clustersv1alpha1
1 parent 289d200 commit 93c2f45

File tree

5 files changed

+21
-19
lines changed

5 files changed

+21
-19
lines changed

cmd/cluster-provider-kind/main.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ import (
3838
metricsserver "sigs.k8s.io/controller-runtime/pkg/metrics/server"
3939
"sigs.k8s.io/controller-runtime/pkg/webhook"
4040

41-
openv1alpha1 "github.com/openmcp-project/openmcp-operator/api/clusters/v1alpha1"
41+
clustersv1alpha1 "github.com/openmcp-project/openmcp-operator/api/clusters/v1alpha1"
4242

4343
"github.com/openmcp-project/cluster-provider-kind/api/crds"
4444
kindv1alpha1 "github.com/openmcp-project/cluster-provider-kind/api/v1alpha1"
@@ -57,7 +57,7 @@ func init() {
5757
utilruntime.Must(clientgoscheme.AddToScheme(scheme))
5858

5959
utilruntime.Must(kindv1alpha1.AddToScheme(scheme))
60-
utilruntime.Must(openv1alpha1.AddToScheme(scheme))
60+
utilruntime.Must(clustersv1alpha1.AddToScheme(scheme))
6161

6262
utilruntime.Must(apiextensionsv1.AddToScheme(scheme))
6363
// +kubebuilder:scaffold:scheme

internal/controller/accessrequest_controller.go

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ import (
3030
"sigs.k8s.io/controller-runtime/pkg/controller/controllerutil"
3131
logf "sigs.k8s.io/controller-runtime/pkg/log"
3232

33-
openv1alpha1 "github.com/openmcp-project/openmcp-operator/api/clusters/v1alpha1"
33+
clustersv1alpha1 "github.com/openmcp-project/openmcp-operator/api/clusters/v1alpha1"
3434

3535
"github.com/openmcp-project/cluster-provider-kind/pkg/kind"
3636
)
@@ -55,7 +55,7 @@ type AccessRequestReconciler struct {
5555
func (r *AccessRequestReconciler) Reconcile(ctx context.Context, req ctrl.Request) (ctrl.Result, error) {
5656
_ = logf.FromContext(ctx)
5757

58-
ar := &openv1alpha1.AccessRequest{}
58+
ar := &clustersv1alpha1.AccessRequest{}
5959
if err := r.Get(ctx, req.NamespacedName, ar); err != nil {
6060
if apierrors.IsNotFound(err) {
6161
return ctrl.Result{}, nil
@@ -64,7 +64,7 @@ func (r *AccessRequestReconciler) Reconcile(ctx context.Context, req ctrl.Reques
6464
}
6565

6666
clusterRef := types.NamespacedName{Name: ar.Spec.ClusterRef.Name, Namespace: ar.Namespace}
67-
cluster := &openv1alpha1.Cluster{}
67+
cluster := &clustersv1alpha1.Cluster{}
6868
if err := r.Get(ctx, clusterRef, cluster); err != nil {
6969
return ctrl.Result{}, errors.Join(err, errFailedToGetReferencedCluster)
7070
}
@@ -99,7 +99,7 @@ func (r *AccessRequestReconciler) Reconcile(ctx context.Context, req ctrl.Reques
9999
// SetupWithManager sets up the controller with the Manager.
100100
func (r *AccessRequestReconciler) SetupWithManager(mgr ctrl.Manager) error {
101101
return ctrl.NewControllerManagedBy(mgr).
102-
For(&openv1alpha1.AccessRequest{}).
102+
For(&clustersv1alpha1.AccessRequest{}).
103103
Named("accessrequest").
104104
Complete(r)
105105
}

internal/controller/cluster_controller.go

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ import (
3030
"sigs.k8s.io/controller-runtime/pkg/controller/controllerutil"
3131
logf "sigs.k8s.io/controller-runtime/pkg/log"
3232

33-
openv1alpha1 "github.com/openmcp-project/openmcp-operator/api/clusters/v1alpha1"
33+
clustersv1alpha1 "github.com/openmcp-project/openmcp-operator/api/clusters/v1alpha1"
3434
commonapi "github.com/openmcp-project/openmcp-operator/api/common"
3535

3636
"github.com/openmcp-project/cluster-provider-kind/pkg/kind"
@@ -40,7 +40,7 @@ import (
4040

4141
var (
4242
// Finalizer is the finalizer for Cluster
43-
Finalizer = openv1alpha1.GroupVersion.Group + "/finalizer"
43+
Finalizer = clustersv1alpha1.GroupVersion.Group + "/finalizer"
4444
)
4545

4646
// ClusterReconciler reconciles a Cluster object
@@ -62,7 +62,7 @@ func (r *ClusterReconciler) Reconcile(ctx context.Context, req ctrl.Request) (ct
6262
log.Info("Reconcile")
6363
defer log.Info("Done")
6464

65-
cluster := &openv1alpha1.Cluster{}
65+
cluster := &clustersv1alpha1.Cluster{}
6666
if err := r.Get(ctx, req.NamespacedName, cluster); err != nil {
6767
if apierrors.IsNotFound(err) {
6868
return ctrl.Result{}, nil
@@ -83,7 +83,7 @@ func (r *ClusterReconciler) Reconcile(ctx context.Context, req ctrl.Request) (ct
8383
return r.handleCreateOrUpdate(ctx, cluster)
8484
}
8585

86-
func (r *ClusterReconciler) handleDelete(ctx context.Context, cluster *openv1alpha1.Cluster) (ctrl.Result, error) {
86+
func (r *ClusterReconciler) handleDelete(ctx context.Context, cluster *clustersv1alpha1.Cluster) (ctrl.Result, error) {
8787
requeue := smartrequeue.FromContext(ctx)
8888
cluster.Status.Phase = commonapi.StatusPhaseTerminating
8989

@@ -114,7 +114,7 @@ func (r *ClusterReconciler) handleDelete(ctx context.Context, cluster *openv1alp
114114
}
115115

116116
//nolint:gocyclo
117-
func (r *ClusterReconciler) handleCreateOrUpdate(ctx context.Context, cluster *openv1alpha1.Cluster) (ctrl.Result, error) {
117+
func (r *ClusterReconciler) handleCreateOrUpdate(ctx context.Context, cluster *clustersv1alpha1.Cluster) (ctrl.Result, error) {
118118
requeue := smartrequeue.FromContext(ctx)
119119
cluster.Status.Phase = commonapi.StatusPhaseProgressing
120120

@@ -201,12 +201,12 @@ func (r *ClusterReconciler) handleCreateOrUpdate(ctx context.Context, cluster *o
201201
// SetupWithManager sets up the controller with the Manager.
202202
func (r *ClusterReconciler) SetupWithManager(mgr ctrl.Manager) error {
203203
return ctrl.NewControllerManagedBy(mgr).
204-
For(&openv1alpha1.Cluster{}).
204+
For(&clustersv1alpha1.Cluster{}).
205205
Named("cluster").
206206
Complete(r)
207207
}
208208

209-
func (r *ClusterReconciler) assignSubnet(ctx context.Context, cluster *openv1alpha1.Cluster) error {
209+
func (r *ClusterReconciler) assignSubnet(ctx context.Context, cluster *clustersv1alpha1.Cluster) error {
210210
_, ok := cluster.Annotations[kind.AnnotationAssignedSubnet]
211211
if ok {
212212
return nil
@@ -221,7 +221,7 @@ func (r *ClusterReconciler) assignSubnet(ctx context.Context, cluster *openv1alp
221221
return r.Update(ctx, cluster)
222222
}
223223

224-
func kindName(cluster *openv1alpha1.Cluster) string {
224+
func kindName(cluster *clustersv1alpha1.Cluster) string {
225225
return fmt.Sprintf("%s.%s", namespaceOrDefault(cluster.Namespace), cluster.Name)
226226
}
227227

pkg/kind/networking.go

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ import (
1010
"strings"
1111
"sync"
1212

13-
openv1alpha1 "github.com/openmcp-project/openmcp-operator/api/clusters/v1alpha1"
13+
clustersv1alpha1 "github.com/openmcp-project/openmcp-operator/api/clusters/v1alpha1"
1414

1515
"sigs.k8s.io/controller-runtime/pkg/client"
1616
)
@@ -27,7 +27,8 @@ var (
2727
errNoSubnetsAvailable = errors.New("no subnets available")
2828
errInvalidIP = errors.New("invalid textual representation of an IP address")
2929

30-
AnnotationAssignedSubnet = openv1alpha1.GroupVersion.Group + "/assigned-subnet"
30+
// AnnotationAssignedSubnet is the annotation used to store the assigned subnet for a cluster
31+
AnnotationAssignedSubnet = clustersv1alpha1.GroupVersion.Group + "/assigned-subnet"
3132
lockListClusters = sync.Mutex{}
3233
)
3334

@@ -89,7 +90,7 @@ func NextAvailableLBNetwork(ctx context.Context, c client.Client) (net.IPNet, er
8990
return net.IPNet{}, err
9091
}
9192

92-
clusters := &openv1alpha1.ClusterList{}
93+
clusters := &clustersv1alpha1.ClusterList{}
9394
if err := c.List(ctx, clusters); err != nil {
9495
return net.IPNet{}, err
9596
}
@@ -132,7 +133,7 @@ func calculateV4Subnet(input net.IPNet, offset int) (net.IPNet, error) {
132133
}, nil
133134
}
134135

135-
func isIpNetTaken(ipnet net.IPNet, clusters *openv1alpha1.ClusterList) (bool, error) {
136+
func isIpNetTaken(ipnet net.IPNet, clusters *clustersv1alpha1.ClusterList) (bool, error) {
136137
for _, c := range clusters.Items {
137138
cNet, err := SubnetFromCluster(&c)
138139
if err != nil {
@@ -148,7 +149,7 @@ func isIpNetTaken(ipnet net.IPNet, clusters *openv1alpha1.ClusterList) (bool, er
148149
return false, nil
149150
}
150151

151-
func SubnetFromCluster(c *openv1alpha1.Cluster) (*net.IPNet, error) {
152+
func SubnetFromCluster(c *clustersv1alpha1.Cluster) (*net.IPNet, error) {
152153
ipNetStr, ok := c.Annotations[AnnotationAssignedSubnet]
153154
if !ok {
154155
return nil, nil

pkg/smartrequeue/example_test.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@ func Example_controllerUsage() {
2727
inProgress := false // This would be determined by your logic
2828
errOccurred := false // This would be determined by your logic
2929

30+
// nolint:gocritic
3031
if errOccurred {
3132
// Handle error case
3233
err := fmt.Errorf("something went wrong")

0 commit comments

Comments
 (0)