test: add more tests

Author: maximiliantech

pkg/smartrequeue/store.go

@@ -57,14 +57,6 @@ func (s *Store) deleteEntry(toDelete *Entry) {
 	}
 }
 
-// cap limits the next duration to the maximum interval.
-func (s *Store) cap(next time.Duration) time.Duration {
-	if next > s.maxInterval {
-		return s.maxInterval
-	}
-	return next
-}
-
 func keyFromObject(obj client.Object) key {
 	return key{
 		Kind:      reflect.TypeOf(obj).Elem().Name(),
@@ -122,7 +114,15 @@ func (e *Entry) Never() (ctrl.Result, error) {
 	return ctrl.Result{}, nil
 }
 
+// setNext updates the next requeue duration using exponential backoff.
+// It multiplies the current duration by the store's multiplier and ensures
+// the result doesn't exceed the configured maximum interval.
 func (e *Entry) setNext() {
-	e.nextDuration = time.Duration(float32(e.nextDuration) * e.store.multiplier)
-	e.nextDuration = e.store.cap(e.nextDuration)
+	newDuration := time.Duration(float32(e.nextDuration) * e.store.multiplier)
+
+	if newDuration > e.store.maxInterval {
+		newDuration = e.store.maxInterval
+	}
+
+	e.nextDuration = newDuration
 }

pkg/smartrequeue/store_test.go

@@ -4,8 +4,10 @@ import (
 	"testing"
 	"time"
 
+	"github.com/openmcp-project/openmcp-operator/api/clusters/v1alpha1"
 	"github.com/stretchr/testify/assert"
 	ctrl "sigs.k8s.io/controller-runtime"
+	"sigs.k8s.io/controller-runtime/pkg/client"
 )
 
 func Test_Entry(t *testing.T) {
@@ -34,3 +36,100 @@ func Test_Entry(t *testing.T) {
 func getRequeueAfter(res ctrl.Result, _ error) time.Duration {
 	return res.RequeueAfter.Round(time.Second)
 }
+
+func TestFor(t *testing.T) {
+	tests := []struct {
+		name        string
+		firstObj    client.Object
+		secondObj   client.Object
+		expectSame  bool
+		description string
+	}{
+		{
+			name: "same object returns same entry",
+			firstObj: &v1alpha1.Cluster{
+				ObjectMeta: ctrl.ObjectMeta{
+					Name:      "test",
+					Namespace: "test",
+				},
+			},
+			secondObj: &v1alpha1.Cluster{
+				ObjectMeta: ctrl.ObjectMeta{
+					Name:      "test",
+					Namespace: "test",
+				},
+			},
+			expectSame:  true,
+			description: "Expected to get the same entry back",
+		},
+		{
+			name: "different namespace returns different entry",
+			firstObj: &v1alpha1.Cluster{
+				ObjectMeta: ctrl.ObjectMeta{
+					Name:      "test",
+					Namespace: "test",
+				},
+			},
+			secondObj: &v1alpha1.Cluster{
+				ObjectMeta: ctrl.ObjectMeta{
+					Name:      "test",
+					Namespace: "test2",
+				},
+			},
+			expectSame:  false,
+			description: "Expected to get a different entry back",
+		},
+		{
+			name: "different name returns different entry",
+			firstObj: &v1alpha1.Cluster{
+				ObjectMeta: ctrl.ObjectMeta{
+					Name:      "test",
+					Namespace: "test",
+				},
+			},
+			secondObj: &v1alpha1.Cluster{
+				ObjectMeta: ctrl.ObjectMeta{
+					Name:      "test2",
+					Namespace: "test",
+				},
+			},
+			expectSame:  false,
+			description: "Expected to get a different entry back",
+		},
+		{
+			name: "different kind returns different entry",
+			firstObj: &v1alpha1.Cluster{
+				ObjectMeta: ctrl.ObjectMeta{
+					Name:      "test",
+					Namespace: "test",
+				},
+			},
+			secondObj: &v1alpha1.AccessRequest{
+				ObjectMeta: ctrl.ObjectMeta{
+					Name:      "test",
+					Namespace: "test",
+				},
+			},
+			expectSame:  false,
+			description: "Expected to get a different entry back",
+		},
+	}
+
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			store := NewStore(time.Second, time.Minute, 2)
+			entry1 := store.For(tt.firstObj)
+
+			assert.NotNil(t, entry1, "Expected entry to be created")
+			assert.Equal(t, 1*time.Second, getRequeueAfter(entry1.Stable()))
+
+			entry2 := store.For(tt.secondObj)
+
+			if tt.expectSame {
+				assert.Equal(t, entry1, entry2, tt.description)
+			} else {
+				assert.NotEqual(t, entry1, entry2, tt.description)
+			}
+		})
+	}
+}