fix: replace illegal characters in condition types and reasons

Author: reshnm

pkg/controller/status_updater.go

@@ -436,11 +436,19 @@ func GenerateCreateConditionFunc[Obj client.Object](rr *ReconcileResult[Obj]) fu
 	}
 	return func(conType string, status metav1.ConditionStatus, reason, message string) {
 		rr.Conditions = append(rr.Conditions, metav1.Condition{
-			Type:               conType,
+			Type:               replaceIllegalCharsInConditionType(conType),
 			Status:             status,
 			ObservedGeneration: gen,
-			Reason:             reason,
+			Reason:             replaceIllegalCharsInConditionReason(reason),
 			Message:            message,
 		})
 	}
 }
+
+func replaceIllegalCharsInConditionType(s string) string {
+	return strings.NewReplacer(" ", "_", ",", "_", ";", "_", ":", "_").Replace(s)
+}
+
+func replaceIllegalCharsInConditionReason(s string) string {
+	return strings.NewReplacer(" ", "_", "-", "_", ".", "_").Replace(s)
+}

pkg/controller/status_updater_test.go

@@ -119,6 +119,21 @@ var _ = Describe("Status Updater", func() {
 		))
 	})
 
+	It("should replace illegal characters in condition type and reason", func() {
+		env := testutils.NewEnvironmentBuilder().WithFakeClient(coScheme).WithInitObjectPath("testdata", "test-02").WithDynamicObjectsWithStatus(&CustomObject{}).Build()
+		obj := &CustomObject{}
+		Expect(env.Client().Get(env.Ctx, controller.ObjectKey("status", "default"), obj)).To(Succeed())
+		rr := &controller.ReconcileResult[*CustomObject]{
+			Object: obj,
+		}
+		condFunc := controller.GenerateCreateConditionFunc(rr)
+
+		condFunc("CondType :,;Test", metav1.ConditionTrue, "Reason -.Test", "Message")
+		Expect(rr.Conditions).To(HaveLen(1))
+		Expect(rr.Conditions[0].Type).To(Equal("CondType____Test"))
+		Expect(rr.Conditions[0].Reason).To(Equal("Reason___Test"))
+	})
+
 	It("should not update disabled fields", func() {
 		env := testutils.NewEnvironmentBuilder().WithFakeClient(coScheme).WithInitObjectPath("testdata", "test-02").WithDynamicObjectsWithStatus(&CustomObject{}).Build()
 		obj := &CustomObject{}