Skip to content

Commit 3369ef9

Browse files
chore: install golangcilint in case not installed
Signed-off-by: Maximilian Braun (SAP) <[email protected]>
1 parent f67a857 commit 3369ef9

File tree

1 file changed

+16
-3
lines changed

1 file changed

+16
-3
lines changed

Makefile

Lines changed: 16 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -151,10 +151,14 @@ KUSTOMIZE ?= $(LOCALBIN)/kustomize
151151
CONTROLLER_GEN ?= $(LOCALBIN)/controller-gen
152152
ENVTEST ?= $(LOCALBIN)/setup-envtest
153153
GOTESTSUM ?= $(LOCALBIN)/gotestsum
154+
GOLANGCILINT ?= $(LOCALBIN)/golangci-lint
155+
156+
154157

155158
## Tool Versions
156159
KUSTOMIZE_VERSION ?= v5.4.1
157160
CONTROLLER_TOOLS_VERSION ?= v0.17.2
161+
GOLANGCILINT_VERSION ?= v1.64.5
158162

159163
.PHONY: kustomize
160164
kustomize: $(KUSTOMIZE) ## Download kustomize locally if necessary. If wrong version is installed, it will be removed before downloading.
@@ -279,10 +283,19 @@ dev-run:
279283
## todo: add flag --debug
280284
go run ./cmd/main.go
281285

286+
287+
$(GOLANGCILINT): $(LOCALBIN)
288+
@if test -x $(LOCALBIN)/golangci-lint && ! $(LOCALBIN)/golangci-lint version | grep -q $(GOLANGCILINT_VERSION); then \
289+
echo "$(LOCALBIN)/golangci-lint version is not expected $(GOLANGCILINT_VERSION). Removing it before installing."; \
290+
rm -rf $(LOCALBIN)/golangci-lint; \
291+
fi
292+
test -s $(golangci-lint)/golangci-lint || GOBIN=$(LOCALBIN) GO111MODULE=on go install github.com/golangci/golangci-lint/cmd/golangci-lint@$(GOLANGCILINT_VERSION)
293+
294+
282295
.PHONY: lint
283-
lint:
284-
golangci-lint config verify
285-
golangci-lint run ./...
296+
lint: $(GOLANGCILINT)
297+
$(GOLANGCILINT) config verify
298+
$(GOLANGCILINT) run ./...
286299

287300
.PHONY: lint-fix
288301
lint-fix:

0 commit comments

Comments
 (0)