fix remote ca ref, needs to be optional

Author: mirzakopic

api/v1alpha1/managedmetric_types.go

@@ -46,7 +46,8 @@ type ManagedMetricSpec struct {
 	// +kubebuilder:default:="10m"
 	Interval metav1.Duration `json:"interval,omitempty"`
 
-	RemoteClusterAccessRef `json:"remoteClusterAccessRef,omitempty"`
+	// +optional
+	*RemoteClusterAccessRef `json:"remoteClusterAccessRef,omitempty"`
 }
 
 // ManagedObservation represents the latest available observation of an object's state

api/v1alpha1/metric_types.go

@@ -55,7 +55,8 @@ type MetricSpec struct {
 	// +kubebuilder:default:="10m"
 	Interval metav1.Duration `json:"interval,omitempty"`
 
-	RemoteClusterAccessRef `json:"remoteClusterAccessRef,omitempty"`
+	// +optional
+	*RemoteClusterAccessRef `json:"remoteClusterAccessRef,omitempty"`
 
 	Projections []Projection `json:"projections,omitempty"`
 }

internal/controller/managedmetric_controller.go

@@ -111,7 +111,7 @@ func (r *ManagedMetricReconciler) Reconcile(ctx context.Context, req ctrl.Reques
 	/*
 		1.2 Create QueryConfig to query the resources in the K8S cluster or external cluster based on the kubeconfig secret reference
 	*/
-	queryConfig, err := createQueryConfig(ctx, &metric.Spec.RemoteClusterAccessRef, r)
+	queryConfig, err := createQueryConfig(ctx, metric.Spec.RemoteClusterAccessRef, r)
 	if err != nil {
 		return ctrl.Result{RequeueAfter: RequeueAfterError}, err
 	}

internal/controller/metric_controller.go

@@ -144,7 +144,7 @@ func (r *MetricReconciler) Reconcile(ctx context.Context, req ctrl.Request) (ctr
 	/*
 		1.2 Create QueryConfig to query the resources in the K8S cluster or external cluster based on the kubeconfig secret reference
 	*/
-	queryConfig, err := createQC(ctx, &metric.Spec.RemoteClusterAccessRef, r)
+	queryConfig, err := createQC(ctx, metric.Spec.RemoteClusterAccessRef, r)
 	if err != nil {
 		return ctrl.Result{RequeueAfter: RequeueAfterError}, err
 	}