fix: runtime panic (#28)

moelsayed · web-flow · commit e61c880f9f61 · 2025-06-05T11:32:26.000+02:00
* Fix local development configurations/examples

* Fix RemoteClusterAccessRef reference
diff --git a/api/v1alpha1/managedmetric_types.go b/api/v1alpha1/managedmetric_types.go
@@ -53,7 +53,7 @@ type ManagedMetricSpec struct {
 	DataSinkRef *DataSinkReference `json:"dataSinkRef,omitempty"`
 
 	// +optional
-	*RemoteClusterAccessRef `json:"remoteClusterAccessRef,omitempty"`
+	RemoteClusterAccessRef *RemoteClusterAccessRef `json:"remoteClusterAccessRef,omitempty"`
 }
 
 // ManagedObservation represents the latest available observation of an object's state
diff --git a/api/v1alpha1/metric_types.go b/api/v1alpha1/metric_types.go
@@ -69,7 +69,7 @@ type MetricSpec struct {
 	DataSinkRef *DataSinkReference `json:"dataSinkRef,omitempty"`
 
 	// +optional
-	*RemoteClusterAccessRef `json:"remoteClusterAccessRef,omitempty"`
+	RemoteClusterAccessRef *RemoteClusterAccessRef `json:"remoteClusterAccessRef,omitempty"`
 
 	Projections []Projection `json:"projections,omitempty"`
 }
diff --git a/examples/managed_metric.yaml b/examples/managed_metric.yaml
@@ -11,5 +11,5 @@ spec:
   interval: "1m" # in minutes
   # Uses default DataSink (named "default" in metrics-operator-system namespace)
   # To use a custom DataSink, uncomment and specify:
-  dataSinkRef:
-   name: other-datasink
+  # dataSinkRef:
+  #  name: other-datasink
diff --git a/examples/namespace.yaml b/examples/namespace.yaml
@@ -1,4 +1,4 @@
 apiVersion: v1
 kind: Namespace
 metadata:
-  name: co-metrics-operator
+  name: metrics-operator-system

Original file line number	Diff line number	Diff line change
`@@ -53,7 +53,7 @@ type ManagedMetricSpec struct {`
`53`	`53`	DataSinkRef *DataSinkReference `json:"dataSinkRef,omitempty"`
`54`	`54`
`55`	`55`	`// +optional`
`56`		- *RemoteClusterAccessRef `json:"remoteClusterAccessRef,omitempty"`
	`56`	+ RemoteClusterAccessRef *RemoteClusterAccessRef `json:"remoteClusterAccessRef,omitempty"`
`57`	`57`	`}`
`58`	`58`
`59`	`59`	`// ManagedObservation represents the latest available observation of an object's state`
Original file line number	Diff line number	Diff line change
`@@ -69,7 +69,7 @@ type MetricSpec struct {`
`69`	`69`	DataSinkRef *DataSinkReference `json:"dataSinkRef,omitempty"`
`70`	`70`
`71`	`71`	`// +optional`
`72`		- *RemoteClusterAccessRef `json:"remoteClusterAccessRef,omitempty"`
	`72`	+ RemoteClusterAccessRef *RemoteClusterAccessRef `json:"remoteClusterAccessRef,omitempty"`
`73`	`73`
`74`	`74`	Projections []Projection `json:"projections,omitempty"`
`75`	`75`	`}`