Skip to content

Commit 2f8d21d

Browse files
committed
bump controller-utils library dependency to v0.9.0
1 parent e0421dd commit 2f8d21d

File tree

7 files changed

+42
-34
lines changed

7 files changed

+42
-34
lines changed

go.mod

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ require (
1010
dario.cat/mergo v1.0.2
1111
github.com/onsi/ginkgo/v2 v2.23.4
1212
github.com/onsi/gomega v1.37.0
13-
github.com/openmcp-project/controller-utils v0.0.0-20250514103840-36be6cfff45a
13+
github.com/openmcp-project/controller-utils v0.9.0
1414
github.com/openmcp-project/openmcp-operator/api v0.4.0
1515
github.com/spf13/cobra v1.9.1
1616
k8s.io/api v0.33.1

go.sum

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -99,8 +99,8 @@ github.com/onsi/ginkgo/v2 v2.23.4 h1:ktYTpKJAVZnDT4VjxSbiBenUjmlL/5QkBEocaWXiQus
9999
github.com/onsi/ginkgo/v2 v2.23.4/go.mod h1:Bt66ApGPBFzHyR+JO10Zbt0Gsp4uWxu5mIOTusL46e8=
100100
github.com/onsi/gomega v1.37.0 h1:CdEG8g0S133B4OswTDC/5XPSzE1OeP29QOioj2PID2Y=
101101
github.com/onsi/gomega v1.37.0/go.mod h1:8D9+Txp43QWKhM24yyOBEdpkzN8FvJyAwecBgsU4KU0=
102-
github.com/openmcp-project/controller-utils v0.0.0-20250514103840-36be6cfff45a h1:Fw5gFq/cToWe4PKzTTjsSwreXRm98VKDTIFX18b8cxE=
103-
github.com/openmcp-project/controller-utils v0.0.0-20250514103840-36be6cfff45a/go.mod h1:/PeEIAdVHe9W1u0Nw8PlrKr5Gp3Wqwhnr2uo/Q7BtEI=
102+
github.com/openmcp-project/controller-utils v0.9.0 h1:S9g23FFbUBfHOkRTvpjT826hcbX5SXd/gZ9VT83V7Lg=
103+
github.com/openmcp-project/controller-utils v0.9.0/go.mod h1:j0FuxU5JhlDq+XkWNhDUY+k8AuqFINqXWjX7dlpQlNU=
104104
github.com/pkg/errors v0.9.1 h1:FEBLx1zS214owpjy7qsBeixbURkuhQAwrK5UwLGTwt4=
105105
github.com/pkg/errors v0.9.1/go.mod h1:bwawxfHBFNV+L2hUp1rHADufV3IMtnDRdf1r5NINEl0=
106106
github.com/pmezard/go-difflib v1.0.0/go.mod h1:iKH77koFhYxTK1pcRnkKkqfTogsbg7gZNVY4sRDYZ/4=

internal/controllers/provider/install/deployment.go

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@ import (
88
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
99
"k8s.io/apimachinery/pkg/runtime"
1010
"k8s.io/utils/ptr"
11-
"sigs.k8s.io/controller-runtime/pkg/client"
1211
"sigs.k8s.io/controller-runtime/pkg/controller/controllerutil"
1312

1413
"github.com/openmcp-project/controller-utils/pkg/resources"
@@ -18,16 +17,22 @@ import (
1817

1918
type deploymentMutator struct {
2019
values *Values
21-
meta resources.Mutator[client.Object]
20+
meta resources.MetadataMutator
2221
}
2322

2423
var _ resources.Mutator[*appsv1.Deployment] = &deploymentMutator{}
2524

2625
func newDeploymentMutator(values *Values) resources.Mutator[*appsv1.Deployment] {
27-
return &deploymentMutator{
26+
res := &deploymentMutator{
2827
values: values,
29-
meta: resources.NewMetadataMutator(values.LabelsController(), nil),
28+
meta: resources.NewMetadataMutator(),
3029
}
30+
res.meta.WithLabels(values.LabelsController())
31+
return res
32+
}
33+
34+
func (m *deploymentMutator) MetadataMutator() resources.MetadataMutator {
35+
return m.meta
3136
}
3237

3338
func (m *deploymentMutator) String() string {

internal/controllers/provider/install/installer.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ func (a *Installer) InstallInitJob(ctx context.Context) (completed bool, err err
3838

3939
values := NewValues(a.Provider, a.DeploymentSpec, a.Environment)
4040

41-
if err := resources.CreateOrUpdateResource(ctx, a.PlatformClient, resources.NewNamespaceMutator(values.Namespace(), nil, nil)); err != nil {
41+
if err := resources.CreateOrUpdateResource(ctx, a.PlatformClient, resources.NewNamespaceMutator(values.Namespace())); err != nil {
4242
return false, err
4343
}
4444

internal/controllers/provider/install/job.go

Lines changed: 10 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@ import (
99
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
1010
"k8s.io/apimachinery/pkg/runtime"
1111
"k8s.io/utils/ptr"
12-
"sigs.k8s.io/controller-runtime/pkg/client"
1312
"sigs.k8s.io/controller-runtime/pkg/controller/controllerutil"
1413

1514
"github.com/openmcp-project/openmcp-operator/api/install"
@@ -19,21 +18,23 @@ import (
1918
type jobMutator struct {
2019
values *Values
2120
deploymentSpec *v1alpha1.DeploymentSpec
22-
meta resources.Mutator[client.Object]
21+
meta resources.MetadataMutator
2322
}
2423

2524
var _ resources.Mutator[*v1.Job] = &jobMutator{}
2625

27-
func newJobMutator(
28-
values *Values,
29-
deploymentSpec *v1alpha1.DeploymentSpec,
30-
annotations map[string]string,
31-
) resources.Mutator[*v1.Job] {
32-
return &jobMutator{
26+
func newJobMutator(values *Values, deploymentSpec *v1alpha1.DeploymentSpec, annotations map[string]string) resources.Mutator[*v1.Job] {
27+
res := &jobMutator{
3328
values: values,
3429
deploymentSpec: deploymentSpec,
35-
meta: resources.NewMetadataMutator(values.LabelsInitJob(), annotations),
30+
meta: resources.NewMetadataMutator(),
3631
}
32+
res.meta.WithLabels(values.LabelsInitJob()).WithAnnotations(annotations)
33+
return res
34+
}
35+
36+
func (m *jobMutator) MetadataMutator() resources.MetadataMutator {
37+
return m.meta
3738
}
3839

3940
func (m *jobMutator) String() string {

internal/controllers/provider/install/rbac.go

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -7,15 +7,16 @@ import (
77
)
88

99
func newProviderServiceAccountMutator(values *Values) resources.Mutator[*corev1.ServiceAccount] {
10-
return resources.NewServiceAccountMutator(
10+
res := resources.NewServiceAccountMutator(
1111
values.NamespacedDefaultResourceName(),
1212
values.Namespace(),
13-
values.LabelsController(),
14-
nil)
13+
)
14+
res.MetadataMutator().WithLabels(values.LabelsController())
15+
return res
1516
}
1617

1718
func newProviderClusterRoleBindingMutator(values *Values) resources.Mutator[*rbac.ClusterRoleBinding] {
18-
return resources.NewClusterRoleBindingMutator(
19+
res := resources.NewClusterRoleBindingMutator(
1920
values.ClusterScopedDefaultResourceName(),
2021
[]rbac.Subject{
2122
{
@@ -25,6 +26,7 @@ func newProviderClusterRoleBindingMutator(values *Values) resources.Mutator[*rba
2526
},
2627
},
2728
resources.NewClusterRoleRef("cluster-admin"),
28-
values.LabelsController(),
29-
nil)
29+
)
30+
res.MetadataMutator().WithLabels(values.LabelsController())
31+
return res
3032
}

internal/controllers/provider/install/rbac_init.go

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -7,16 +7,14 @@ import (
77
)
88

99
func newInitServiceAccountMutator(values *Values) resources.Mutator[*corev1.ServiceAccount] {
10-
return resources.NewServiceAccountMutator(
11-
values.NamespacedResourceName(initPrefix),
12-
values.Namespace(),
13-
values.LabelsInitJob(),
14-
nil)
10+
res := resources.NewServiceAccountMutator(values.NamespacedResourceName(initPrefix), values.Namespace())
11+
res.MetadataMutator().WithLabels(values.LabelsInitJob())
12+
return res
1513
}
1614

1715
func newInitClusterRoleBindingMutator(values *Values) resources.Mutator[*rbac.ClusterRoleBinding] {
1816
clusterRoleName := values.ClusterScopedResourceName(initPrefix)
19-
return resources.NewClusterRoleBindingMutator(
17+
res := resources.NewClusterRoleBindingMutator(
2018
clusterRoleName,
2119
[]rbac.Subject{
2220
{
@@ -26,12 +24,13 @@ func newInitClusterRoleBindingMutator(values *Values) resources.Mutator[*rbac.Cl
2624
},
2725
},
2826
resources.NewClusterRoleRef(clusterRoleName),
29-
values.LabelsInitJob(),
30-
nil)
27+
)
28+
res.MetadataMutator().WithLabels(values.LabelsInitJob())
29+
return res
3130
}
3231

3332
func newInitClusterRoleMutator(values *Values) resources.Mutator[*rbac.ClusterRole] {
34-
return resources.NewClusterRoleMutator(
33+
res := resources.NewClusterRoleMutator(
3534
values.ClusterScopedResourceName(initPrefix),
3635
[]rbac.PolicyRule{
3736
{
@@ -50,6 +49,7 @@ func newInitClusterRoleMutator(values *Values) resources.Mutator[*rbac.ClusterRo
5049
Verbs: []string{"get", "list", "watch", "create", "update", "patch", "delete"},
5150
},
5251
},
53-
values.LabelsInitJob(),
54-
nil)
52+
)
53+
res.MetadataMutator().WithLabels(values.LabelsInitJob())
54+
return res
5555
}

0 commit comments

Comments
 (0)