add tests for preemptive scheduling logic

Author: Diaphteiros

internal/controllers/scheduler/controller.go

@@ -444,11 +444,13 @@ func RemoveFinalizerWithPrefix(obj client.Object, prefix string) (string, bool)
 	fins := obj.GetFinalizers()
 	length := len(fins)
 	suffix := ""
+	found := false
 
 	index := 0
-	for i := 0; i < length; i++ {
-		if strings.HasPrefix(fins[i], prefix) {
+	for i := range length {
+		if !found && strings.HasPrefix(fins[i], prefix) {
 			suffix = strings.TrimPrefix(fins[i], prefix)
+			found = true
 			continue
 		}
 		fins[index] = fins[i]

internal/controllers/scheduler/controller_test.go

@@ -0,0 +1,9 @@
+apiVersion: clusters.openmcp.cloud/v1alpha1
+kind: ClusterRequest
+metadata:
+  name: exclusive-p
+  namespace: foo
+  uid: e69e7465-2d8a-4842-84ed-b94e29e27d46
+spec:
+  purpose: exclusive
+  preemptive: true

internal/controllers/scheduler/testdata/test-01/cluster/reqp-0.yaml

@@ -0,0 +1,9 @@
+apiVersion: clusters.openmcp.cloud/v1alpha1
+kind: ClusterRequest
+metadata:
+  name: shared-p
+  namespace: foo
+  uid: 21d1a0be-a5d0-49d8-a8f4-dbd91cf4b47e
+spec:
+  purpose: shared-twice
+  preemptive: true

internal/controllers/scheduler/testdata/test-01/cluster/reqp-1.yaml

@@ -0,0 +1,9 @@
+apiVersion: clusters.openmcp.cloud/v1alpha1
+kind: ClusterRequest
+metadata:
+  name: shared2-p
+  namespace: foo
+  uid: 87b231f8-0f02-416f-bdb6-2ffedb0df506
+spec:
+  purpose: shared-twice
+  preemptive: true

internal/controllers/scheduler/testdata/test-01/cluster/reqp-2.yaml

@@ -0,0 +1,9 @@
+apiVersion: clusters.openmcp.cloud/v1alpha1
+kind: ClusterRequest
+metadata:
+  name: shared3-p
+  namespace: foo
+  uid: daba0b3c-0f94-46b2-81dd-a23921512696
+spec:
+  purpose: shared-twice
+  preemptive: true

internal/controllers/scheduler/testdata/test-01/cluster/reqp-3.yaml

@@ -0,0 +1,9 @@
+apiVersion: clusters.openmcp.cloud/v1alpha1
+kind: ClusterRequest
+metadata:
+  name: delete-p
+  namespace: foo
+  uid: 4d6aa495-54c0-4df2-bc7b-05b103f02e69
+spec:
+  purpose: delete
+  preemptive: true

internal/controllers/scheduler/testdata/test-05/cluster/reqp-0.yaml

@@ -0,0 +1,9 @@
+apiVersion: clusters.openmcp.cloud/v1alpha1
+kind: ClusterRequest
+metadata:
+  name: no-delete-p
+  namespace: foo
+  uid: bf7d8a52-ea1e-4303-a0f9-bf2ef0cc21ea
+spec:
+  purpose: no-delete
+  preemptive: true