remove label selector from DNSServiceConfig

The label selector is incompatible with the current implementation that loads the config
on-demand during each reconciliation.
We would either need to load it once during startup, which would mean that the controller
needs to be restarted for changes to take effect,
or we would need a more complicated setup with an own controller for the config.

Since clusters can already be filtered by their purposes, there is probably no need for
a label selector anyway, at least not for now.

Author: Diaphteiros

api/crds/manifests/dns.openmcp.cloud_dnsserviceconfigs.yaml

@@ -664,54 +664,6 @@ spec:
                   The value can be overwritten for specific purposes using ExternalDNSForPurposes.
                   If not set, a default of 1h is used.
                 type: string
-              selector:
-                description: |-
-                  Selector is a label selector.
-                  If not nil, only Clusters that match the selector will be reconciled by the controller.
-                properties:
-                  matchExpressions:
-                    description: matchExpressions is a list of label selector requirements.
-                      The requirements are ANDed.
-                    items:
-                      description: |-
-                        A label selector requirement is a selector that contains values, a key, and an operator that
-                        relates the key and values.
-                      properties:
-                        key:
-                          description: key is the label key that the selector applies
-                            to.
-                          type: string
-                        operator:
-                          description: |-
-                            operator represents a key's relationship to a set of values.
-                            Valid operators are In, NotIn, Exists and DoesNotExist.
-                          type: string
-                        values:
-                          description: |-
-                            values is an array of string values. If the operator is In or NotIn,
-                            the values array must be non-empty. If the operator is Exists or DoesNotExist,
-                            the values array must be empty. This array is replaced during a strategic
-                            merge patch.
-                          items:
-                            type: string
-                          type: array
-                          x-kubernetes-list-type: atomic
-                      required:
-                      - key
-                      - operator
-                      type: object
-                    type: array
-                    x-kubernetes-list-type: atomic
-                  matchLabels:
-                    additionalProperties:
-                      type: string
-                    description: |-
-                      matchLabels is a map of {key,value} pairs. A single {key,value} in the matchLabels
-                      map is equivalent to an element of matchExpressions, whose key field is "key", the
-                      operator is "In", and the values array contains only "value". The requirements are ANDed.
-                    type: object
-                type: object
-                x-kubernetes-map-type: atomic
             required:
             - externalDNSSource
             type: object

api/dns/v1alpha1/config_types.go

@@ -13,11 +13,6 @@ import (
 
 // DNSServiceConfigSpec defines the desired state of DNSServiceConfig
 type DNSServiceConfigSpec struct {
-	// Selector is a label selector.
-	// If not nil, only Clusters that match the selector will be reconciled by the controller.
-	// +optional
-	Selector *metav1.LabelSelector `json:"selector,omitempty"`
-
 	// ExternalDNSSource is the source of the external-dns helm chart.
 	ExternalDNSSource ExternalDNSSource `json:"externalDNSSource"`