fix: component creation without secrets (#69)

* fix: component creation without secrets

On-behalf-of: Radek Schekalla (SAP) <[email protected]>
Signed-off-by: Radek Schekalla (SAP) <[email protected]>

* chore: bump version

On-behalf-of: Radek Schekalla (SAP) <[email protected]>
Signed-off-by: Radek Schekalla (SAP) <[email protected]>

* chore: update comments in tests

On-behalf-of: Radek Schekalla (SAP) <[email protected]>
Signed-off-by: Radek Schekalla (SAP) <[email protected]>

* chore: update func desc

On-behalf-of: Radek Schekalla (SAP) <[email protected]>
Signed-off-by: Radek Schekalla (SAP) <[email protected]>

---------

Signed-off-by: Radek Schekalla (SAP) <[email protected]>

Author: rdksap

VERSION

@@ -1 +1 @@
-v0.1.3-dev
+v0.1.4

internal/controller/crossplane_controller.go

@@ -368,7 +368,7 @@ func buildComponents(ctx context.Context, client client.Client, xp *v1alpha1.Cro
 	xpComp := &component.Crossplane{
 		Enabled:              enabled,
 		Config:               &xp.Spec,
-		ChartPullSecretName:  extractSecretNames(xpHelmChartPullSecrets)[0],
+		ChartPullSecretName:  extractFirstSecretName(xpHelmChartPullSecrets),
 		ImagePullSecretNames: extractSecretNames(xpContainerImagePullSecrets),
 	}
 	comps = append(comps, xpComp)
@@ -509,6 +509,19 @@ func extractSecretNames(secrets []commonapi.LocalObjectReference) []string {
 	return result
 }
 
+// extractFirstSecretName extracts the first not-empty name from a slice of LocalObjectReference
+func extractFirstSecretName(secrets []commonapi.LocalObjectReference) string {
+	if len(secrets) == 0 {
+		return ""
+	}
+	for _, secret := range secrets {
+		if secret.Name != "" {
+			return secret.Name
+		}
+	}
+	return ""
+}
+
 // deduplicateSecretRefs removes duplicate secret references based on name
 func deduplicateSecretRefs(secrets []commonapi.LocalObjectReference) []commonapi.LocalObjectReference {
 	if len(secrets) == 0 {

internal/controller/crossplane_controller_test.go

@@ -166,9 +166,59 @@ func Test_buildComponents(t *testing.T) {
 		args    args
 		want    []juggler.Component
 		wantErr error
-	}{
+	}{{
+		name: "Crossplane and crossplane-provider components are built and enabled",
+		args: args{
+			ctx:             rcontext.WithTenantNamespace(context.Background(), "tenant-namespace"),
+			client:          nil,
+			setPodNamespace: true,
+			xp: &v1alpha1.Crossplane{
+				Spec: v1alpha1.CrossplaneSpec{
+					Version:   "v1.0.0",
+					Providers: []*v1alpha1.CrossplaneProviderConfig{{Name: "provider-1", Version: "v0.1.0"}},
+				},
+			},
+			pc: &v1alpha1.ProviderConfig{
+				Spec: v1alpha1.ProviderConfigSpec{
+					CrossplaneVersions: []v1alpha1.CrossplaneVersion{
+						{
+							Version: "v1.0.0",
+							Chart:   v1alpha1.ChartSpec{URL: "https://charts.example.com/1"},
+							Image:   v1alpha1.ImageSpec{URL: "https://images.example.com/1"},
+						},
+						{
+							Version: "v2.0.0",
+							Chart:   v1alpha1.ChartSpec{URL: "https://charts.example.com/2"},
+							Image:   v1alpha1.ImageSpec{URL: "https://images.example.com/2"},
+						},
+					},
+					Providers: v1alpha1.CrossplaneProviders{
+						AvailableProviders: []v1alpha1.AvailableCrossplaneProvider{
+							{Name: "provider-1", Versions: []string{"v0.1.0"}, Package: "crossplane/provider-aws:v0.1.0"},
+							{Name: "provider-2", Versions: []string{"v0.1.0"}, Package: "crossplane/provider-other:v0.1.0"},
+						},
+					},
+				},
+			},
+			enabled: true,
+		},
+		want: []juggler.Component{
+			&component.Crossplane{
+				Enabled: true,
+				Config: &v1alpha1.CrossplaneSpec{
+					Version:   "v1.0.0",
+					Providers: []*v1alpha1.CrossplaneProviderConfig{{Name: "provider-1", Version: "v0.1.0"}},
+				},
+			},
+			&component.CrossplaneProvider{
+				Enabled: true,
+				Config:  &v1alpha1.CrossplaneProviderConfig{Name: "provider-1", Version: "v0.1.0"},
+			},
+		},
+		wantErr: nil,
+	},
 		{
-			name: "Crossplane components are built and enabled",
+			name: "Crossplane, crossplane-provider, platform-secret and secret components are built and enabled",
 			args: args{
 				ctx:             rcontext.WithTenantNamespace(context.Background(), "tenant-namespace"),
 				client:          nil,
@@ -317,7 +367,7 @@ func Test_buildComponents(t *testing.T) {
 			},
 			want: []juggler.Component{
 				// Components expected to be built containing ALL (platform)secrets from providerConfig,
-				// regardless of whether they are used by Crossplane or its providers
+				// regardless of whether they are used by Crossplane or its providers. Duplicates removed.
 				&component.Crossplane{
 					Enabled: true,
 					Config: &v1alpha1.CrossplaneSpec{
@@ -354,7 +404,7 @@ func Test_buildComponents(t *testing.T) {
 			wantErr: nil,
 		},
 		{
-			name: "Crossplane components are built and NOT enabled",
+			name: "Components are built and disabled (for deletion)",
 			args: args{
 				ctx:             rcontext.WithTenantNamespace(context.Background(), "tenant-namespace"),
 				client:          nil,