PR changes

Author: Hubert-Szczepanski-SAP

src/hooks/useDeleteWorkspace.spec.ts

@@ -40,13 +40,11 @@ describe('useDeleteWorkspace', () => {
     const renderHookResult = renderHook(() => useDeleteWorkspace('test-project', 'test-project--ns', 'test-workspace'));
     const { deleteWorkspace } = renderHookResult.result.current;
 
-    let result: boolean = false;
     await act(async () => {
-      result = await deleteWorkspace();
+      await deleteWorkspace();
     });
 
     // ASSERT
-    expect(result).toBe(true);
     expect(fetchMock).toHaveBeenCalledTimes(1);
 
     const call = fetchMock.mock.calls[0];
@@ -66,38 +64,32 @@ describe('useDeleteWorkspace', () => {
     );
   });
 
-  it('should return false on API error', async () => {
+  it('should throw error on API failure', async () => {
     // ARRANGE
     fetchMock.mockRejectedValue(new Error('API Error'));
 
     // ACT
     const renderHookResult = renderHook(() => useDeleteWorkspace('test-project', 'test-project--ns', 'test-workspace'));
     const { deleteWorkspace } = renderHookResult.result.current;
 
-    let result: boolean = true;
+    // ASSERT
     await act(async () => {
-      result = await deleteWorkspace();
+      await expect(deleteWorkspace()).rejects.toThrow('API Error');
     });
-
-    // ASSERT
-    expect(result).toBe(false);
   });
 
-  it('should return false on network error', async () => {
+  it('should throw error on network failure', async () => {
     // ARRANGE
     fetchMock.mockRejectedValue(new TypeError('Network error'));
 
     // ACT
     const renderHookResult = renderHook(() => useDeleteWorkspace('test-project', 'test-project--ns', 'test-workspace'));
     const { deleteWorkspace } = renderHookResult.result.current;
 
-    let result: boolean = true;
+    // ASSERT
     await act(async () => {
-      result = await deleteWorkspace();
+      await expect(deleteWorkspace()).rejects.toThrow('Network error');
     });
-
-    // ASSERT
-    expect(result).toBe(false);
     expect(fetchMock).toHaveBeenCalledTimes(1);
   });
 });

src/hooks/useDeleteWorkspace.ts

@@ -14,16 +14,10 @@ export function useDeleteWorkspace(projectName: string, projectNamespace: string
   );
   const revalidate = useRevalidateApiResource(ListWorkspaces(projectName));
 
-  const deleteWorkspace = useCallback(async (): Promise<boolean> => {
-    try {
-      await trigger();
-      await revalidate();
-      toast.show(t('ControlPlaneListWorkspaceGridTile.deleteConfirmationDialog'));
-      return true;
-    } catch (e) {
-      console.error('Failed to delete workspace:', e);
-      return false;
-    }
+  const deleteWorkspace = useCallback(async (): Promise<void> => {
+    await trigger();
+    await revalidate();
+    toast.show(t('ControlPlaneListWorkspaceGridTile.deleteConfirmationDialog'));
   }, [trigger, revalidate, toast, t]);
 
   return {