Skip to content

Commit 1ec7205

Browse files
Linting issues fix + rebase
1 parent 765aa9e commit 1ec7205

File tree

4 files changed

+15
-18
lines changed

4 files changed

+15
-18
lines changed

src/components/Shared/IllustratedError.tsx

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -8,10 +8,7 @@ interface Props {
88
details?: string;
99
}
1010

11-
export default function IllustratedError({
12-
title,
13-
details,
14-
}: Props) {
11+
export default function IllustratedError({ title, details }: Props) {
1512
const { t } = useTranslation();
1613

1714
return (

src/components/Ui/IllustratedBanner/IllustratedBanner.tsx

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -7,19 +7,19 @@ import '@ui5/webcomponents-fiori/dist/illustrations/AllIllustrations.js';
77
type InfoBannerProps = {
88
title: string;
99
subtitle: string;
10-
illustrationName?: IllustrationMessageType // e.g. 'NoData', 'SimpleError', etc.
10+
illustrationName?: IllustrationMessageType; // e.g. 'NoData', 'SimpleError', etc.
1111
help?: {
1212
link: string;
1313
buttonText: string;
1414
buttonIcon?: string;
15-
}
15+
};
1616
};
1717

1818
export const IllustratedBanner = ({
1919
title,
2020
subtitle,
2121
illustrationName = IllustrationMessageType.NoData,
22-
help
22+
help,
2323
}: InfoBannerProps) => {
2424
return (
2525
<FlexBox direction="Column" alignItems="Center">
@@ -30,10 +30,12 @@ export const IllustratedBanner = ({
3030
subtitleText={subtitle}
3131
/>
3232
{help?.buttonText && help.link && (
33-
<a href={help.link} target='_blank'>
33+
<a href={help.link} target="_blank" rel="noreferrer">
3434
<Button
3535
design={ButtonDesign.Transparent}
36-
icon={help.buttonIcon ? help.buttonIcon : 'sap-icon://question-mark'}
36+
icon={
37+
help.buttonIcon ? help.buttonIcon : 'sap-icon://question-mark'
38+
}
3739
>
3840
{help.buttonIcon}
3941
</Button>

src/context/AuthProviderOnboarding.tsx

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,7 @@
11
import { ReactNode } from 'react';
2-
import { AuthProvider } from 'react-oidc-context';
2+
import { AuthProvider, AuthProviderProps } from 'react-oidc-context';
33
import { OIDCConfig, useFrontendConfig } from './FrontendConfigContext.tsx';
4-
import { WebStorageStateStore } from "oidc-client-ts";
5-
import { AuthProviderProps } from "react-oidc-context";
6-
4+
import { WebStorageStateStore } from 'oidc-client-ts';
75

86
interface AuthProviderOnboardingProps {
97
children?: ReactNode;
@@ -33,4 +31,4 @@ function buildAuthProviderConfig(oidcConfig: OIDCConfig) {
3331
},
3432
};
3533
return props;
36-
}
34+
}

src/context/FrontendConfigContext.tsx

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -10,16 +10,16 @@ export enum Landscape {
1010
Local = 'LOCAL',
1111
}
1212

13-
14-
1513
interface FrontendConfigContextType extends FrontendConfig {
1614
links: DocLinkCreator;
1715
}
1816

1917
export const FrontendConfigContext =
2018
createContext<FrontendConfigContextType | null>(null);
2119

22-
const fetchPromise = fetch('/frontend-config.json').then((res) => res.json()).then((data) => validateAndCastFrontendConfig(data));
20+
const fetchPromise = fetch('/frontend-config.json')
21+
.then((res) => res.json())
22+
.then((data) => validateAndCastFrontendConfig(data));
2323

2424
interface FrontendConfigProviderProps {
2525
children: ReactNode;
@@ -72,4 +72,4 @@ function validateAndCastFrontendConfig(config: unknown): FrontendConfig {
7272
} catch (error) {
7373
throw new Error(`Invalid frontend config: ${error}`);
7474
}
75-
}
75+
}

0 commit comments

Comments
 (0)