fixes

Author: lucasgoral

src/components/ControlPlanes/ControlPlaneCard/ControlPlaneCard.tsx

@@ -28,6 +28,8 @@ import { canConnectToMCP } from '../controlPlanes.ts';
 import { Infobox } from '../../Ui/Infobox/Infobox.tsx';
 
 import { ControlPlaneCardMenu } from './ControlPlaneCardMenu.tsx';
+import { CreateManagedControlPlaneWizardContainer } from '../../Wizards/CreateManagedControlPlane/CreateManagedControlPlaneWizardContainer.tsx';
+import { EditManagedControlPlaneWizardDataLoader } from '../../Wizards/CreateManagedControlPlane/EditManagedControlPlaneWizardDataLoader.tsx';
 
 interface Props {
   controlPlane: ListControlPlanesType;
@@ -39,7 +41,7 @@ export function ControlPlaneCard({ controlPlane, workspace, projectName }: Props
   const [dialogDeleteMcpIsOpen, setDialogDeleteMcpIsOpen] = useState(false);
   const toast = useToast();
   const { t } = useTranslation();
-
+  const [isEditManagedControlPlaneWizardOpen, setIsEditManagedControlPlaneWizardOpen] = useState(false);
   const { trigger: patchTrigger } = useApiResourceMutation<DeleteMCPType>(
     PatchMCPResourceForDeletion(controlPlane.metadata.namespace, controlPlane.metadata.name),
   );
@@ -79,7 +81,7 @@ export function ControlPlaneCard({ controlPlane, workspace, projectName }: Props
               <ControlPlaneCardMenu
                 setDialogDeleteMcpIsOpen={setDialogDeleteMcpIsOpen}
                 isDeleteMcpButtonDisabled={controlPlane.status?.status === ReadyStatus.InDeletion}
-                // setIsCreateManagedControlPlaneWizardOpen={setIsCreateManagedControlPlaneWizardOpen}
+                setIsEditManagedControlPlaneWizardOpen={setIsEditManagedControlPlaneWizardOpen}
               />
               <FlexBox direction="Row" justifyContent="SpaceBetween" alignItems="Center" gap={10}>
                 <YamlViewButtonWithLoader
@@ -123,6 +125,13 @@ export function ControlPlaneCard({ controlPlane, workspace, projectName }: Props
           toast.show(t('ControlPlaneCard.deleteConfirmationDialog'));
         }}
       />
+      <EditManagedControlPlaneWizardDataLoader
+        isOpen={isEditManagedControlPlaneWizardOpen}
+        setIsOpen={setIsEditManagedControlPlaneWizardOpen}
+        projectName={projectName}
+        workspaceName={namespace}
+        resourceName={name}
+      />
     </>
   );
 }

src/components/ControlPlanes/ControlPlaneCard/ControlPlaneCardMenu.tsx

@@ -9,16 +9,14 @@ import { useTranslation } from 'react-i18next';
 type ControlPlanesListMenuProps = {
   setDialogDeleteMcpIsOpen: Dispatch<SetStateAction<boolean>>;
   isDeleteMcpButtonDisabled: boolean;
-  // setIsCreateManagedControlPlaneWizardOpen: Dispatch<SetStateAction<boolean>>;
+  setIsEditManagedControlPlaneWizardOpen: Dispatch<SetStateAction<boolean>>;
 };
 
 export const ControlPlaneCardMenu: FC<ControlPlanesListMenuProps> = ({
   setDialogDeleteMcpIsOpen,
   isDeleteMcpButtonDisabled,
-  // setIsCreateManagedControlPlaneWizardOpen,
+  setIsEditManagedControlPlaneWizardOpen,
 }) => {
-  // const popoverRef = useRef<MenuDomRef>(null);
-
   const buttonRef = useRef(null);
   const [menuIsOpen, setMenuIsOpen] = useState(false);
   const { t } = useTranslation();
@@ -36,7 +34,7 @@ export const ControlPlaneCardMenu: FC<ControlPlanesListMenuProps> = ({
         onItemClick={(event) => {
           const action = (event.detail.item as HTMLElement).dataset.action;
           if (action === 'editMcp') {
-            // setIsCreateManagedControlPlaneWizardOpen(true);
+            setIsEditManagedControlPlaneWizardOpen(true);
           }
           if (action === 'deleteMcp') {
             setDialogDeleteMcpIsOpen(true);
@@ -48,12 +46,6 @@ export const ControlPlaneCardMenu: FC<ControlPlanesListMenuProps> = ({
           setMenuIsOpen(false);
         }}
       >
-        {/*<MenuItem*/}
-        {/*  key={'add'}*/}
-        {/*  text={t('ControlPlaneListToolbar.createNewManagedControlPlane')}*/}
-        {/*  data-action="newManagedControlPlane"*/}
-        {/*  icon="add"*/}
-        {/*/>*/}
         <MenuItem
           key={'delete'}
           text={t('ControlPlaneCard.deleteMCP')}

src/components/ControlPlanes/List/ControlPlaneListWorkspaceGridTile.tsx

@@ -189,7 +189,7 @@ export function ControlPlaneListWorkspaceGridTile({ projectName, workspace }: Pr
         projectName={projectNamespace}
         workspaceName={workspaceName}
         initialTemplateName={initialTemplateName}
-        isEditMode={true}
+        isEditMode={false}
       />
     </>
   );

src/components/Dialogs/MetadataForm.tsx

@@ -110,15 +110,6 @@ export function MetadataForm({
         <Label for="name" required>
           {t('CreateProjectWorkspaceDialog.nameLabel')}
         </Label>
-        <Input
-          className={styles.input}
-          id="name"
-          {...register('name')}
-          valueState={errors.name ? 'Negative' : 'None'}
-          valueStateMessage={<span>{errors.name?.message}</span>}
-          required
-          disabled={isEditMode}
-        />
 
         {resolvedNamePrefix || resolvedNameSuffix ? (
           <div className={styles.affixRow}>
@@ -140,6 +131,7 @@ export function MetadataForm({
               valueState={errors.name ? 'Negative' : 'None'}
               valueStateMessage={<span>{errors.name?.message}</span>}
               required
+              disabled={isEditMode}
               onInput={onNameCoreInput}
             />
             {resolvedNameSuffix ? (
@@ -160,6 +152,7 @@ export function MetadataForm({
             valueState={errors.name ? 'Negative' : 'None'}
             valueStateMessage={<span>{errors.name?.message}</span>}
             required
+            disabled={isEditMode}
           />
         )}
 
@@ -188,7 +181,9 @@ export function MetadataForm({
               />
             ) : null}
           </div>
-        ) : (        <Input id="displayName" {...register('displayName')} className={styles.input} />)}
+        ) : (
+          <Input id="displayName" {...register('displayName')} className={styles.input} />
+        )}
         <div>
           <Label for={'chargingTargetType'}>{t('CreateProjectWorkspaceDialog.chargingTargetTypeLabel')}</Label>
         </div>
@@ -197,10 +192,16 @@ export function MetadataForm({
           value={watch?.('chargingTargetType') ?? ''}
           id={'chargingTargetType'}
           className={styles.input}
-         disabled={disableChargingFields} onChange={handleChargingTargetTypeChange}
+          disabled={disableChargingFields}
+          onChange={handleChargingTargetTypeChange}
         >
           {chargingTypes.map((option) => (
-            <Option key={option.value} value={option.value} data-value={option.value} selected={currentChargingTargetType === option.value}>
+            <Option
+              key={option.value}
+              value={option.value}
+              data-value={option.value}
+              selected={currentChargingTargetType === option.value}
+            >
               {option.label}
             </Option>
           ))}