Skip to content

Commit 2f0a9bc

Browse files
committed
feat: remove MCP name from breadcrumbs
1 parent 38c7fed commit 2f0a9bc

File tree

4 files changed

+6
-24
lines changed

4 files changed

+6
-24
lines changed

public/locales/en.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
"signInButton": "Sign in"
77
},
88
"Entities": {
9-
"ManagedControlPlane": "Managed Control Plane",
9+
"ManagedControlPlane": "ManagedControlPlane",
1010
"Project": "Project",
1111
"Workspace": "Workspace",
1212
"Users": "Users",

src/components/Core/PathAwareBreadcrumbs/PathAwareBreadcrumbs.cy.tsx

Lines changed: 3 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -20,11 +20,10 @@ describe('PathAwareBreadcrumbs', () => {
2020
cy.mount(<PathAwareBreadcrumbs useNavigate={fakeUseNavigate} useParams={fakeUseParams} />);
2121

2222
// Check that all breadcrumbs are rendered
23-
cy.get("[data-testid='breadcrumb-item']").should('have.length', 4);
23+
cy.get("[data-testid='breadcrumb-item']").should('have.length', 3);
2424
cy.get("[data-testid='breadcrumb-item']").eq(0).should('contain', '[LOCAL] Projects');
2525
cy.get("[data-testid='breadcrumb-item']").eq(1).should('contain', 'my-project');
2626
cy.get("[data-testid='breadcrumb-item']").eq(2).should('contain', 'my-workspace');
27-
cy.get("[data-testid='breadcrumb-item']").eq(3).should('contain', 'my-control-plane');
2827
});
2928

3029
it('navigates when clicking breadcrumbs for all path parameters', () => {
@@ -47,12 +46,6 @@ describe('PathAwareBreadcrumbs', () => {
4746
cy.wrap(null).then(() => {
4847
expect(lastNavigatedPath).to.equal('/mcp/projects/my-project');
4948
});
50-
51-
// Click on 'my-control-plane' > Navigate to 'my-control-plane'
52-
cy.contains('my-control-plane').click();
53-
cy.wrap(null).then(() => {
54-
expect(lastNavigatedPath).to.equal('/mcp/projects/my-project/workspaces/my-workspace/mcps/my-control-plane');
55-
});
5649
});
5750

5851
it('renders only home breadcrumb when there are no path parameters', () => {
@@ -66,18 +59,17 @@ describe('PathAwareBreadcrumbs', () => {
6659
it('handles partial route parameters', () => {
6760
const fakeUseParams = (() => ({
6861
projectName: 'my-project',
69-
workspaceName: 'my-workspace',
62+
// No workspaceName
7063
// No controlPlaneName
7164
})) as typeof useParams;
7265

7366
cy.mount(<PathAwareBreadcrumbs useNavigate={fakeUseNavigate} useParams={fakeUseParams} />);
7467

7568
// Should show 3 breadcrumbs
76-
cy.get("[data-testid='breadcrumb-item']").should('have.length', 3);
69+
cy.get("[data-testid='breadcrumb-item']").should('have.length', 2);
7770

7871
// Verify data-target attributes
7972
cy.get("[data-testid='breadcrumb-item']").eq(0).should('contain', '[LOCAL] Projects');
8073
cy.get("[data-testid='breadcrumb-item']").eq(1).should('contain', 'my-project');
81-
cy.get("[data-testid='breadcrumb-item']").eq(2).should('contain', 'my-workspace');
8274
});
8375
});

src/components/Core/PathAwareBreadcrumbs/PathAwareBreadcrumbs.tsx

Lines changed: 1 addition & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ export function PathAwareBreadcrumbs({
1414
useNavigate = _useNavigate,
1515
useParams = _useParams,
1616
}: PathAwareBreadcrumbsProps) {
17-
const { projectName, workspaceName, controlPlaneName } = useParams();
17+
const { projectName, workspaceName } = useParams();
1818
const { t } = useTranslation();
1919
const frontendConfig = useFrontendConfig();
2020
const navigate = useNavigate();
@@ -42,17 +42,6 @@ export function PathAwareBreadcrumbs({
4242
projectName,
4343
}),
4444
});
45-
46-
if (controlPlaneName) {
47-
breadcrumbItems.push({
48-
label: controlPlaneName,
49-
path: generatePath(Routes.Mcp, {
50-
projectName,
51-
workspaceName,
52-
controlPlaneName,
53-
}),
54-
});
55-
}
5645
}
5746
}
5847

src/spaces/mcp/pages/McpPage.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -65,6 +65,7 @@ export default function McpPage() {
6565
titleArea={
6666
<ObjectPageTitle
6767
header={controlPlaneName}
68+
subHeader={t('Entities.ManagedControlPlane')}
6869
breadcrumbs={<BreadcrumbFeedbackHeader />}
6970
//TODO: actionBar should use Toolbar and ToolbarButton for consistent design
7071
actionsBar={

0 commit comments

Comments
 (0)