Implement review feedback

Author: andreaskienle

src/components/Members/EditMembers.tsx

@@ -25,7 +25,9 @@ export const ACCOUNT_TYPES: RadioButtonsSelectOption[] = [
 
 export type AccountType = 'User' | 'ServiceAccount';
 
-const removeProjectPrefix = (name?: string) => (name?.startsWith('project-') ? name.slice('project-'.length) : name);
+const PROJECT_PREFIX = 'project-';
+const removeProjectPrefix = (name?: string) =>
+  name?.startsWith(PROJECT_PREFIX) ? name.slice(PROJECT_PREFIX.length) : name;
 
 export const EditMembers: FC<EditMembersProps> = ({
   members,

src/components/Members/ImportMembersDialog.tsx

@@ -212,19 +212,14 @@ export const ImportMembersDialog: FC<ImportMembersDialogProps> = ({
 };
 
 function getAddMembersButtonText(selectedMembersCount: number, t: TFunction) {
-  let addButtonText = '';
   switch (selectedMembersCount) {
     case 0:
-      addButtonText = t('ImportMembersDialog.addMembersButton0');
-      break;
+      return t('ImportMembersDialog.addMembersButton0');
     case 1:
-      addButtonText = t('ImportMembersDialog.addMembersButton1');
-      break;
+      return t('ImportMembersDialog.addMembersButton1');
     default:
-      addButtonText = t('ImportMembersDialog.addMembersButtonN', { count: selectedMembersCount });
-      break;
+      return t('ImportMembersDialog.addMembersButtonN', { count: selectedMembersCount });
   }
-  return addButtonText;
 }
 
 interface SpecMembers {