Skip to content

Commit 41354fe

Browse files
committed
fixes
1 parent 06dbcae commit 41354fe

File tree

3 files changed

+26
-20
lines changed

3 files changed

+26
-20
lines changed

src/components/ControlPlanes/List/ControlPlaneListWorkspaceGridTile.tsx

Lines changed: 16 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -105,8 +105,9 @@ export function ControlPlaneListWorkspaceGridTile({
105105
style={{
106106
width: '100%',
107107
display: 'grid',
108-
gridTemplateColumns: '0.3fr 0.1fr 0.24fr auto 0.05fr',
108+
gridTemplateColumns: '0.3fr 0.3fr 0.24fr auto',
109109
gap: '1rem',
110+
justifyContent: 'space-between',
110111
alignItems: 'center',
111112
}}
112113
>
@@ -115,12 +116,6 @@ export function ControlPlaneListWorkspaceGridTile({
115116
{!isWorkspaceReady(workspace) ? '(Loading)' : ''}
116117
</Title>
117118

118-
<YamlViewButton
119-
workspaceName={workspace.metadata.namespace}
120-
resourceName={workspaceName}
121-
resourceType={'workspaces'}
122-
/>
123-
124119
<CopyButton
125120
text={workspace.status?.namespace || '-'}
126121
style={{ justifyContent: 'start' }}
@@ -131,13 +126,20 @@ export function ControlPlaneListWorkspaceGridTile({
131126
project={projectName}
132127
workspace={workspaceName}
133128
/>
134-
<Button
135-
design={ButtonDesign.Transparent}
136-
icon="delete"
137-
onClick={async () => {
138-
setDialogDeleteWsIsOpen(true);
139-
}}
140-
/>
129+
<span>
130+
<YamlViewButton
131+
workspaceName={workspace.metadata.namespace}
132+
resourceName={workspaceName}
133+
resourceType={'workspaces'}
134+
/>
135+
<Button
136+
design={ButtonDesign.Transparent}
137+
icon="delete"
138+
onClick={async () => {
139+
setDialogDeleteWsIsOpen(true);
140+
}}
141+
/>
142+
</span>
141143
</div>
142144
}
143145
noAnimation

src/components/Projects/ProjectsList.tsx

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,10 @@ export default function ProjectsList() {
3434
width: '100%',
3535
color: ThemingParameters.sapLinkColor,
3636
fontWeight: 'bold',
37+
display: 'flex',
38+
justifyContent: 'space-between',
39+
gap: '0.5rem',
40+
alignItems: 'baseline',
3741
}}
3842
>
3943
{instance.cell.value}
@@ -53,7 +57,7 @@ export default function ProjectsList() {
5357
display: 'flex',
5458
justifyContent: 'start',
5559
gap: '0.5rem',
56-
alignItems: 'center',
60+
alignItems: 'baseline',
5761
width: '100%',
5862
cursor: 'pointer',
5963
}}

src/components/Yaml/YamlViewButton.tsx

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ export const YamlViewButton: FC<ResourceProps> = ({
1717
const [isOpen, setIsOpen] = useState(false);
1818
const { t } = useTranslation();
1919
return (
20-
<>
20+
<span>
2121
<Dialog
2222
open={isOpen}
2323
stretch
@@ -40,12 +40,12 @@ export const YamlViewButton: FC<ResourceProps> = ({
4040
</Dialog>
4141
<Button
4242
icon="document"
43+
aria-label={'View resource'}
44+
title={'View resource'}
4345
onClick={() => {
4446
setIsOpen(true);
4547
}}
46-
>
47-
Yaml
48-
</Button>
49-
</>
48+
/>
49+
</span>
5050
);
5151
};

0 commit comments

Comments
 (0)