refactor

Author: lucasgoral

src/components/Yaml/YamlLoader.tsx

@@ -1,4 +1,4 @@
-import { ResourceProps } from './YamlViewButton.tsx';
+import { YamlViewButtonProps } from './YamlViewButton.tsx';
 import { FC } from 'react';
 
 import { stringify } from 'yaml';
@@ -10,7 +10,7 @@ import IllustratedError from '../Shared/IllustratedError.tsx';
 import YamlViewer from './YamlViewer.tsx';
 import useResource from '../../lib/api/useApiResource';
 
-export const YamlLoader: FC<ResourceProps> = ({
+export const YamlLoader: FC<YamlViewButtonProps> = ({
   workspaceName,
   resourceType,
   resourceName,

src/components/Yaml/YamlViewButton.tsx

@@ -3,13 +3,13 @@ import { FC, useState } from 'react';
 import { YamlLoader } from './YamlLoader.tsx';
 import { useTranslation } from 'react-i18next';
 
-export type ResourceProps = {
+export type YamlViewButtonProps = {
   workspaceName?: string;
   resourceType: 'projects' | 'workspaces' | 'managedcontrolplanes';
   resourceName: string;
 };
 
-export const YamlViewButton: FC<ResourceProps> = ({
+export const YamlViewButton: FC<YamlViewButtonProps> = ({
   workspaceName,
   resourceType,
   resourceName,
@@ -31,12 +31,17 @@ export const YamlViewButton: FC<ResourceProps> = ({
             }
           />
         }
+        onClose={() => {
+          setIsOpen(false);
+        }}
       >
-        <YamlLoader
-          workspaceName={workspaceName}
-          resourceName={resourceName}
-          resourceType={resourceType}
-        />
+        {isOpen && (
+          <YamlLoader
+            workspaceName={workspaceName}
+            resourceName={resourceName}
+            resourceType={resourceType}
+          />
+        )}
       </Dialog>
       <Button
         icon="document"

src/lib/api/types/crate/resourceObject.ts

@@ -1,11 +1,10 @@
 import { Resource } from '../resource.ts';
-import { ControlPlaneType } from './controlPlanes.ts';
 
 export const ResourceObject = (
   workspaceName: string,
   resourceType: string,
   resourceName: string,
-): Resource<ControlPlaneType> => {
+): Resource<unknown> => {
   return {
     path: `/apis/core.openmcp.cloud/v1alpha1/${workspaceName ? `namespaces/${workspaceName}/` : ''}${resourceType}/${resourceName}`,
   };