Skip to content

Commit 49ce9b9

Browse files
linter auto fixes
1 parent c59c494 commit 49ce9b9

File tree

8 files changed

+49
-34
lines changed

8 files changed

+49
-34
lines changed

src/components/ComponentsSelection/ComponentsSelection.tsx

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -138,21 +138,16 @@ export const ComponentsSelection: React.FC<ComponentsSelectionProps> = ({
138138
value={component.selectedVersion}
139139
disabled={!component.isSelected || providerDisabled}
140140
aria-label={`${component.name} version`}
141-
onChange={handleVersionChange}
142141
valueState={component.isSelected && !component.selectedVersion ? 'Negative' : 'None'}
143142
valueStateMessage={
144143
component.isSelected && !component.selectedVersion ? (
145144
<span>{t('ComponentsSelection.chooseVersion')}</span>
146145
) : undefined
147146
}
147+
onChange={handleVersionChange}
148148
>
149149
{!component.selectedVersion && (
150-
<Option
151-
key="__placeholder"
152-
data-version=""
153-
data-name={component.name}
154-
selected
155-
>
150+
<Option key="__placeholder" data-version="" data-name={component.name} selected>
156151
{t('ComponentsSelection.chooseVersion')}
157152
</Option>
158153
)}

src/components/ComponentsSelection/ComponentsSelectionContainer.tsx

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,9 @@ export const ComponentsSelectionContainer: React.FC<ComponentsSelectionProps> =
5858
const template = defaultComponents.find((dc) => dc.name === item.metadata.name);
5959
const templateVersion = template?.version;
6060
const selectedVersion = template
61-
? (templateVersion && versions.includes(templateVersion) ? templateVersion : '')
61+
? templateVersion && versions.includes(templateVersion)
62+
? templateVersion
63+
: ''
6264
: (versions[0] ?? '');
6365
return {
6466
name: item.metadata.name,

src/components/ControlPlanes/ControlPlanesListMenu.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ type ControlPlanesListMenuProps = {
1616
export const ControlPlanesListMenu: FC<ControlPlanesListMenuProps> = ({
1717
setDialogDeleteWsIsOpen,
1818
setIsCreateManagedControlPlaneWizardOpen,
19-
setInitialTemplateName,
19+
setInitialTemplateName,
2020
}) => {
2121
const popoverRef = useRef<MenuDomRef>(null);
2222
const [open, setOpen] = useState(false);

src/components/ControlPlanes/List/ControlPlaneListWorkspaceGridTile.tsx

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,9 @@ export function ControlPlaneListWorkspaceGridTile({ projectName, workspace }: Pr
7575

7676
return (workspace.spec.members ?? []).filter((member: any) => {
7777
const memberNamespace = member?.namespace ?? fallbackNamespace;
78-
const memberName = String(member?.name ?? '').trim().toLowerCase();
78+
const memberName = String(member?.name ?? '')
79+
.trim()
80+
.toLowerCase();
7981
if (!memberName) return false;
8082

8183
const dedupeKey = `${memberNamespace}::${memberName}`;

src/components/Dialogs/MetadataForm.tsx

Lines changed: 9 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,10 @@ export function MetadataForm({
7979
(e?.target && typeof e.target.value === 'string' ? e.target.value : undefined) ??
8080
(e?.detail && typeof e.detail.value === 'string' ? e.detail.value : '') ??
8181
'';
82-
setValue('name', `${resolvedNamePrefix}${middle}${resolvedNameSuffix}`, { shouldValidate: true, shouldDirty: true });
82+
setValue('name', `${resolvedNamePrefix}${middle}${resolvedNameSuffix}`, {
83+
shouldValidate: true,
84+
shouldDirty: true,
85+
});
8386
};
8487

8588
const onDisplayNameCoreInput = (e: any) => {
@@ -102,7 +105,7 @@ export function MetadataForm({
102105
{t('CreateProjectWorkspaceDialog.nameLabel')}
103106
</Label>
104107

105-
{(resolvedNamePrefix || resolvedNameSuffix) ? (
108+
{resolvedNamePrefix || resolvedNameSuffix ? (
106109
<div style={{ display: 'flex', gap: 8, alignItems: 'center' }}>
107110
{resolvedNamePrefix ? (
108111
<Input
@@ -119,10 +122,10 @@ export function MetadataForm({
119122
className={styles.input}
120123
id="name"
121124
value={nameCore}
122-
onInput={onNameCoreInput}
123125
valueState={errors.name ? 'Negative' : 'None'}
124126
valueStateMessage={<span>{errors.name?.message}</span>}
125127
required
128+
onInput={onNameCoreInput}
126129
/>
127130
{resolvedNameSuffix ? (
128131
<Input
@@ -147,7 +150,7 @@ export function MetadataForm({
147150

148151
<Label for={'displayName'}>{t('CreateProjectWorkspaceDialog.displayNameLabel')}</Label>
149152

150-
{(resolvedDisplayNamePrefix || resolvedDisplayNameSuffix) ? (
153+
{resolvedDisplayNamePrefix || resolvedDisplayNameSuffix ? (
151154
<div style={{ display: 'flex', gap: 8, alignItems: 'center' }}>
152155
{resolvedDisplayNamePrefix ? (
153156
<Input
@@ -159,12 +162,7 @@ export function MetadataForm({
159162
/>
160163
) : null}
161164
<input type="hidden" {...register('displayName')} value={currentDisplayName} readOnly />
162-
<Input
163-
className={styles.input}
164-
id="displayName"
165-
value={displayNameCore}
166-
onInput={onDisplayNameCoreInput}
167-
/>
165+
<Input className={styles.input} id="displayName" value={displayNameCore} onInput={onDisplayNameCoreInput} />
168166
{resolvedDisplayNameSuffix ? (
169167
<Input
170168
className={styles.input}
@@ -185,8 +183,8 @@ export function MetadataForm({
185183
<Select
186184
id={'chargingTargetType'}
187185
className={styles.input}
188-
onChange={handleChargingTargetTypeChange}
189186
disabled={disableChargingFields}
187+
onChange={handleChargingTargetTypeChange}
190188
>
191189
{chargingTypes.map((option) => (
192190
<Option key={option.value} data-value={option.value} selected={currentChargingTargetType === option.value}>

src/components/Wizards/CreateManagedControlPlane/CreateManagedControlPlaneWizardContainer.tsx

Lines changed: 29 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -39,10 +39,7 @@ import { MetadataForm } from '../../Dialogs/MetadataForm.tsx';
3939
import { EditMembers } from '../../Members/EditMembers.tsx';
4040
import { ComponentsSelectionContainer } from '../../ComponentsSelection/ComponentsSelectionContainer.tsx';
4141
import { IllustratedBanner } from '../../Ui/IllustratedBanner/IllustratedBanner.tsx';
42-
import {
43-
ManagedControlPlaneTemplate,
44-
noTemplateValue,
45-
} from '../../../lib/api/types/templates/mcpTemplate.ts';
42+
import { ManagedControlPlaneTemplate, noTemplateValue } from '../../../lib/api/types/templates/mcpTemplate.ts';
4643
import { buildNameWithPrefixesAndSufixes } from '../../../utils/buildNameWithPrefixesAndSufixes.ts';
4744
import { stripIdpPrefix } from '../../../utils/stripIdpPrefix.ts';
4845

@@ -254,7 +251,15 @@ export const CreateManagedControlPlaneWizardContainer: FC<CreateManagedControlPl
254251
default:
255252
break;
256253
}
257-
}, [selectedStep, handleSubmit, setSelectedStep, handleCreateManagedControlPlane, watch, resetFormAndClose, hasMissingComponentVersions]);
254+
}, [
255+
selectedStep,
256+
handleSubmit,
257+
setSelectedStep,
258+
handleCreateManagedControlPlane,
259+
watch,
260+
resetFormAndClose,
261+
hasMissingComponentVersions,
262+
]);
258263

259264
const normalizeMemberRole = useCallback((r?: string | null) => {
260265
const v = (r ?? '').toString().trim().toLowerCase();
@@ -289,11 +294,13 @@ export const CreateManagedControlPlaneWizardContainer: FC<CreateManagedControlPl
289294
case 'componentSelection':
290295
return selectedStep === 'metadata' || selectedStep === 'members' || !isValid;
291296
case 'summarize':
292-
return selectedStep === 'metadata' ||
297+
return (
298+
selectedStep === 'metadata' ||
293299
selectedStep === 'members' ||
294300
selectedStep === 'componentSelection' ||
295301
!isValid ||
296-
hasMissingComponentVersions;
302+
hasMissingComponentVersions
303+
);
297304
case 'success':
298305
return selectedStep !== 'success';
299306
default:
@@ -357,12 +364,23 @@ export const CreateManagedControlPlaneWizardContainer: FC<CreateManagedControlPl
357364

358365
const normalizedMembers = Array.from(byName.values()).map((m) => ({
359366
...m,
360-
roles: (m.roles ?? []).length ? m.roles.map((r) => normalizeMemberRole(r as unknown as string)) : [MemberRoles.view],
367+
roles: (m.roles ?? []).length
368+
? m.roles.map((r) => normalizeMemberRole(r as unknown as string))
369+
: [MemberRoles.view],
361370
}));
362371

363372
setValue('members', normalizedMembers, { shouldValidate: true });
364373
appliedTemplateMembersRef.current = true;
365-
}, [selectedStep, selectedTemplate, watch, setValue, user?.email, normalizeMemberRole, normalizeMemberKind, idpPrefix]);
374+
}, [
375+
selectedStep,
376+
selectedTemplate,
377+
watch,
378+
setValue,
379+
user?.email,
380+
normalizeMemberRole,
381+
normalizeMemberKind,
382+
idpPrefix,
383+
]);
366384

367385
useEffect(() => {
368386
if (selectedStep !== 'componentSelection') return;
@@ -378,7 +396,7 @@ export const CreateManagedControlPlaneWizardContainer: FC<CreateManagedControlPl
378396
const current = (watch('componentsList') ?? []) as ComponentsListItem[];
379397
if (current.length > 0) {
380398
appliedTemplateComponentsRef.current = true;
381-
return;
399+
return;
382400
}
383401

384402
const mapped = defaults
@@ -511,4 +529,4 @@ export const CreateManagedControlPlaneWizardContainer: FC<CreateManagedControlPl
511529
</Wizard>
512530
</Dialog>
513531
);
514-
};
532+
};

src/lib/api/types/templates/mcpTemplate.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -92,4 +92,4 @@ export function toTemplateDropdownOptions(
9292
label: t.metadata.name,
9393
})),
9494
];
95-
}
95+
}

src/utils/buildNameWithPrefixesAndSufixes.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,4 +22,4 @@ export function buildNameWithPrefixesAndSufixes(
2222
const finalDisplayName = applyAffixes(displayName, affixes?.displayNamePrefix, affixes?.displayNameSuffix);
2323

2424
return { finalName, finalDisplayName };
25-
}
25+
}

0 commit comments

Comments
 (0)