Skip to content

Commit 9ed59ec

Browse files
more descriptive name + simplify handler
1 parent 643fcfc commit 9ed59ec

File tree

1 file changed

+10
-13
lines changed

1 file changed

+10
-13
lines changed

src/components/Dialogs/ManagedResourceDeleteDialog.tsx

Lines changed: 10 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -32,13 +32,13 @@ type Props = {
3232

3333
export const ManagedResourceDeleteDialog: FC<Props> = ({ kindMapping, open, onClose, item, onDeleteStart }) => {
3434
const { t } = useTranslation();
35-
const [force, setForce] = useState(false);
35+
const [forceDeletion, setForceDeletion] = useState(false);
3636
const [advancedCollapsed, setAdvancedCollapsed] = useState(true);
3737
const [confirmationText, setConfirmationText] = useState('');
3838

3939
useEffect(() => {
4040
if (!open) {
41-
setForce(false);
41+
setForceDeletion(false);
4242
setAdvancedCollapsed(true);
4343
setConfirmationText('');
4444
}
@@ -70,11 +70,8 @@ export const ManagedResourceDeleteDialog: FC<Props> = ({ kindMapping, open, onCl
7070
const isMutating = isMutatingDelete || isMutatingPatch;
7171

7272
const handleForceDeletionChange = () => {
73-
setForce((prev) => {
74-
const next = !prev;
75-
if (next) setAdvancedCollapsed(false);
76-
return next;
77-
});
73+
setForceDeletion(!forceDeletion);
74+
if (!forceDeletion) setAdvancedCollapsed(false);
7875
};
7976

8077
const handleDelete = async () => {
@@ -83,10 +80,10 @@ export const ManagedResourceDeleteDialog: FC<Props> = ({ kindMapping, open, onCl
8380
onDeleteStart(item);
8481

8582
try {
86-
await deleteTrigger({ data: { force } });
83+
await deleteTrigger({ data: { force: forceDeletion } });
8784

88-
if (force) {
89-
await patchTrigger({ data: { force } });
85+
if (forceDeletion) {
86+
await patchTrigger({ data: { force: forceDeletion } });
9087
}
9188
} catch (_) {
9289
// Ignore errors - item can be deleted before patch and it's ok.
@@ -114,11 +111,11 @@ export const ManagedResourceDeleteDialog: FC<Props> = ({ kindMapping, open, onCl
114111
<Panel
115112
headerText={t('ManagedResources.advancedOptions')}
116113
collapsed={advancedCollapsed}
117-
fixed={force}
118-
onToggle={() => !force && setAdvancedCollapsed((v) => !v)}
114+
fixed={forceDeletion}
115+
onToggle={() => !forceDeletion && setAdvancedCollapsed((v) => !v)}
119116
>
120117
<FlexBox direction="Column" className={styles.advancedOptionsContent}>
121-
<CheckBox checked={force} text={t('ManagedResources.forceDeletion')} onChange={handleForceDeletionChange} />
118+
<CheckBox checked={forceDeletion} text={t('ManagedResources.forceDeletion')} onChange={handleForceDeletionChange} />
122119
<MessageStrip design="Critical" hideCloseButton>
123120
<span>{t('ManagedResources.forceWarningLine')}</span>
124121
</MessageStrip>

0 commit comments

Comments
 (0)