Skip to content

Commit a19d434

Browse files
style: improve spaces around MCP Detail spacing (#10)
Co-authored-by: Andreas Kienle <[email protected]>
1 parent e326249 commit a19d434

File tree

7 files changed

+35
-14
lines changed

7 files changed

+35
-14
lines changed

public/locales/en.json

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
"signInButton": "Sign in"
77
},
88
"ComponentList": {
9-
"tableComponentHeader": "Component",
9+
"tableComponentHeader": "Name",
1010
"tableVersionHeader": "Version"
1111
},
1212
"FluxList": {
@@ -20,7 +20,7 @@
2020
"tableCreatedHeader": "Created"
2121
},
2222
"ManagedResources": {
23-
"headerManagedResources": "Resources",
23+
"header": "Managed Resources",
2424
"tableHeaderKind": "Kind",
2525
"tableHeaderName": "Name",
2626
"tableHeaderCreated": "Created",
@@ -126,7 +126,10 @@
126126
"title": "Projects"
127127
},
128128
"ControlPlaneView": {
129-
"accessError": "Managed Control Plane does not have access information yet"
129+
"accessError": "Managed Control Plane does not have access information yet",
130+
"componentsTitle": "Components",
131+
"crossplaneTitle": "Crossplane",
132+
"gitOpsTitle": "GitOps"
130133
},
131134
"ToastContext": {
132135
"errorMessage": "useToast must be used within a ToastProvider"
@@ -147,7 +150,7 @@
147150
"tableHeaderHealthy": "Healthy"
148151
},
149152
"ProvidersConfig": {
150-
"headerProvidersConfig": "Providers Config"
153+
"header": "Provider Configs"
151154
},
152155
"validationErrors": {
153156
"required": "This field is required!",

src/components/ControlPlane/ComponentList.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -49,6 +49,7 @@ export default function ComponentList({ mcp }: { mcp: ControlPlaneType }) {
4949
columns={componentTableColumns}
5050
minRows={0}
5151
data={data}
52+
style={{marginLeft: "12px", marginRight: "12px"}}
5253
/>
5354
</div>
5455
);

src/components/ControlPlane/ManagedResources.tsx

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -106,12 +106,13 @@ export function ManagedResources() {
106106

107107
return (
108108
<>
109-
<Title level="H4">{t('ManagedResources.headerManagedResources')}</Title>
109+
<Title level="H4">{t('ManagedResources.header')}</Title>
110110

111111
{error && <IllustratedError error={error} />}
112112

113113
{!error && (
114114
<AnalyticalTable
115+
style={{ margin: '12px' }}
115116
columns={columns}
116117
data={rows}
117118
minRows={1}

src/components/ControlPlane/ProvidersConfig.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ export function ProvidersConfig() {
1212

1313
return (
1414
<>
15-
<Title level='H4'>{t('ProvidersConfig.headerProvidersConfig')}</Title>
15+
<Title level='H4'>{t('ProvidersConfig.header')}</Title>
1616
<AnalyticalTable
1717
columns={columns}
1818
data={[]}

src/components/Shared/ConfiguredAnalyticsTable.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@ export default function ConfiguredAnalyticsTable(props: Props) {
2323
scaleWidthMode={AnalyticalTableScaleWidthMode.Smart}
2424
loading={props.isLoading}
2525
filterable
26+
style={{margin: "12px"}}
2627
/>
2728
);
2829
}

src/index.css

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -86,6 +86,10 @@
8686
margin-bottom: -30px;
8787
}
8888

89+
.cp-panel {
90+
margin: 12px;
91+
}
92+
8993
.cp-panel-crossplane {
9094
background-color: #FFC933;
9195
}

src/views/ControlPlanes/ControlPlaneView.tsx

Lines changed: 19 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -88,13 +88,18 @@ export default function ControlPlaneView() {
8888
<ObjectPageSection
8989
className="cp-page-section-components"
9090
id="components"
91-
titleText="Components"
91+
titleText={t('ControlPlaneView.componentsTitle')}
9292
hideTitleText
9393
>
9494
<Panel
95+
className="cp-panel"
9596
headerLevel="H2"
9697
headerText="Panel"
97-
header={<Title level="H3">Components</Title>}
98+
header={
99+
<Title level="H3">
100+
{t('ControlPlaneView.componentsTitle')}
101+
</Title>
102+
}
98103
noAnimation
99104
>
100105
<ComponentList mcp={mcp} />
@@ -103,14 +108,18 @@ export default function ControlPlaneView() {
103108
<ObjectPageSection
104109
className="cp-page-section-crossplane"
105110
id="crossplane"
106-
titleText="Crossplane"
111+
titleText={t('ControlPlaneView.crossplaneTitle')}
107112
hideTitleText
108113
>
109114
<Panel
110-
className="cp-panel-crossplane"
115+
className="cp-panel cp-panel-crossplane"
111116
headerLevel="H3"
112117
headerText="Panel"
113-
header={<Title level="H3">Crossplane</Title>}
118+
header={
119+
<Title level="H3">
120+
{t('ControlPlaneView.crossplaneTitle')}
121+
</Title>
122+
}
114123
noAnimation
115124
>
116125
<ProvidersList />
@@ -119,14 +128,16 @@ export default function ControlPlaneView() {
119128
<ObjectPageSection
120129
className="cp-page-section-gitops"
121130
id="gitops"
122-
titleText="GitOps"
131+
titleText={t('ControlPlaneView.gitOpsTitle')}
123132
hideTitleText
124133
>
125134
<Panel
126-
className="cp-panel-gitops"
135+
className="cp-panel cp-panel-gitops"
127136
headerLevel="H3"
128137
headerText="Panel"
129-
header={<Title level="H3">GitOps</Title>}
138+
header={
139+
<Title level="H3">{t('ControlPlaneView.gitOpsTitle')}</Title>
140+
}
130141
noAnimation
131142
>
132143
<FluxList />

0 commit comments

Comments
 (0)