Skip to content

Commit ab72d7e

Browse files
committed
reactor
1 parent 40ade87 commit ab72d7e

File tree

3 files changed

+23
-5
lines changed

3 files changed

+23
-5
lines changed

src/components/Wizards/CreateManagedControlPlane/SummarizeStep.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ import {
88
} from '../../../lib/api/types/crate/createManagedControlPlane.ts';
99

1010
import { idpPrefix } from '../../../utils/idpPrefix.ts';
11+
import { parseResourceApiInfo } from '../../../utils/parseResourceApiInfo.ts';
1112
import { UseFormWatch } from 'react-hook-form';
1213
import { CreateDialogProps } from '../../Dialogs/CreateWorkspaceDialogContainer.tsx';
1314

@@ -45,8 +46,7 @@ export const SummarizeStep: React.FC<SummarizeStepProps> = ({
4546
idpPrefix,
4647
);
4748
const yamlString = stringify(resource);
48-
const apiGroupName = resource?.apiVersion?.split('/')[0] ?? 'core.openmcp.cloud';
49-
const apiVersion = resource?.apiVersion?.split('/')[1] ?? 'v1alpha1';
49+
const { apiGroupName, apiVersion } = parseResourceApiInfo(resource);
5050
return (
5151
<div className={styles.wrapper}>
5252
<Title>{t('common.summarize')}</Title>

src/components/Yaml/YamlSidePanel.tsx

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@ import { useMemo, useState, useCallback, JSX } from 'react';
1717
import { stringify } from 'yaml';
1818
import { convertToResourceConfig } from '../../utils/convertToResourceConfig.ts';
1919
import { removeManagedFieldsAndFilterData, Resource } from '../../utils/removeManagedFieldsAndFilterData.ts';
20+
import { parseResourceApiInfo } from '../../utils/parseResourceApiInfo.ts';
2021
import { useCopyToClipboard } from '../../hooks/useCopyToClipboard.ts';
2122
import styles from './YamlSidePanel.module.css';
2223
import { IllustratedBanner } from '../Ui/IllustratedBanner/IllustratedBanner.tsx';
@@ -81,9 +82,7 @@ export function YamlSidePanel({ resource, filename, onApply, isEdit, toolbarCont
8182

8283
const handleGoBack = () => setMode('edit');
8384

84-
const apiGroupName = resource?.apiVersion?.split('/')[0] ?? 'core.openmcp.cloud';
85-
const apiVersion = resource?.apiVersion?.split('/')[1] ?? 'v1alpha1';
86-
const kind = resource?.kind;
85+
const { apiGroupName, apiVersion, kind } = parseResourceApiInfo(resource);
8786

8887
return (
8988
<Panel

src/utils/parseResourceApiInfo.ts

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,19 @@
1+
import { Resource } from './removeManagedFieldsAndFilterData.ts';
2+
3+
export interface ResourceApiInfo {
4+
apiGroupName: string;
5+
apiVersion: string;
6+
kind: string;
7+
}
8+
9+
export function parseResourceApiInfo(resource: Resource): ResourceApiInfo {
10+
const apiGroupName = resource?.apiVersion?.split('/')[0] ?? 'core.openmcp.cloud';
11+
const apiVersion = resource?.apiVersion?.split('/')[1] ?? 'v1alpha1';
12+
const kind = resource?.kind ?? '';
13+
14+
return {
15+
apiGroupName,
16+
apiVersion,
17+
kind,
18+
};
19+
}

0 commit comments

Comments
 (0)