PR requested changes

Author: Hubert-Szczepanski-SAP

…/CreateProjectWorkspaceDialog.module.css …mponents/Dialogs/MetadataForm.module.csssrc/components/Dialogs/CreateProjectWorkspaceDialog.module.css renamed to src/components/Dialogs/MetadataForm.module.css src/components/Dialogs/CreateProjectWorkspaceDialog.module.css renamed to src/components/Dialogs/MetadataForm.module.css

@@ -1,3 +1,9 @@
+.affixRow {
+  display: flex;
+  gap: 8px;
+  align-items: center;
+}
+
 .input {
   width: 100%;
   margin-bottom: 2rem;

src/components/Dialogs/MetadataForm.tsx

@@ -12,7 +12,8 @@ import {
   Ui5CustomEvent,
   InputDomRef,
 } from '@ui5/webcomponents-react';
-import styles from './CreateProjectWorkspaceDialog.module.css';
+
+import styles from './MetadataForm.module.css';
 import React from 'react';
 
 export interface MetadataFormProps {
@@ -74,10 +75,10 @@ export function MetadataForm({
   const resolvedDisplayNameSuffix = (propDisplayNameSuffix || '').trim();
 
   const computeCore = (full: string, prefix: string, suffix: string) => {
-    let v = full ?? '';
-    if (prefix && v.startsWith(prefix)) v = v.slice(prefix.length);
-    if (suffix && v.endsWith(suffix)) v = v.slice(0, v.length - suffix.length);
-    return v;
+    let name = full ?? '';
+    if (prefix && name.startsWith(prefix)) name = name.slice(prefix.length);
+    if (suffix && name.endsWith(suffix)) name = name.slice(0, name.length - suffix.length);
+    return name;
   };
 
   const nameCore = computeCore(currentName, resolvedNamePrefix, resolvedNameSuffix);
@@ -109,7 +110,7 @@ export function MetadataForm({
         </Label>
 
         {resolvedNamePrefix || resolvedNameSuffix ? (
-          <div style={{ display: 'flex', gap: 8, alignItems: 'center' }}>
+          <div className={styles.affixRow}>
             {resolvedNamePrefix ? (
               <Input
                 className={styles.input}
@@ -154,7 +155,7 @@ export function MetadataForm({
         <Label for={'displayName'}>{t('CreateProjectWorkspaceDialog.displayNameLabel')}</Label>
 
         {resolvedDisplayNamePrefix || resolvedDisplayNameSuffix ? (
-          <div style={{ display: 'flex', gap: 8, alignItems: 'center' }}>
+          <div className={styles.affixRow}>
             {resolvedDisplayNamePrefix ? (
               <Input
                 className={styles.input}

src/components/Wizards/CreateManagedControlPlane/CreateManagedControlPlaneWizardContainer.tsx

@@ -186,7 +186,7 @@ export const CreateManagedControlPlaneWizardContainer: FC<CreateManagedControlPl
 
   const hasMissingComponentVersions = useMemo(() => {
     const list = (componentsList ?? []) as ComponentsListItem[];
-    return list.some((c) => c?.isSelected && !c?.selectedVersion);
+    return list.some(({ isSelected, selectedVersion }) => isSelected && !selectedVersion);
   }, [componentsList]);
 
   const handleCreateManagedControlPlane = useCallback(
@@ -261,10 +261,10 @@ export const CreateManagedControlPlaneWizardContainer: FC<CreateManagedControlPl
     hasMissingComponentVersions,
   ]);
 
-  const normalizeMemberRole = useCallback((r?: string | null) => {
-    const v = (r ?? '').toString().trim().toLowerCase();
-    if (v === 'admin' || v === 'administrator') return MemberRoles.admin;
-    if (v === 'viewer' || v === 'view' || v === 'read' || v === 'readonly' || v === 'read-only') {
+  const normalizeMemberRole = useCallback((roleInput?: string | null) => {
+    const normalizedRole = (roleInput ?? '').toString().trim().toLowerCase();
+    if (normalizedRole === 'admin' || normalizedRole === 'administrator') return MemberRoles.admin;
+    if (normalizedRole === 'viewer' || normalizedRole === 'view' || normalizedRole === 'readonly') {
       return MemberRoles.view;
     }
     return MemberRoles.view;
@@ -317,9 +317,9 @@ export const CreateManagedControlPlaneWizardContainer: FC<CreateManagedControlPl
     }
   }, [selectedStep]);
 
-  const normalizeMemberKind = useCallback((k?: string | null) => {
-    const v = (k ?? '').toString().trim().toLowerCase();
-    return v === 'serviceaccount' ? 'ServiceAccount' : 'User';
+  const normalizeMemberKind = useCallback((kindInput?: string | null) => {
+    const normalizedKind = (kindInput ?? '').toString().trim().toLowerCase();
+    return normalizedKind === 'serviceaccount' ? 'ServiceAccount' : 'User';
   }, []);
 
   const appliedTemplateMembersRef = useRef(false);