PR changes

Author: Hubert-Szczepanski-SAP

src/components/ControlPlane/ManagedResources.cy.tsx

@@ -212,7 +212,6 @@ describe('ManagedResources - Edit Resource', () => {
   const fakeUseHandleResourcePatch: typeof useHandleResourcePatch = () => {
     patchHandlerCreated = true;
     return async (item: any) => {
-      cy.log('Patch handler called!');
       patchCalled = true;
       patchedItem = item;
       return true;
@@ -271,11 +270,15 @@ describe('ManagedResources - Edit Resource', () => {
   ];
 
   before(() => {
-    // Ignore Monaco Editor disposal errors
     cy.on('uncaught:exception', (err) => {
+      // Ignore Monaco Editor errors
       if (err.message.includes('TextModel got disposed')) {
         return false;
       }
+      // Ignore DiffEditorWidget errors
+      if (err.message.includes('DiffEditorWidget')) {
+        return false;
+      }
       return true;
     });
   });
@@ -314,31 +317,23 @@ describe('ManagedResources - Edit Resource', () => {
 
     // Verify YAML panel opened
     cy.contains('YAML').should('be.visible');
-    cy.contains('test-subaccount').should('be.visible');
 
     // Verify patch not called yet
-    cy.then(() => {
-      cy.log(`patchCalled before Apply: ${patchCalled}`);
-      cy.wrap(patchCalled).should('equal', false);
-    });
+    cy.then(() => cy.wrap(patchCalled).should('equal', false));
 
     // Click Apply button
-    cy.contains('Apply changes').click();
+    cy.get('[data-testid="yaml-apply-button"]').should('be.visible').click();
 
-    // Wait for dialog and confirm
-    cy.get('ui5-dialog', { timeout: 10000 }).should('exist');
-    cy.contains('Yes').click({ force: true });
+    // Confirm in dialog
+    cy.get('[data-testid="yaml-confirm-button"]', { timeout: 10000 }).should('be.visible').click({ force: true });
 
-    // Give it time to process
-    cy.wait(2000);
+    // Wait for success message
+    cy.contains('Update submitted', { timeout: 10000 }).should('be.visible');
 
     // Verify patch was called
     cy.then(() => {
-      cy.log(`patchCalled after Apply: ${patchCalled}`);
-      cy.log(`patchedItem: ${JSON.stringify(patchedItem)}`);
+      expect(patchCalled).to.equal(true);
+      expect(patchedItem).to.not.be.null;
     });
-
-    cy.then(() => cy.wrap(patchCalled).should('equal', true));
-    cy.then(() => cy.wrap(patchedItem).should('not.be.null'));
   });
-});
+});

src/components/Yaml/YamlSidePanel.tsx

@@ -142,10 +142,10 @@ export function YamlSidePanel({ resource, filename, onApply, isEdit }: YamlSideP
                 <p className={styles.diffConfirmMessage}>{t('yaml.diffConfirmMessage')}</p>
               </div>
               <FlexBox className={styles.reviewButtons}>
-                <Button design="Transparent" data-testid="yaml-cancel-confirmation-button" onClick={handleGoBack}>
+                <Button design="Transparent" onClick={handleGoBack} data-testid="yaml-cancel-confirmation-button">
                   {t('yaml.diffNo')}
                 </Button>
-                <Button design="Emphasized" data-testid="yaml-confirm-button" onClick={handleConfirmPatch}>
+                <Button design="Emphasized" onClick={handleConfirmPatch} data-testid="yaml-confirm-button">
                   {t('yaml.diffYes', 'Yes')}
                 </Button>
               </FlexBox>

src/components/YamlEditor/YamlEditor.tsx

@@ -85,7 +85,7 @@ export const YamlEditor = (props: YamlEditorProps) => {
         <Toolbar design="Solid">
           <Title>{t('yaml.editorTitle')}</Title>
           <ToolbarSpacer />
-          <Button design="Emphasized" onClick={handleApply}>
+          <Button design="Emphasized" onClick={handleApply} data-testid="yaml-apply-button">
             {t('buttons.applyChanges', 'Apply changes')}
           </Button>
         </Toolbar>