removed finalizers

Author: lucasgoral

src/utils/convertToResourceConfig.spec.ts

@@ -36,7 +36,7 @@ describe('convertToResourceConfig', () => {
     expect(output.metadata.name).toEqual('example');
     expect(output.metadata.namespace).toEqual('demo-ns');
     expect(output.metadata.labels).toEqual({ app: 'demo' });
-    expect(output.metadata.finalizers).toEqual(['protect']);
+    expect(output.metadata).not.toHaveProperty('finalizers');
     expect(output.spec).toEqual({ foo: 'bar' });
 
     // Remove unwanted
@@ -50,7 +50,6 @@ describe('convertToResourceConfig', () => {
     // Custom annotation kept
     expect(output.metadata.annotations?.['custom/anno']).toEqual('keep-me');
     // Status removed
-    // @ts-expect-error status intentionally absent
     expect(output.status).toBeUndefined();
   });
 
@@ -68,13 +67,11 @@ describe('convertToResourceConfig', () => {
     out.items?.forEach((item) => {
       expect(item.metadata.annotations?.[LAST_APPLIED_CONFIGURATION_ANNOTATION]).toBeUndefined();
       expect(item.metadata.labels).toEqual({ app: 'demo' });
-      // @ts-expect-error status intentionally absent
       expect(item.status).toBeUndefined();
     });
   });
 
   it('returns empty object shape when input is null/undefined', () => {
-    // @ts-expect-error test invalid input
     const out = convertToResourceConfig(null);
     expect(out).toBeInstanceOf(Object);
   });

src/utils/convertToResourceConfig.ts

@@ -5,9 +5,9 @@ import type { Resource } from './removeManagedFieldsAndFilterData';
  * Convert an in-cluster Resource (which may contain status and server-populated metadata)
  * into a lean manifest suitable for applying with kubectl.
  * Rules:
- *  - Keep: apiVersion, kind, metadata.name, metadata.namespace, metadata.labels, metadata.annotations (except LAST_APPLIED_CONFIGURATION_ANNOTATION), metadata.finalizers, spec.
+ *  - Keep: apiVersion, kind, metadata.name, metadata.namespace, metadata.labels, metadata.annotations (except LAST_APPLIED_CONFIGURATION_ANNOTATION), spec.
  *  - Remove: metadata.managedFields, metadata.resourceVersion, metadata.uid, metadata.generation, metadata.creationTimestamp,
- *            LAST_APPLIED_CONFIGURATION_ANNOTATION annotation, status.
+ *            LAST_APPLIED_CONFIGURATION_ANNOTATION annotation, status, metadata.finalizers.
  *  - If a List (has items), convert each item recursively.
  */
 export const convertToResourceConfig = (resourceObject: Resource | undefined | null): Resource => {
@@ -40,9 +40,10 @@ export const convertToResourceConfig = (resourceObject: Resource | undefined | n
       }, {});
     }
   }
-  if (resourceObject.metadata?.finalizers && resourceObject.metadata.finalizers.length > 0) {
-    base.metadata.finalizers = [...resourceObject.metadata.finalizers];
-  }
+  // Finalizers are not included in a lean manifest
+  // if (resourceObject.metadata?.finalizers && resourceObject.metadata.finalizers.length > 0) {
+  //   base.metadata.finalizers = [...resourceObject.metadata.finalizers];
+  // }
   if (resourceObject.spec !== undefined) {
     base.spec = resourceObject.spec;
   }