Skip to content

Commit ef8b21a

Browse files
committed
Fix managed resources when response contains an error
1 parent e326249 commit ef8b21a

File tree

1 file changed

+22
-23
lines changed

1 file changed

+22
-23
lines changed

src/components/ControlPlane/ManagedResources.tsx

Lines changed: 22 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -83,26 +83,28 @@ export function ManagedResources() {
8383
];
8484

8585
const rows: ResourceRow[] =
86-
managedResources?.flatMap((managedResource) =>
87-
managedResource.items?.map((item) => {
88-
const conditionSynced = item.status.conditions?.find(
89-
(condition) => condition.type === 'Synced',
90-
);
91-
const conditionReady = item.status.conditions?.find(
92-
(condition) => condition.type === 'Ready',
93-
);
86+
managedResources
87+
?.filter((managedResource) => managedResource.items)
88+
.flatMap((managedResource) =>
89+
managedResource.items?.map((item) => {
90+
const conditionSynced = item.status.conditions?.find(
91+
(condition) => condition.type === 'Synced',
92+
);
93+
const conditionReady = item.status.conditions?.find(
94+
(condition) => condition.type === 'Ready',
95+
);
9496

95-
return {
96-
kind: item.kind,
97-
name: item.metadata.name,
98-
created: timeAgo.format(new Date(item.metadata.creationTimestamp)),
99-
synced: conditionSynced?.status === 'True',
100-
syncedTransitionTime: conditionSynced?.lastTransitionTime ?? '',
101-
ready: conditionReady?.status === 'True',
102-
readyTransitionTime: conditionReady?.lastTransitionTime ?? '',
103-
};
104-
}),
105-
) ?? [];
97+
return {
98+
kind: item.kind,
99+
name: item.metadata.name,
100+
created: timeAgo.format(new Date(item.metadata.creationTimestamp)),
101+
synced: conditionSynced?.status === 'True',
102+
syncedTransitionTime: conditionSynced?.lastTransitionTime ?? '',
103+
ready: conditionReady?.status === 'True',
104+
readyTransitionTime: conditionReady?.lastTransitionTime ?? '',
105+
};
106+
}),
107+
) ?? [];
106108

107109
return (
108110
<>
@@ -138,10 +140,7 @@ export function ManagedResources() {
138140
);
139141
}
140142

141-
function ResourceStatusCell({
142-
value,
143-
transitionTime,
144-
}: StatusCellProps) {
143+
function ResourceStatusCell({ value, transitionTime }: StatusCellProps) {
145144
return (
146145
<Icon
147146
design={value ? 'Positive' : 'Negative'}

0 commit comments

Comments
 (0)