Add tsc to the pipeline #338
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds TypeScript compilation checking to the CI pipeline to ensure type safety before other test steps run.
Key Changes
- Added a TypeScript type check step using
tsc --noEmitto the build workflow
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| run: npm run lint | ||
|
|
||
| - name: TypeScript Type Check | ||
| run: npx tsc --noEmit |
There was a problem hiding this comment.
Using npx tsc may not respect the project's specific TypeScript version defined in package.json. Consider using npm run with a package.json script (e.g., npm run type-check) to ensure consistency with the local TypeScript version.
Suggested change
| run: npx tsc --noEmit | |
| run: npm run type-check |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer: