fix(lint): fixed linter issues & optimized test structure

Author: n3rdc4ptn

internal/usage/db_test.go

@@ -13,7 +13,8 @@ import (
 
 var _ = Describe("Database Module", func() {
 	BeforeEach(func() {
-		os.Setenv("USAGE_DB_PATH", "")
+		err := os.Setenv("USAGE_DB_PATH", "")
+		Ω(err).Should(Succeed())
 	})
 	Context("When getting the Database", func() {
 		It("should return a database entity", func() {
@@ -43,7 +44,7 @@ var _ = Describe("Database Module", func() {
 				err = rows.Scan(&tableName)
 				Ω(err).Should(Succeed())
 
-				Ω(len(expectedTables)).ShouldNot(Equal(0))
+				Ω(len(expectedTables)).ShouldNot(BeEmpty())
 				expectedTables = slices.DeleteFunc(expectedTables, func(expected string) bool {
 					return expected == tableName
 				})

internal/usage/helper_test.go

@@ -1,7 +1,6 @@
 package usage
 
 import (
-	"fmt"
 	"time"
 
 	. "github.com/onsi/ginkgo/v2"
@@ -22,35 +21,16 @@ var _ = Describe("Helper Module", func() {
 
 			result := calculateUsage(start, end)
 
-			Ω(len(result)).Should(Equal(8))
+			Ω(result).Should(HaveLen(8))
 
-			Ω(result[0].date.Equal(endDate)).Should(Equal(true), "first date must equal end date")
+			Ω(result[0].date.Equal(endDate)).Should(BeTrue(), "first date must equal end date")
 			Ω(result[0].duration).Should(Equal(firstDayDuration), "first day must have the right duration")
 			for _, usage := range result[1:] {
 				Ω(usage.duration).Should(Equal(24 * time.Hour))
 			}
-		})
-
-		It("reversed: should calculate the usage for a 1 week span", func() {
-			firstDayDuration := 23*time.Hour + 59*time.Minute + 59*time.Second
-
-			end := time.Now().UTC()
-			endDate := end.Truncate(24 * time.Hour)
-			end = endDate.Add(firstDayDuration)
-
-			start := end.Add(-7 * 24 * time.Hour)
-			start = start.Truncate(24 * time.Hour)
-
-			result := calculateUsage(end, start)
-
-			Ω(len(result)).Should(Equal(8))
 
-			Ω(result[0].date.Equal(endDate)).Should(Equal(true), "first date must equal end date")
-			Ω(result[0].duration).Should(Equal(firstDayDuration), "first day must have the right duration")
-			for _, usage := range result[1:] {
-				fmt.Println(usage.date, usage.duration)
-				Ω(usage.duration).Should(Equal(24 * time.Hour))
-			}
+			reversed := calculateUsage(end, start)
+			Ω(result).Should(Equal(reversed), "the calculation must be reversed the same")
 		})
 	})
 })