Skip to content

Commit e5f2ecb

Browse files
committed
optimize MessaageBuilder API
1 parent e0b1168 commit e5f2ecb

File tree

3 files changed

+17
-96
lines changed

3 files changed

+17
-96
lines changed

openmessaging-api-samples/src/main/java/io/openmessaging/samples/consumer/GenericPullConsumerApp.java

Lines changed: 0 additions & 69 deletions
This file was deleted.

openmessaging-api/src/main/java/io/openmessaging/api/MessageBuilder.java

Lines changed: 17 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -28,55 +28,55 @@ public interface MessageBuilder<T> {
2828
/**
2929
* Used for set topic.
3030
* @param topic message topic
31-
* @return
31+
* @return {@link MessageBuilder}
3232
*/
33-
MessageBuilder withTopic(String topic);
33+
MessageBuilder<T> withTopic(String topic);
3434

3535
/**
3636
* Used for message key.
3737
*
3838
* @param key message key
39-
* @return
39+
* @return {@link MessageBuilder}
4040
*/
41-
MessageBuilder withKey(String key);
41+
MessageBuilder<T> withKey(String key);
4242

4343
/**
4444
* Used for set message tags.
4545
*
46-
* @param tags
47-
* @return
46+
* @param tags message tags
47+
* @return {@link MessageBuilder}
4848
*/
49-
MessageBuilder withTags(String tags);
49+
MessageBuilder<T> withTags(String tags);
5050

5151
/**
5252
* Used for set message sharding key.
5353
*
54-
* @param shardingKey
55-
* @return
54+
* @param shardingKey message shardingKey
55+
* @return {@link MessageBuilder}
5656
*/
57-
MessageBuilder withShardingKey(String shardingKey);
57+
MessageBuilder<T> withShardingKey(String shardingKey);
5858

5959
/**
6060
* Used for set user properties.
6161
*
62-
* @param key
63-
* @param value
64-
* @return
62+
* @param key the key of user property
63+
* @param value the value of user property
64+
* @return {@link MessageBuilder}
6565
*/
66-
MessageBuilder withProperty(final String key, final String value);
66+
MessageBuilder<T> withProperty(final String key, final String value);
6767

6868
/**
6969
* Used for set message body.
7070
*
7171
* @param t object need to be serialized.
72-
* @return
72+
* @return {@link MessageBuilder}
7373
*/
74-
MessageBuilder withValue(T t);
74+
MessageBuilder<T> withValue(T t);
7575

7676
/**
7777
* Get the topic which this {@code MessageBuilder} belongs to.
7878
*
79-
* @return
79+
* @return message topic
8080
*/
8181
String getTopic();
8282

openmessaging-api/src/main/java/io/openmessaging/api/PullConsumer.java

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -69,16 +69,6 @@ interface TopicPartitionChangeListener {
6969
*/
7070
List<Message> poll(long timeout);
7171

72-
/**
73-
* Fetch Objects for the topics or partitions specified using assign API. It is an error to not have subscribed to
74-
* any topics or partitions before polling for data.
75-
*
76-
* @param timeout in millisecond
77-
* @param tClass class of message body
78-
* @return
79-
*/
80-
<T> List<GenericMessage<T>> pollGenericMessages(long timeout, Class<T> tClass);
81-
8272
/**
8373
* Overrides the fetch offsets that the consumer will use on the next {@link #poll(long)} }. If this API is invoked
8474
* for the same message queue more than once, the latest offset will be used on the next poll(). Note that you may

0 commit comments

Comments
 (0)