fix: add validations on grant input (#3433)

Author: GAlexIHU

openmeter/credit/errors.go

@@ -0,0 +1,19 @@
+package credit
+
+import "github.com/openmeterio/openmeter/pkg/models"
+
+const ErrCodeGrantAmountMustBePositive models.ErrorCode = "grant_amount_must_be_positive"
+
+var ErrGrantAmountMustBePositive = models.NewValidationIssue(
+	ErrCodeGrantAmountMustBePositive,
+	"amount must be positive",
+	models.WithFieldString("amount"),
+)
+
+const ErrCodeEffectiveAtMustBeSet models.ErrorCode = "grant_effective_at_must_be_set"
+
+var ErrGrantEffectiveAtMustBeSet = models.NewValidationIssue(
+	ErrCodeEffectiveAtMustBeSet,
+	"effective at must be set",
+	models.WithFieldString("effectiveAt"),
+)

openmeter/credit/grant.go

@@ -34,10 +34,24 @@ type CreateGrantInput struct {
 	Recurrence       *timeutil.Recurrence
 }
 
+func (i CreateGrantInput) Validate() error {
+	if i.Amount <= 0 {
+		return ErrGrantAmountMustBePositive.WithAttr("amount", i.Amount)
+	}
+	if i.EffectiveAt.IsZero() {
+		return ErrGrantEffectiveAtMustBeSet.WithAttr("effective_at", i.EffectiveAt)
+	}
+	return nil
+}
+
 func (m *connector) CreateGrant(ctx context.Context, ownerID models.NamespacedID, input CreateGrantInput) (*grant.Grant, error) {
 	ctx, span := m.Tracer.Start(ctx, "credit.CreateGrant", cTrace.WithOwner(ownerID))
 	defer span.End()
 
+	if err := input.Validate(); err != nil {
+		return nil, err
+	}
+
 	return transaction.Run(ctx, m.GrantRepo, func(ctx context.Context) (*grant.Grant, error) {
 		tx, err := entutils.GetDriverFromContext(ctx)
 		if err != nil {