feat(pc): add duplicated phase key error (#3231)

Author: chrisgacsal

openmeter/productcatalog/errors.go

@@ -454,6 +454,15 @@ var ErrPlanPhaseDurationLessThenAnHour = models.NewValidationIssue(
 	models.WithWarningSeverity(),
 )
 
+const ErrCodePlanPhaseDuplicatedKey models.ErrorCode = "plan_phase_duplicated_key"
+
+var ErrPlanPhaseDuplicatedKey = models.NewValidationIssue(
+	ErrCodePlanPhaseDuplicatedKey,
+	"duplicated key",
+	models.WithFieldString("key"),
+	models.WithCriticalSeverity(),
+)
+
 const ErrCodePlanInvalidStatus models.ErrorCode = "plan_invalid_status"
 
 var ErrPlanInvalidStatus = models.NewValidationIssue(

openmeter/productcatalog/plan.go

@@ -68,6 +68,8 @@ func ValidatePlanPhases() models.ValidatorFunc[Plan] {
 			return ErrPlanWithNoPhases
 		}
 
+		phaseKeys := make(map[string]struct{}, len(p.Phases))
+
 		lastPhaseIdx := len(p.Phases) - 1
 
 		for idx, phase := range p.Phases {
@@ -88,6 +90,20 @@ func ValidatePlanPhases() models.ValidatorFunc[Plan] {
 				}
 			}
 
+			// Check for duplicated phase keys
+			if _, ok := phaseKeys[phase.Key]; ok {
+				selector := models.NewFieldSelectors(
+					models.NewFieldSelector("phases").
+						WithExpression(
+							models.NewFieldAttrValue("key", phase.Key),
+						),
+					models.NewFieldSelector("key"),
+				)
+
+				errs = append(errs, models.ErrorWithFieldPrefix(selector, ErrPlanPhaseDuplicatedKey))
+			}
+			phaseKeys[phase.Key] = struct{}{}
+
 			if err := phase.Validate(); err != nil {
 				errs = append(errs, models.ErrorWithFieldPrefix(phaseFieldSelector, err))
 			}