fixed test

On-behalf-of: @SAP [email protected]
Signed-off-by: Artem Shcherbatiuk <[email protected]>

Author: vertex451

.testcoverage.yml

@@ -6,6 +6,6 @@ exclude:
     - common/config/config.go
     - mocks
     - common/apis/*
+    - export_test*.go
     # remove it later:
     - listener/reconciler/clusteraccess/subroutines.go
-    - listener/reconciler/singlecluster

listener/reconciler/clusteraccess/reconciler_test.go

@@ -14,8 +14,13 @@ import (
 
 	"github.com/openmfp/golang-commons/logger"
 	gatewayv1alpha1 "github.com/openmfp/kubernetes-graphql-gateway/common/apis/v1alpha1"
+	"github.com/openmfp/kubernetes-graphql-gateway/common/config"
 	"github.com/openmfp/kubernetes-graphql-gateway/common/mocks"
+	"github.com/openmfp/kubernetes-graphql-gateway/listener/reconciler"
 	"github.com/openmfp/kubernetes-graphql-gateway/listener/reconciler/clusteraccess"
+	"k8s.io/apimachinery/pkg/runtime"
+	"k8s.io/client-go/rest"
+	ctrl "sigs.k8s.io/controller-runtime"
 )
 
 func TestCheckClusterAccessCRDStatus(t *testing.T) {
@@ -92,22 +97,90 @@ func TestCreateMultiClusterReconciler(t *testing.T) {
 
 	tests := []struct {
 		name        string
+		setupMocks  func() *mocks.MockClient
 		wantErr     bool
 		errContains string
 	}{
 		{
-			name:    "success",
+			name: "success",
+			setupMocks: func() *mocks.MockClient {
+				mockClient := mocks.NewMockClient(t)
+				// Mock successful CRD check
+				mockClient.EXPECT().List(mock.Anything, mock.AnythingOfType("*v1alpha1.ClusterAccessList")).
+					RunAndReturn(func(ctx context.Context, list client.ObjectList, opts ...client.ListOption) error {
+						clusterAccessList := list.(*gatewayv1alpha1.ClusterAccessList)
+						clusterAccessList.Items = []gatewayv1alpha1.ClusterAccess{
+							{
+								ObjectMeta: metav1.ObjectMeta{Name: "test-cluster"},
+								Spec: gatewayv1alpha1.ClusterAccessSpec{
+									Host: "https://test.example.com",
+								},
+							},
+						}
+						return nil
+					}).Once()
+				return mockClient
+			},
 			wantErr: false,
 		},
+		{
+			name: "crd_not_registered",
+			setupMocks: func() *mocks.MockClient {
+				mockClient := mocks.NewMockClient(t)
+				// Mock CRD not found
+				mockClient.EXPECT().List(mock.Anything, mock.AnythingOfType("*v1alpha1.ClusterAccessList")).
+					Return(&meta.NoResourceMatchError{
+						PartialResource: schema.GroupVersionResource{
+							Group:    "gateway.openmfp.org",
+							Version:  "v1alpha1",
+							Resource: "clusteraccesses",
+						},
+					}).Once()
+				return mockClient
+			},
+			wantErr:     true,
+			errContains: "ClusterAccess CRD not registered",
+		},
 	}
 
 	for _, tt := range tests {
 		t.Run(tt.name, func(t *testing.T) {
-			// TODO: Fix this test - CreateMultiClusterReconciler function doesn't exist
-			// reconciler, err := clusteraccess.CreateMultiClusterReconciler(opts, mockLogger)
-			// require.NoError(t, err)
-			// require.NotNil(t, reconciler)
-			_ = mockLogger // Use mockLogger to avoid unused variable warning
+			mockClient := tt.setupMocks()
+
+			// Test the actual NewClusterAccessReconciler function
+			ctx := context.Background()
+			appCfg := config.Config{
+				OpenApiDefinitionsPath: "/tmp/test",
+			}
+			opts := reconciler.ReconcilerOpts{
+				Config: &rest.Config{Host: "https://test-api-server.com"},
+				Scheme: runtime.NewScheme(),
+				Client: mockClient,
+				ManagerOpts: ctrl.Options{
+					Scheme: runtime.NewScheme(),
+				},
+				OpenAPIDefinitionsPath: "/tmp/test",
+			}
+
+			reconciler, err := clusteraccess.NewClusterAccessReconciler(
+				ctx,
+				appCfg,
+				opts,
+				nil, // ioHandler - will be created internally
+				nil, // schemaResolver - will be created internally
+				mockLogger,
+			)
+
+			if tt.wantErr {
+				assert.Error(t, err)
+				if tt.errContains != "" {
+					assert.Contains(t, err.Error(), tt.errContains)
+				}
+				assert.Nil(t, reconciler)
+			} else {
+				assert.NoError(t, err)
+				assert.NotNil(t, reconciler)
+			}
 		})
 	}
 }