feat: reconciler_factory is using a golang-commons logger now

Author: kekcleader

listener/kcp/reconciler_factory.go

@@ -12,6 +12,7 @@ import (
 	"sigs.k8s.io/controller-runtime/pkg/client"
 	"sigs.k8s.io/controller-runtime/pkg/client/apiutil"
 
+	"github.com/openmfp/golang-commons/logger"
 	"github.com/openmfp/kubernetes-graphql-gateway/common/config"
 	"github.com/openmfp/kubernetes-graphql-gateway/listener/apischema"
 	"github.com/openmfp/kubernetes-graphql-gateway/listener/clusterpath"
@@ -51,9 +52,11 @@ type ReconcilerOpts struct {
 func NewReconciler(appCfg config.Config, opts ReconcilerOpts, restcfg *rest.Config,
 	discoveryInterface discovery.DiscoveryInterface,
 	preReconcileFunc func(cr *apischema.CRDResolver, io workspacefile.IOHandler) error,
-	discoverFactory func(cfg *rest.Config) (*discoveryclient.FactoryProvider, error)) (CustomReconciler, error) {
+	discoverFactory func(cfg *rest.Config) (*discoveryclient.FactoryProvider, error),
+	log *logger.Logger,
+) (CustomReconciler, error) {
 	if !appCfg.EnableKcp {
-		return newStandardReconciler(opts, discoveryInterface, preReconcileFunc)
+		return newStandardReconciler(opts, discoveryInterface, preReconcileFunc, log)
 	}
 
 	return newKcpReconciler(opts, restcfg, discoverFactory)
@@ -63,6 +66,7 @@ func newStandardReconciler(
 	opts ReconcilerOpts,
 	discoveryInterface discovery.DiscoveryInterface,
 	preReconcileFunc func(cr *apischema.CRDResolver, io workspacefile.IOHandler) error,
+	log *logger.Logger,
 ) (CustomReconciler, error) {
 	ioHandler, err := workspacefile.NewIOHandler(opts.OpenAPIDefinitionsPath)
 	if err != nil {
@@ -83,7 +87,7 @@ func newStandardReconciler(
 		return nil, errors.Join(ErrGenerateSchema, err)
 	}
 
-	return controller.NewCRDReconciler(kubernetesClusterName, opts.Client, schemaResolver, ioHandler), nil
+	return controller.NewCRDReconciler(kubernetesClusterName, opts.Client, schemaResolver, ioHandler, log), nil
 }
 
 func restMapperFromConfig(cfg *rest.Config) (meta.RESTMapper, error) {
@@ -130,7 +134,8 @@ func newKcpReconciler(opts ReconcilerOpts, restcfg *rest.Config, newDiscoveryFac
 		return nil, errors.Join(ErrCreateDiscoveryClient, err)
 	}
 
+	// TODO: pass logger here as well if needed by APIBindingReconciler?
 	return controller.NewAPIBindingReconciler(
-		ioHandler, df, apischema.NewResolver(), pr,
+		ioHandler, df, apischema.NewResolver(), pr /* log */, nil,
 	), nil
 }

listener/kcp/reconciler_factory_test.go

@@ -15,6 +15,7 @@ import (
 	"k8s.io/client-go/rest"
 	"sigs.k8s.io/controller-runtime/pkg/client/fake"
 
+	"github.com/openmfp/golang-commons/logger"
 	"github.com/openmfp/kubernetes-graphql-gateway/listener/apischema"
 	"github.com/openmfp/kubernetes-graphql-gateway/listener/discoveryclient"
 	"github.com/openmfp/kubernetes-graphql-gateway/listener/workspacefile"
@@ -80,6 +81,11 @@ func TestNewReconciler(t *testing.T) {
 
 			fakeClient := fake.NewClientBuilder().WithScheme(scheme).Build()
 
+			loggerCfg := logger.DefaultConfig()
+			loggerCfg.Name = "test-reconciler"
+			log, err := logger.New(loggerCfg)
+			assert.NoError(t, err)
+
 			reconciler, err := NewReconciler(appCfg, ReconcilerOpts{
 				Config:                 tc.cfg,
 				Scheme:                 scheme,
@@ -91,7 +97,7 @@ func TestNewReconciler(t *testing.T) {
 				return &discoveryclient.FactoryProvider{
 					Config: cfg,
 				}, nil
-			})
+			}, log)
 
 			if tc.err != nil {
 				assert.EqualError(t, err, tc.err.Error())