fix: some asserts fixes

Author: kekcleader

listener/apischema/builder_test.go

@@ -202,6 +202,7 @@ func TestWithCRDCategories(t *testing.T) {
 			assert.True(t, found, "expected CategoriesExtensionKey to be set")
 			cats, ok := ext.([]string)
 			assert.True(t, ok, "categories should be []string")
+			assert.Equal(t, len(tc.wantCats), len(cats))
 			assert.Equal(t, tc.wantCats, cats, "categories mismatch")
 		})
 	}
@@ -250,6 +251,7 @@ func TestWithApiResourceCategories(t *testing.T) {
 			assert.True(t, found, "expected CategoriesExtensionKey to be set")
 			cats, ok := ext.([]string)
 			assert.True(t, ok, "categories should be []string")
+			assert.Equal(t, len(tc.wantCats), len(cats))
 			assert.Equal(t, tc.wantCats, cats, "categories mismatch")
 		})
 	}
@@ -283,7 +285,6 @@ func TestWithScope(t *testing.T) {
 	b.WithScope(mapper)
 
 	// Validate
-	scope, ok := b.schemas["g.v1.K"].VendorExtensible.Extensions[common.ScopeExtensionKey]
-	assert.True(t, ok, "expected ScopeExtensionKey to be set")
+	scope := b.schemas["g.v1.K"].VendorExtensible.Extensions[common.ScopeExtensionKey]
 	assert.Equal(t, apiextensionsv1.NamespaceScoped, scope, "scope value mismatch")
 }

listener/apischema/crd_resolver_test.go

@@ -61,6 +61,7 @@ func TestGetCRDGroupKindVersions(t *testing.T) {
 			gkv := getCRDGroupKindVersions(tc.spec)
 			assert.Equal(t, tc.wantG, gkv.Group, "Group mismatch")
 			assert.Equal(t, tc.wantKind, gkv.Kind, "Kind mismatch")
+			assert.Equal(t, len(tc.wantVers), len(gkv.Versions), "Versions length mismatch")
 			assert.Equal(t, tc.wantVers, gkv.Versions, "Versions mismatch")
 		})
 	}
@@ -169,7 +170,8 @@ func TestErrorIfCRDNotInPreferredApiGroups(t *testing.T) {
 				return
 			}
 			assert.NoError(t, err)
-			assert.Equal(t, tc.wantGroup, groups, "groups mismatch")
+			assert.Equal(t, len(tc.wantGroup), len(groups))
+			assert.Equal(t, tc.wantGroup, groups)
 		})
 	}
 }

listener/apischema/json_converter_test.go

@@ -48,5 +48,6 @@ func TestConvertJSON_Transforms(t *testing.T) {
 	var got, want map[string]any
 	assert.NoError(t, json.Unmarshal(out, &got), "unmarshal output")
 	assert.NoError(t, json.Unmarshal([]byte(expected), &want), "unmarshal expected")
+	assert.Equal(t, len(want), len(got), "output length mismatch")
 	assert.Equal(t, want, got, "output mismatch")
 }