fix: added more tests for apibinding_controller_test.go

Author: kekcleader

listener/controller/apibinding_controller_test.go

@@ -2,6 +2,7 @@ package controller_test
 
 import (
 	"context"
+	"errors"
 	"testing"
 
 	kcpcore "github.com/kcp-dev/kcp/sdk/apis/core/v1alpha1"
@@ -57,23 +58,107 @@ func TestAPIBindingReconciler_Reconcile(t *testing.T) {
 			},
 			err: nil,
 		},
+		{
+			name:        "workspace_delete_error",
+			clusterName: "dev-cluster",
+			mockSetup: func(ioHandler *workspacefileMocks.MockIOHandler, discoverFactory *discoveryclientMocks.MockFactory, apiSchemaResolver *apischemaMocks.MockResolver, clusterPathResolver *clusterpathMocks.MockResolver) {
+				controllerRuntimeClient := &controllerRuntimeMocks.MockClient{}
+				clusterPathResolver.EXPECT().ClientForCluster("dev-cluster").Return(controllerRuntimeClient, nil)
+				controllerRuntimeClient.EXPECT().Get(mock.Anything, mock.Anything, mock.Anything).Return(nil).
+					Run(func(ctx context.Context, key client.ObjectKey, obj client.Object, opts ...client.GetOption) {
+						lc := obj.(*kcpcore.LogicalCluster)
+						lc.Annotations = map[string]string{
+							"kcp.io/path": "dev-cluster",
+						}
+						lc.DeletionTimestamp = &metav1.Time{}
+					})
+				ioHandler.EXPECT().Delete(mock.Anything).Return(assert.AnError)
+			},
+			err: assert.AnError,
+		},
+		{
+			name:        "missing_annotation_error",
+			clusterName: "dev-cluster",
+			mockSetup: func(ioHandler *workspacefileMocks.MockIOHandler, discoverFactory *discoveryclientMocks.MockFactory, apiSchemaResolver *apischemaMocks.MockResolver, clusterPathResolver *clusterpathMocks.MockResolver) {
+				controllerRuntimeClient := &controllerRuntimeMocks.MockClient{}
+				clusterPathResolver.EXPECT().ClientForCluster("dev-cluster").Return(controllerRuntimeClient, nil)
+				controllerRuntimeClient.EXPECT().Get(mock.Anything, mock.Anything, mock.Anything).Return(nil)
+			},
+			err: errors.New("failed to get cluster path from kcp.io/path annotation"),
+		},
+		{
+			name:        "nil_annotation_error",
+			clusterName: "dev-cluster",
+			mockSetup: func(ioHandler *workspacefileMocks.MockIOHandler, discoverFactory *discoveryclientMocks.MockFactory, apiSchemaResolver *apischemaMocks.MockResolver, clusterPathResolver *clusterpathMocks.MockResolver) {
+				controllerRuntimeClient := &controllerRuntimeMocks.MockClient{}
+				clusterPathResolver.EXPECT().ClientForCluster("dev-cluster").Return(controllerRuntimeClient, nil)
+				controllerRuntimeClient.EXPECT().Get(mock.Anything, mock.Anything, mock.Anything).Return(nil).
+					Run(func(ctx context.Context, key client.ObjectKey, obj client.Object, opts ...client.GetOption) {
+						// Do not set Annotations (nil)
+					})
+			},
+			err: errors.New("failed to get cluster path from kcp.io/path annotation"),
+		},
+		{
+			name:        "empty_annotation_error",
+			clusterName: "dev-cluster",
+			mockSetup: func(ioHandler *workspacefileMocks.MockIOHandler, discoverFactory *discoveryclientMocks.MockFactory, apiSchemaResolver *apischemaMocks.MockResolver, clusterPathResolver *clusterpathMocks.MockResolver) {
+				controllerRuntimeClient := &controllerRuntimeMocks.MockClient{}
+				clusterPathResolver.EXPECT().ClientForCluster("dev-cluster").Return(controllerRuntimeClient, nil)
+				controllerRuntimeClient.EXPECT().Get(mock.Anything, mock.Anything, mock.Anything).Return(nil).
+					Run(func(ctx context.Context, key client.ObjectKey, obj client.Object, opts ...client.GetOption) {
+						lc := obj.(*kcpcore.LogicalCluster)
+						lc.Annotations = map[string]string{
+							"kcp.io/path": "",
+						}
+					})
+				ioHandler.EXPECT().Read(mock.Anything).Return(nil, nil)
+				discoverFactory.EXPECT().RestMapperForCluster(mock.Anything).Return(nil, nil)
+				discoverFactory.EXPECT().ClientForCluster(mock.Anything).Return(nil, nil)
+				apiSchemaResolver.EXPECT().Resolve(mock.Anything, mock.Anything).Return(nil, nil)
+			},
+			err: nil,
+		},
+		{
+			name:        "logicalcluster_get_error",
+			clusterName: "dev-cluster",
+			mockSetup: func(ioHandler *workspacefileMocks.MockIOHandler, discoverFactory *discoveryclientMocks.MockFactory, apiSchemaResolver *apischemaMocks.MockResolver, clusterPathResolver *clusterpathMocks.MockResolver) {
+				controllerRuntimeClient := &controllerRuntimeMocks.MockClient{}
+				clusterPathResolver.EXPECT().ClientForCluster("dev-cluster").Return(controllerRuntimeClient, nil)
+				controllerRuntimeClient.EXPECT().Get(mock.Anything, mock.Anything, mock.Anything).Return(assert.AnError)
+			},
+			err: assert.AnError,
+		},
+		{
+			name:        "client_for_cluster_error",
+			clusterName: "dev-cluster",
+			mockSetup: func(ioHandler *workspacefileMocks.MockIOHandler, discoverFactory *discoveryclientMocks.MockFactory, apiSchemaResolver *apischemaMocks.MockResolver, clusterPathResolver *clusterpathMocks.MockResolver) {
+				clusterPathResolver.EXPECT().ClientForCluster("dev-cluster").Return(nil, assert.AnError)
+			},
+			err: assert.AnError,
+		},
 	}
 
 	log := testlogger.New().HideLogOutput().Logger
 	for _, tt := range tests {
 		t.Run(tt.name, func(t *testing.T) {
 			ioHandler := workspacefileMocks.NewMockIOHandler(t)
-			discoveryFactory := discoveryclientMocks.NewMockFactory(t)
+			discoverFactory := discoveryclientMocks.NewMockFactory(t)
 			apiSchemaResolver := apischemaMocks.NewMockResolver(t)
 			clusterPathResolver := clusterpathMocks.NewMockResolver(t)
 
 			if tt.mockSetup != nil {
-				tt.mockSetup(ioHandler, discoveryFactory, apiSchemaResolver, clusterPathResolver)
+				tt.mockSetup(ioHandler, discoverFactory, apiSchemaResolver, clusterPathResolver)
 			}
 
-			r := controller.NewAPIBindingReconciler(ioHandler, discoveryFactory, apiSchemaResolver, clusterPathResolver, log)
+			r := controller.NewAPIBindingReconciler(ioHandler, discoverFactory, apiSchemaResolver, clusterPathResolver, log)
 			_, err := r.Reconcile(context.Background(), ctrl.Request{ClusterName: tt.clusterName})
-			assert.Equal(t, tt.err, err)
+
+			if tt.name == "logicalcluster_get_error" {
+				assert.ErrorIs(t, err, tt.err)
+			} else {
+				assert.Equal(t, tt.err, err)
+			}
 		})
 	}
 }