cleanup

On-behalf-of: @SAP [email protected]
Signed-off-by: Artem Shcherbatiuk <[email protected]>

Author: vertex451

gateway/resolver/relationships.go

@@ -414,9 +414,3 @@ func (r *RelationshipResolver) fetchReferencedResource(ctx context.Context, ref
 }
 
 // getOriginalGroupName converts sanitized group name back to original
-func (r *RelationshipResolver) getOriginalGroupName(groupName string) string {
-	if originalName, ok := r.groupNames[groupName]; ok {
-		return originalName
-	}
-	return groupName
-}

gateway/schema/schema.go

@@ -405,24 +405,16 @@ func (g *Gateway) generateGraphQLFields(resourceScheme *spec.Schema, typePrefix
 				relationFieldName := strings.ToLower(string(targetKind[0])) + targetKind[1:] + "Relation"
 
 				relationFieldType := g.createEnhancedRefType(targetKind)
-				if relationFieldType != nil {
-					fields[relationFieldName] = &graphql.Field{
-						Type:    relationFieldType,
-						Resolve: relationshipResolver.CreateSingleRelationResolver(*currentGVK, fieldName),
-					}
-					g.log.Info().
-						Str("typePrefix", typePrefix).
-						Str("fieldName", fieldName).
-						Str("targetKind", targetKind).
-						Str("relationFieldName", relationFieldName).
-						Msg("Added individual relation field")
-				} else {
-					g.log.Info().
-						Str("typePrefix", typePrefix).
-						Str("fieldName", fieldName).
-						Str("targetKind", targetKind).
-						Msg("Failed to create relation field type")
+				fields[relationFieldName] = &graphql.Field{
+					Type:    relationFieldType,
+					Resolve: relationshipResolver.CreateSingleRelationResolver(*currentGVK, fieldName),
 				}
+				g.log.Info().
+					Str("typePrefix", typePrefix).
+					Str("fieldName", fieldName).
+					Str("targetKind", targetKind).
+					Str("relationFieldName", relationFieldName).
+					Msg("Added individual relation field")
 			}
 		} else {
 			g.log.Info().
@@ -699,46 +691,6 @@ func (g *Gateway) extractTargetKind(fieldName string) string {
 	return resolver.ExtractTargetKind(fieldName)
 }
 
-// getOrCreateTargetResourceType attempts to get or create the GraphQL type for the target resource
-func (g *Gateway) getOrCreateTargetResourceType(targetKind string, sourceGVK *schema.GroupVersionKind) (graphql.Output, error) {
-	// Try to find the target resource type in our cache first
-	// For now, we'll look for a type with the target kind name
-	if existingType, exists := g.typesCache[targetKind]; exists && existingType != nil {
-		return existingType, nil
-	}
-
-	// If sourceGVK is available, try to construct a type name from the same group
-	if sourceGVK != nil {
-		groupTypeName := fmt.Sprintf("%s.%s.%s.%s", sourceGVK.Group, sourceGVK.Version, targetKind)
-		if existingType, exists := g.typesCache[groupTypeName]; exists && existingType != nil {
-			return existingType, nil
-		}
-	}
-
-	// Look through our definitions to find a matching resource
-	for defKey, defSchema := range g.definitions {
-		if gvk, err := g.getGroupVersionKind(defKey); err == nil && gvk.Kind == targetKind {
-			// Found a matching definition, create the type
-			fields, _, err := g.generateGraphQLFields(&defSchema, targetKind, []string{}, make(map[string]bool))
-			if err != nil {
-				continue
-			}
-
-			targetType := graphql.NewObject(graphql.ObjectConfig{
-				Name:   targetKind,
-				Fields: fields,
-			})
-
-			// Cache the type
-			g.typesCache[targetKind] = targetType
-			return targetType, nil
-		}
-	}
-
-	// If we can't find or create the target type, return an error
-	return nil, fmt.Errorf("could not find or create GraphQL type for target kind: %s", targetKind)
-}
-
 // createEnhancedRefType creates a GraphQL type for enhanced references
 func (g *Gateway) createEnhancedRefType(targetKind string) graphql.Output {
 	typeName := targetKind + "Relation"