Skip to content

Commit b63dd43

Browse files
committed
fix: use zerolog instead of zap
1 parent d439295 commit b63dd43

File tree

2 files changed

+12
-34
lines changed

2 files changed

+12
-34
lines changed

cmd/listener.go

Lines changed: 7 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -3,13 +3,12 @@ package cmd
33
import (
44
"crypto/tls"
55
"os"
6-
"strings"
76

87
kcpapis "github.com/kcp-dev/kcp/sdk/apis/apis/v1alpha1"
98
kcpcore "github.com/kcp-dev/kcp/sdk/apis/core/v1alpha1"
109
kcptenancy "github.com/kcp-dev/kcp/sdk/apis/tenancy/v1alpha1"
10+
"github.com/openmfp/golang-commons/logger"
1111
"github.com/spf13/cobra"
12-
"go.uber.org/zap/zapcore"
1312
apiextensionsv1 "k8s.io/apiextensions-apiserver/pkg/apis/apiextensions/v1"
1413
"k8s.io/apimachinery/pkg/runtime"
1514
utilruntime "k8s.io/apimachinery/pkg/util/runtime"
@@ -18,7 +17,6 @@ import (
1817
ctrl "sigs.k8s.io/controller-runtime"
1918
"sigs.k8s.io/controller-runtime/pkg/client"
2019
"sigs.k8s.io/controller-runtime/pkg/healthz"
21-
"sigs.k8s.io/controller-runtime/pkg/log/zap"
2220
"sigs.k8s.io/controller-runtime/pkg/metrics/filters"
2321
metricsserver "sigs.k8s.io/controller-runtime/pkg/metrics/server"
2422
"sigs.k8s.io/controller-runtime/pkg/webhook"
@@ -43,20 +41,13 @@ var listenCmd = &cobra.Command{
4341
utilruntime.Must(kcptenancy.AddToScheme(scheme))
4442
utilruntime.Must(apiextensionsv1.AddToScheme(scheme))
4543

46-
var zapLevel zapcore.Level
47-
switch strings.ToUpper(log.GetLevel().String()) {
48-
case "ERROR":
49-
zapLevel = zapcore.ErrorLevel
50-
case "WARN":
51-
zapLevel = zapcore.WarnLevel
52-
case "INFO":
53-
zapLevel = zapcore.InfoLevel
54-
case "DEBUG", "TRACE":
55-
zapLevel = zapcore.DebugLevel
56-
default:
57-
zapLevel = zapcore.InfoLevel
44+
logConfig := logger.DefaultConfig()
45+
logConfig.Level = os.Getenv("LOG_LEVEL")
46+
log, err := logger.New(logConfig)
47+
if err != nil {
48+
panic(err)
5849
}
59-
ctrl.SetLogger(zap.New(zap.UseDevMode(false), zap.Level(zapLevel)))
50+
ctrl.SetLogger(log.ComponentLogger("controller-runtime").Logr())
6051

6152
disableHTTP2 := func(c *tls.Config) {
6253
log.Info().Msg("disabling http/2")

tests/gateway_test/suite_test.go

Lines changed: 5 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@ import (
44
"net/http/httptest"
55
"os"
66
"path/filepath"
7-
"strings"
87
"testing"
98

109
appsv1 "k8s.io/api/apps/v1"
@@ -16,14 +15,11 @@ import (
1615
"github.com/openmfp/golang-commons/logger"
1716
"github.com/stretchr/testify/require"
1817
"github.com/stretchr/testify/suite"
19-
"go.uber.org/zap/zapcore"
2018
utilruntime "k8s.io/apimachinery/pkg/util/runtime"
2119
"k8s.io/client-go/rest"
2220
"sigs.k8s.io/controller-runtime/pkg/client"
2321
"sigs.k8s.io/controller-runtime/pkg/envtest"
2422
"sigs.k8s.io/controller-runtime/pkg/kcp"
25-
"sigs.k8s.io/controller-runtime/pkg/log"
26-
"sigs.k8s.io/controller-runtime/pkg/log/zap"
2723

2824
"github.com/openmfp/account-operator/api/v1alpha1"
2925
appConfig "github.com/openmfp/kubernetes-graphql-gateway/common/config"
@@ -33,21 +29,12 @@ import (
3329
)
3430

3531
func TestMain(m *testing.M) {
36-
var zapLevel zapcore.Level
37-
level := strings.ToUpper(os.Getenv("LOG_LEVEL"))
38-
switch level {
39-
case "ERROR":
40-
zapLevel = zapcore.ErrorLevel
41-
case "WARN":
42-
zapLevel = zapcore.WarnLevel
43-
case "INFO":
44-
zapLevel = zapcore.InfoLevel
45-
case "DEBUG", "TRACE":
46-
zapLevel = zapcore.DebugLevel
47-
default:
48-
zapLevel = zapcore.ErrorLevel
32+
logConfig := logger.DefaultConfig()
33+
logConfig.Level = os.Getenv("LOG_LEVEL")
34+
_, err := logger.New(logConfig)
35+
if err != nil {
36+
panic(err)
4937
}
50-
log.SetLogger(zap.New(zap.UseDevMode(false), zap.Level(zapLevel)))
5138
os.Exit(m.Run())
5239
}
5340

0 commit comments

Comments
 (0)