fix: replaced spaces with underscore in test names

Author: kekcleader

.testcoverage.yml

@@ -4,7 +4,4 @@ exclude:
     - cmd
     - tests
     - common/config/config.go
-    - mocks
-    # the following files should be excluded from coverage later
-    # - listener/apischema/*
-    # - listener/controller/*
+    - mocks

listener/apischema/builder_test.go

@@ -63,7 +63,7 @@ func TestGetCRDGroupVersionKind(t *testing.T) {
 		wantErr error
 	}{
 		{
-			name: "has versions",
+			name: "has_versions",
 			spec: apiextensionsv1.CustomResourceDefinitionSpec{
 				Group: "test.group",
 				Versions: []apiextensionsv1.CustomResourceDefinitionVersion{
@@ -76,7 +76,7 @@ func TestGetCRDGroupVersionKind(t *testing.T) {
 			wantErr: nil,
 		},
 		{
-			name: "no versions",
+			name: "no_versions",
 			spec: apiextensionsv1.CustomResourceDefinitionSpec{
 				Group:    "empty.group",
 				Versions: []apiextensionsv1.CustomResourceDefinitionVersion{},
@@ -118,7 +118,7 @@ func TestNewSchemaBuilder(t *testing.T) {
 		wantError bool
 	}{
 		{
-			name: "populates schemas",
+			name: "populates_schemas",
 			client: &fakeClient{paths: map[string]openapi.GroupVersion{"/X/v1": fakeGV{data: func() []byte {
 				d, _ := json.Marshal(&schemaResponse{Components: schemasComponentsWrapper{Schemas: map[string]*spec.Schema{"X.v1.K": {}}}})
 				return d
@@ -127,7 +127,7 @@ func TestNewSchemaBuilder(t *testing.T) {
 			wantKey: "X.v1.K",
 		},
 		{
-			name:      "error on Paths",
+			name:      "error_on_Paths",
 			client:    &fakeErrClient{},
 			wantLen:   0,
 			wantError: true,
@@ -167,7 +167,7 @@ func TestWithCRDCategories(t *testing.T) {
 		wantCats []string
 	}{
 		{
-			name: "adds categories",
+			name: "adds_categories",
 			key:  "g.v1.K",
 			crd: &apiextensionsv1.CustomResourceDefinition{
 				Spec: apiextensionsv1.CustomResourceDefinitionSpec{
@@ -182,7 +182,7 @@ func TestWithCRDCategories(t *testing.T) {
 			wantCats: []string{"cat1", "cat2"},
 		},
 		{
-			name: "no categories",
+			name: "no_categories",
 			key:  "g.v1.K",
 			crd: &apiextensionsv1.CustomResourceDefinition{
 				Spec: apiextensionsv1.CustomResourceDefinitionSpec{
@@ -230,7 +230,7 @@ func TestWithApiResourceCategories(t *testing.T) {
 		wantCats []string
 	}{
 		{
-			name: "adds categories",
+			name: "adds_categories",
 			key:  "h.v1.P",
 			list: []*metav1.APIResourceList{{
 				GroupVersion: "h/v1",
@@ -239,7 +239,7 @@ func TestWithApiResourceCategories(t *testing.T) {
 			wantCats: []string{"A", "B"},
 		},
 		{
-			name: "no categories",
+			name: "no_categories",
 			key:  "h.v1.P",
 			list: []*metav1.APIResourceList{{
 				GroupVersion: "h/v1",

listener/apischema/crd_resolver_test.go

@@ -66,7 +66,7 @@ func TestGetCRDGroupKindVersions(t *testing.T) {
 			wantVers: []string{"v1", "v2"},
 		},
 		{
-			name:     "single version",
+			name:     "single_version",
 			spec:     apiextensionsv1.CustomResourceDefinitionSpec{Group: "g", Versions: []apiextensionsv1.CustomResourceDefinitionVersion{{Name: "v1"}}, Names: apiextensionsv1.CustomResourceDefinitionNames{Kind: "K"}},
 			wantG:    "g",
 			wantKind: "K",
@@ -101,13 +101,13 @@ func TestIsCRDKindIncluded(t *testing.T) {
 		want    bool
 	}{
 		{
-			name:    "kind present",
+			name:    "kind_present",
 			gkv:     &GroupKindVersions{GroupKind: &metav1.GroupKind{Group: "g", Kind: "KindA"}, Versions: []string{"v1"}},
 			apiList: &metav1.APIResourceList{GroupVersion: "g/v1", APIResources: []metav1.APIResource{{Kind: "KindA"}, {Kind: "Other"}}},
 			want:    true,
 		},
 		{
-			name:    "kind absent",
+			name:    "kind_absent",
 			gkv:     &GroupKindVersions{GroupKind: &metav1.GroupKind{Group: "g", Kind: "KindA"}, Versions: []string{"v1"}},
 			apiList: &metav1.APIResourceList{GroupVersion: "g/v1", APIResources: []metav1.APIResource{{Kind: "Different"}}},
 			want:    false,
@@ -137,7 +137,7 @@ func TestErrorIfCRDNotInPreferredApiGroups(t *testing.T) {
 		wantGroup []string
 	}{
 		{
-			name: "kind found",
+			name: "kind_found",
 			lists: []*metav1.APIResourceList{
 				{
 					GroupVersion: "g/v2",
@@ -152,7 +152,7 @@ func TestErrorIfCRDNotInPreferredApiGroups(t *testing.T) {
 			wantGroup: []string{"g/v2", "g/v3"},
 		},
 		{
-			name:    "kind not found",
+			name:    "kind_not_found",
 			lists:   []*metav1.APIResourceList{{GroupVersion: "g/v1", APIResources: []metav1.APIResource{{Kind: "X"}}}},
 			wantErr: ErrGVKNotPreferred,
 		},
@@ -202,21 +202,21 @@ func TestGetSchemaForPath(t *testing.T) {
 		wantCount int
 	}{
 		{
-			name:      "invalid path",
+			name:      "invalid_path",
 			preferred: []string{"g/v1"},
 			path:      "noSlash",
 			gv:        fakeGV{},
 			wantErr:   ErrInvalidPath,
 		},
 		{
-			name:      "not preferred",
+			name:      "not_preferred",
 			preferred: []string{"x/y"},
 			path:      "/g/v1",
 			gv:        fakeGV{},
 			wantErr:   ErrNotPreferred,
 		},
 		{
-			name:      "unmarshal error",
+			name:      "unmarshal_error",
 			preferred: []string{"g/v1"},
 			path:      "/g/v1",
 			gv:        fakeGV{data: []byte("bad json"), err: nil},
@@ -263,12 +263,12 @@ func TestResolveSchema(t *testing.T) {
 		wantErr            bool
 	}{
 		{
-			name:    "discovery error",
+			name:    "discovery_error",
 			err:     ErrGetServerPreferred,
 			wantErr: true,
 		},
 		{
-			name: "successful schema resolution",
+			name: "successful_schema_resolution",
 			preferredResources: []*metav1.APIResourceList{
 				{
 					GroupVersion: "v1",
@@ -287,7 +287,7 @@ func TestResolveSchema(t *testing.T) {
 			wantErr: false,
 		},
 		{
-			name:               "empty resources list",
+			name:               "empty_resources_list",
 			preferredResources: []*metav1.APIResourceList{},
 			openAPIPaths: map[string]openapi.GroupVersion{
 				"/api/v1": fakeGV{},

listener/apischema/json_converter_test.go

@@ -17,12 +17,12 @@ func TestConvertJSON(t *testing.T) {
 		check   func(defs map[string]map[string]any) error
 	}{
 		{
-			name:    "invalid JSON",
+			name:    "invalid_JSON",
 			input:   "not a json",
 			wantErr: ErrUnmarshalJSON,
 		},
 		{
-			name: "remove defaults and rewrite refs",
+			name: "remove_defaults_and_rewrite_refs",
 			input: map[string]any{
 				"components": map[string]any{
 					"schemas": map[string]any{

listener/apischema/resolver_test.go

@@ -73,15 +73,15 @@ func TestResolverProvider_Resolve(t *testing.T) {
 		wantErr            bool
 	}{
 		{
-			name: "discovery error",
+			name: "discovery_error",
 			err:  ErrGetServerPreferred,
 			openAPIPaths: map[string]openapi.GroupVersion{
 				"/api/v1": &fakeGV{},
 			},
 			wantErr: true,
 		},
 		{
-			name: "successful resolution",
+			name: "successful_resolution",
 			preferredResources: []*metav1.APIResourceList{
 				{
 					GroupVersion: "v1",

listener/controller/crd_controller_test.go

@@ -52,31 +52,31 @@ func TestCRDReconciler(t *testing.T) {
 	}
 	tests := []scenario{
 		{
-			name:    "get error",
+			name:    "get_error",
 			getErr:  errors.New("get-error"),
 			readErr: nil,
 			wantErr: controller.ErrGetReconciledObj,
 		},
 		{
-			name:    "not found read error",
+			name:    "not_found_read_error",
 			getErr:  apierrors.NewNotFound(schema.GroupResource{Group: "", Resource: "crds"}, "my-crd"),
 			readErr: errors.New("read-error"),
 			wantErr: controller.ErrReadJSON,
 		},
 		{
-			name:    "not found resolve error",
+			name:    "not_found_resolve_error",
 			getErr:  apierrors.NewNotFound(schema.GroupResource{Group: "", Resource: "crds"}, "my-crd"),
 			readErr: nil,
 			wantErr: controller.ErrResolveSchema,
 		},
 		{
-			name:    "not found write error",
+			name:    "not_found_write_error",
 			getErr:  apierrors.NewNotFound(schema.GroupResource{Group: "", Resource: "crds"}, "my-crd"),
 			readErr: nil,
 			wantErr: controller.ErrWriteJSON,
 		},
 		{
-			name:    "successful update",
+			name:    "successful_update",
 			getErr:  nil,
 			readErr: nil,
 			wantErr: nil,