Fix: tests for gateway (#106)

On-behalf-of: @SAP [email protected]
Signed-off-by: Artem Shcherbatiuk <[email protected]>

Author: vertex451

.github/workflows/pipeline.yml

@@ -19,7 +19,8 @@ jobs:
       useTask: true
       useLocalCoverageConfig: true
       imageTagName: ghcr.io/openmfp/kubernetes-graphql-gateway
-      coverageThreasholdFile: 0
-      coverageThresholdPackage: 0
-      coverageThreasholdTotal: 49
+      coverageThreasholdFile: 49
+      coverageThresholdPackage: 65
+      coverageThreasholdTotal: 62
+
 

.mockery.yaml

@@ -7,4 +7,11 @@ packages:
       dir: gateway/resolver/mocks
       outpkg: mocks
     interfaces:
-      WithWatch:
+      WithWatch:
+  net/http:
+    config:
+      dir: gateway/manager/mocks
+      outpkg: mocks
+    interfaces:
+      RoundTripper:
+

.testcoverage.yml

@@ -3,6 +3,9 @@ exclude:
     - main.go
     - cmd
     - tests
-    - gateway/config/config.go
-    - listener/*
+    - common/config/config.go
     - deprecated/*
+    - mocks
+    # the following files should be excluded from coverage later
+    - listener/apischema/*
+    - listener/controller/*

gateway/manager/mocks/mock_RoundTripper.go

@@ -0,0 +1,101 @@
+package manager_test
+
+import (
+	"context"
+	"net/http"
+	"net/http/httptest"
+	"testing"
+
+	"github.com/golang-jwt/jwt/v5"
+	"github.com/openmfp/golang-commons/logger"
+	"github.com/stretchr/testify/assert"
+	"github.com/stretchr/testify/mock"
+	"github.com/stretchr/testify/require"
+	"k8s.io/client-go/transport"
+
+	"github.com/openmfp/kubernetes-graphql-gateway/gateway/manager"
+	"github.com/openmfp/kubernetes-graphql-gateway/gateway/manager/mocks"
+)
+
+func TestRoundTripper_RoundTrip(t *testing.T) {
+	tests := []struct {
+		name         string
+		token        string
+		impersonate  bool
+		expectedUser string
+	}{
+		{
+			name:         "success",
+			token:        createTestToken(t, jwt.MapClaims{"sub": "test-user"}),
+			impersonate:  true,
+			expectedUser: "test-user",
+		},
+		{
+			name:        "no_token_in_context",
+			impersonate: false,
+		},
+		{
+			name:        "token_present_impersonate_false",
+			token:       "valid-token",
+			impersonate: false,
+		},
+		{
+			name:        "failed_to_parse_token",
+			token:       "invalid-token",
+			impersonate: true,
+		},
+		{
+			name:        "user_claim_not_found",
+			token:       createTestToken(t, jwt.MapClaims{}),
+			impersonate: true,
+		},
+		{
+			name:        "user_claim_is_not_a_string",
+			token:       createTestToken(t, jwt.MapClaims{"sub": 123}),
+			impersonate: true,
+		},
+	}
+
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			mockRoundTripper := &mocks.MockRoundTripper{}
+
+			mockRoundTripper.EXPECT().
+				RoundTrip(mock.Anything).
+				Return(&http.Response{StatusCode: http.StatusOK}, nil)
+
+			if tt.expectedUser != "" {
+				mockRoundTripper.EXPECT().
+					RoundTrip(mock.MatchedBy(func(req *http.Request) bool {
+						return req.Header.Get(transport.ImpersonateUserHeader) == tt.expectedUser
+					})).
+					Return(&http.Response{StatusCode: http.StatusOK}, nil)
+			}
+
+			log, err := logger.New(logger.DefaultConfig())
+			require.NoError(t, err)
+
+			rt := manager.NewRoundTripper(log, mockRoundTripper, "sub", tt.impersonate)
+
+			req := httptest.NewRequest(http.MethodGet, "http://example.com", nil)
+			if tt.token != "" {
+				ctx := context.WithValue(req.Context(), manager.TokenKey{}, tt.token)
+				req = req.WithContext(ctx)
+			}
+
+			resp, err := rt.RoundTrip(req)
+			require.NoError(t, err)
+			require.NotNil(t, resp)
+			assert.Equal(t, http.StatusOK, resp.StatusCode)
+
+			mockRoundTripper.AssertExpectations(t)
+		})
+	}
+}
+
+func createTestToken(t *testing.T, claims jwt.MapClaims) string {
+	token := jwt.NewWithClaims(jwt.SigningMethodHS256, claims)
+	signedToken, err := token.SignedString([]byte("test-secret"))
+	require.NoError(t, err)
+	return signedToken
+}

gateway/manager/roundtripper_test.go

@@ -0,0 +1,59 @@
+package resolver
+
+import (
+	"github.com/stretchr/testify/assert"
+	"testing"
+)
+
+func TestSanitizeGroupName(t *testing.T) {
+	r := &Service{
+		groupNames: make(map[string]string),
+	}
+
+	tests := []struct {
+		name     string
+		input    string
+		expected string
+	}{
+		{"empty_string", "", "core"},
+		{"valid_group_name", "validName", "validName"},
+		{"hyphen_to_underscore", "group-name", "group_name"},
+		{"special_char_to_underscore", "group@name", "group_name"},
+		{"invalid_start_with_prepend", "!invalidStart", "_invalidStart"},
+		{"leading_underscore", "_leadingUnderscore", "_leadingUnderscore"},
+		{"start_with_number", "123startWithNumber", "_123startWithNumber"},
+	}
+
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			result := r.SanitizeGroupName(tt.input)
+			assert.Equal(t, tt.expected, result)
+			assert.Equal(t, tt.input, r.groupNames[result], "The original group name should be stored correctly")
+		})
+	}
+}
+
+func TestGetOriginalGroupName(t *testing.T) {
+	r := &Service{
+		groupNames: map[string]string{
+			"group1": "originalGroup1",
+			"group2": "originalGroup2",
+		},
+	}
+
+	tests := []struct {
+		name     string
+		input    string
+		expected string
+	}{
+		{"existing_group", "group1", "originalGroup1"},
+		{"non_existing_group", "group3", "group3"},
+	}
+
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			result := r.getOriginalGroupName(tt.input)
+			assert.Equal(t, tt.expected, result)
+		})
+	}
+}