Skip to content

Commit 9a65217

Browse files
Merge pull request #1217 from openml/bugfix/api-runs-for-java-tests
Bugfix for runs
2 parents d2f1cab + 4fc28c7 commit 9a65217

File tree

1 file changed

+3
-6
lines changed

1 file changed

+3
-6
lines changed

openml_OS/models/api/v1/Api_run.php

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -747,7 +747,6 @@ private function run_reset($run_id) {
747747
*)
748748
*/
749749
private function run_upload() {
750-
751750
/* * * * * * * * * * * * * * * * * * * * * * * * * * * * * *
752751
* Everything that needs to be done for EVERY task, *
753752
* Including the unsupported tasks *
@@ -757,7 +756,6 @@ private function run_upload() {
757756
// If changing something big, also test that function.
758757

759758
$timestamps = array(microtime(true)); // profiling 0
760-
761759
// check uploaded file
762760
$description = isset($_FILES['description']) ? $_FILES['description'] : false;
763761
$uploadError = '';
@@ -790,7 +788,8 @@ private function run_upload() {
790788

791789
$run_xml = all_tags_from_xml(
792790
$xml->children('oml', true),
793-
$this->xml_fields_run);
791+
$this->xml_fields_run
792+
);
794793

795794
$task_id = $run_xml['task_id'];
796795
$implementation_id = $run_xml['flow_id'];
@@ -815,7 +814,6 @@ private function run_upload() {
815814
}
816815

817816
// check whether uploaded files are present.
818-
819817
foreach ($_FILES as $key => $value) {
820818
$message = '';
821819
$extension = getExtension($_FILES[$key]['name']);
@@ -916,7 +914,7 @@ private function run_upload() {
916914

917915
$supported_evaluation_measures = $this->Math_function->getColumnWhere('name', '`functionType` = "EvaluationFunction"');
918916
// the user can specify his own metrics. here we check whether these exists in the database.
919-
if($output_data != false && isset($output_data['evaluation'])) {
917+
if($output_data != false && isset($output_data->evaluation)) {
920918
// php does not have a set data structure, use hashmap instead
921919
$used_evaluation_measures = array();
922920
$illegal_measures = array();
@@ -945,7 +943,6 @@ private function run_upload() {
945943
return;
946944
}
947945
}
948-
949946
// now create a run
950947
$runData = array(
951948
'uploader' => $this->user_id,

0 commit comments

Comments
 (0)