Skip to content

Commit ff1cb5d

Browse files
committed
Add comment explaining when to remove BASE_URL hack
1 parent 1739db8 commit ff1cb5d

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

openml_OS/models/api/v1/Api_data.php

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -842,6 +842,9 @@ private function data($data_id) {
842842
if ($data_status != false) {
843843
$dataset->status = $data_status->status;
844844
}
845+
// The BASE_URL check prevents servering parquet urls from the test server,
846+
// which is needed as long as the test server does not have its own dedicated
847+
// MinIO with parquet files. TODO: Remove this after running MinIO on test
845848
if ($dataset->format != 'Sparse_ARFF' && BASE_URL != "https://test.openml.org/") {
846849
$bracket = sprintf('%04d', floor($data_id / 10000));
847850
$padded_id = sprintf('%04d', $data_id);

0 commit comments

Comments
 (0)