Skip to content

Commit 84e4f0e

Browse files
committed
Adding unit test + updating changelog
1 parent e695d39 commit 84e4f0e

File tree

3 files changed

+12
-2
lines changed

3 files changed

+12
-2
lines changed

doc/progress.rst

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@ Changelog
2121
* ADD #659: Lazy loading of task splits.
2222
* ADD #516: `run_flow_on_task` flow uploading is now optional.
2323
* ADD #680: Adds `openml.config.start_using_configuration_for_example` (and resp. stop) to easily connect to the test server.
24+
* ADD #695: A function to retieve all the data quality measures available.
2425
* FIX #642: `check_datasets_active` now correctly also returns active status of deactivated datasets.
2526
* FIX #304, #636: Allow serialization of numpy datatypes and list of lists of more types (e.g. bools, ints) for flows.
2627
* FIX #651: Fixed a bug that would prevent openml-python from finding the user's config file.

openml/datasets/functions.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -165,7 +165,7 @@ def _get_cache_directory(dataset: OpenMLDataset) -> str:
165165
return _create_cache_directory_for_id(DATASETS_CACHE_DIR_NAME, dataset.dataset_id)
166166

167167

168-
def list_qualities() -> list:
168+
def list_qualities() -> List[str]:
169169
""" Return list of data qualities available.
170170
171171
The function performs an API call to retrieve the entire list of

tests/test_datasets/test_dataset_functions.py

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1165,7 +1165,11 @@ def test_create_dataset_attributes_auto_without_df(self):
11651165
creator = 'OpenML tester'
11661166
collection_date = '01-01-2018'
11671167
language = 'English'
1168-
licence = 'MIT'
1168+
licence = 'MIT' def test_list_evaluation_measures(self):
1169+
measures = openml.evaluations.list_evaluation_measures()
1170+
self.assertEqual([isinstance(measures), list)
1171+
self.assertEqual(all([isinstance(s, str) for s in measures]), True)
1172+
11691173
default_target_attribute = 'col_{}'.format(data.shape[1] - 1)
11701174
citation = 'None'
11711175
original_data_url = 'http://openml.github.io/openml-python'
@@ -1190,3 +1194,8 @@ def test_create_dataset_attributes_auto_without_df(self):
11901194
original_data_url=original_data_url,
11911195
paper_url=paper_url
11921196
)
1197+
1198+
def test_list_qualities(self):
1199+
qualities = openml.datasets.list_qualities()
1200+
self.assertEqual(isinstance(qualities, list), True)
1201+
self.assertEqual(all([isinstance(q, str) for q in qualities]), True)

0 commit comments

Comments
 (0)