Skip to content

Commit f445b1d

Browse files
committed
Splitting unit test to reduce wait time
1 parent 279fdd3 commit f445b1d

File tree

1 file changed

+32
-3
lines changed

1 file changed

+32
-3
lines changed

tests/test_datasets/test_dataset_functions.py

Lines changed: 32 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1058,7 +1058,21 @@ def test_ignore_attributes_dataset(self):
10581058
paper_url=paper_url
10591059
)
10601060

1061-
def test_publish_fetch_ignore_attribute(self):
1061+
def test___publish_fetch_ignore_attribute(self):
1062+
"""(Part 1) Test to upload and retrieve dataset and check ignore_attributes
1063+
1064+
This test is split into two parts:
1065+
1) test___publish_fetch_ignore_attribute()
1066+
This will be executed earlier, owing to alphabetical sorting.
1067+
This test creates and publish() a dataset and checks for a valid ID.
1068+
2) test_publish_fetch_ignore_attribute()
1069+
This will be executed after test___publish_fetch_ignore_attribute(),
1070+
owing to alphabetical sorting. The time gap is to allow the server
1071+
more time time to compute data qualities.
1072+
The dataset ID obtained previously is used to fetch the dataset.
1073+
The retrieved dataset is checked for valid ignore_attributes.
1074+
"""
1075+
# the returned fixt
10621076
data = [
10631077
['a', 'sunny', 85.0, 85.0, 'FALSE', 'no'],
10641078
['b', 'sunny', 80.0, 90.0, 'TRUE', 'no'],
@@ -1109,10 +1123,25 @@ def test_publish_fetch_ignore_attribute(self):
11091123
# publish dataset
11101124
upload_did = dataset.publish()
11111125
# test if publish was successful
1112-
self.assertIsInstance(dataset.dataset_id, int)
1126+
self.assertIsInstance(upload_did, int)
1127+
# variables to carry forward for test_publish_fetch_ignore_attribute()
1128+
self.__class__.test_publish_fetch_ignore_attribute_did = upload_did
1129+
self.__class__.test_publish_fetch_ignore_attribute_list = ignore_attribute
11131130

1131+
def test_publish_fetch_ignore_attribute(self):
1132+
"""(Part 2) Test to upload and retrieve dataset and check ignore_attributes
1133+
1134+
This will be executed after test___publish_fetch_ignore_attribute(),
1135+
owing to alphabetical sorting. The time gap is to allow the server
1136+
more time time to compute data qualities.
1137+
The dataset ID obtained previously is used to fetch the dataset.
1138+
The retrieved dataset is checked for valid ignore_attributes.
1139+
"""
1140+
# Retrieving variables from test___publish_fetch_ignore_attribute()
1141+
upload_did = self.__class__.test_publish_fetch_ignore_attribute_did
1142+
ignore_attribute = self.__class__.test_publish_fetch_ignore_attribute_list
11141143
trials = 1
1115-
timeout_limit = 1000
1144+
timeout_limit = 200
11161145
dataset = None
11171146
# fetching from server
11181147
# loop till timeout or fetch not successful

0 commit comments

Comments
 (0)