Skip to content

Commit 35dc937

Browse files
committed
courses test cases
1 parent 0e94055 commit 35dc937

File tree

4 files changed

+465
-68
lines changed

4 files changed

+465
-68
lines changed

package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@
88
"apidoc": "$(npm bin)/apidoc -f \".*\\.js$\" -i src/ -o doc/",
99
"dev": "DEBUG=ws-nodejs-re:* $(npm bin)/nodemon --exec babel-node -L src/app.js",
1010
"lint": "$(npm bin)/eslint src/ config/ test/",
11+
"format": "$(npm bin)/eslint --fix src/ config/ test/",
1112
"start": "node src/app.js",
1213
"test": "NODE_ENV=test PORT=3333 $(npm bin)/mocha --require @babel/register --exit $(find test -name '*spec.js')",
1314
"integration-test": "export PORT=3333 NODE_ENV=test && sequelize db:migrate:undo:all && sequelize db:migrate && nyc --require @babel/register mocha ./test/integration/integration.js --timeout 20000 --exit",

src/server/controllers/course.js

Lines changed: 17 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
1-
import CourseService from "../services/course";
2-
import Util from "../utils/Utils";
3-
import statusCode from "../utils/status";
1+
import CourseService from '../services/course';
2+
import Util from '../utils/Utils';
3+
import statusCode from '../utils/status';
44

5-
const isUUID = require("is-uuid");
5+
const isUUID = require('is-uuid');
66

77
const util = new Util();
88

@@ -11,11 +11,13 @@ class CourseController {
1111
try {
1212
const allCourses = await CourseService.getAllCourses();
1313
if (allCourses.length > 0) {
14-
util.setSuccess(statusCode.OK, "Courses retrieved", allCourses);
14+
util.setSuccess(statusCode.OK, 'Courses retrieved', allCourses);
1515
} else {
16-
util.setSuccess(statusCode.OK, "No course found", allCourses);
16+
util.setSuccess(statusCode.OK, 'No course found', allCourses);
1717
}
18-
return util.send(res);
18+
const p = util.send(res);
19+
20+
return p;
1921
} catch (error) {
2022
util.setError(statusCode.BAD_REQUEST, error);
2123
return util.send(res);
@@ -26,13 +28,13 @@ class CourseController {
2628
const utiln = new Util();
2729

2830
if (!req.body.name) {
29-
utiln.setError(statusCode.BAD_REQUEST, "Please provide complete details");
31+
utiln.setError(statusCode.BAD_REQUEST, 'Please provide complete details');
3032
return utiln.send(res);
3133
}
3234
const newCourse = req.body;
3335
try {
3436
const createdCourse = await CourseService.addCourse(newCourse);
35-
utiln.setSuccess(statusCode.CREATED, "Course Added!", createdCourse);
37+
utiln.setSuccess(statusCode.CREATED, 'Course Added!', createdCourse);
3638
return utiln.send(res);
3739
} catch (error) {
3840
utiln.setError(statusCode.BAD_REQUEST, error.message);
@@ -44,7 +46,7 @@ class CourseController {
4446
const alteredCourse = req.body;
4547
const { id } = req.params;
4648
if (!isUUID.v4(id)) {
47-
util.setError(statusCode.BAD_REQUEST, "Please input a valid uuid value");
49+
util.setError(statusCode.BAD_REQUEST, 'Please input a valid uuid value');
4850
return util.send(res);
4951
}
5052
try {
@@ -57,7 +59,7 @@ class CourseController {
5759
} else {
5860
util.setSuccess(
5961
statusCode.SUCCESS_NO_CONTENT,
60-
"Course updated",
62+
'Course updated',
6163
updateCourse
6264
);
6365
}
@@ -72,7 +74,7 @@ class CourseController {
7274
const { id } = req.params;
7375

7476
if (!isUUID.v4(id)) {
75-
util.setError(statusCode.BAD_REQUEST, "Please input a valid uuid value");
77+
util.setError(statusCode.BAD_REQUEST, 'Please input a valid uuid value');
7678
return util.send(res);
7779
}
7880

@@ -85,7 +87,7 @@ class CourseController {
8587
`Cannot find course with the id ${id}`
8688
);
8789
} else {
88-
util.setSuccess(statusCode.OK, "Found Course", theCourse);
90+
util.setSuccess(statusCode.OK, 'Found Course', theCourse);
8991
}
9092
return util.send(res);
9193
} catch (error) {
@@ -98,15 +100,15 @@ class CourseController {
98100
const { id } = req.params;
99101

100102
if (!isUUID.v4(id)) {
101-
util.setError(statusCode.BAD_REQUEST, "Please provide a numeric value");
103+
util.setError(statusCode.BAD_REQUEST, 'Please provide a numeric value');
102104
return util.send(res);
103105
}
104106

105107
try {
106108
const courseToDelete = await CourseService.deleteCourse(id);
107109

108110
if (courseToDelete) {
109-
util.setSuccess(statusCode.SUCCESS_NO_CONTENT, "Course deleted");
111+
util.setSuccess(statusCode.SUCCESS_NO_CONTENT, 'Course deleted');
110112
} else {
111113
util.setError(
112114
statusCode.NOT_FOUND,

src/server/utils/Utils.js

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -22,12 +22,6 @@ export default class Util {
2222
}
2323

2424
send(res) {
25-
// const result = {
26-
// status: this.type,
27-
// message: this.message,
28-
// data: this.data,
29-
// };
30-
3125
switch (this.statusCode) {
3226
case status.OK:
3327
return res.status(this.statusCode).json(this.data);

0 commit comments

Comments
 (0)