(fix) Add regex anchors to SSN identifier format validation #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The regex for the SSN identifier format was missing the anchors (^ and $), which caused the validation to fail for identifiers that did not exactly match the required format of one uppercase letter, followed by a dash and exactly 7 digits (e.g., "A-0010902"). Without these anchors, the pattern could match invalid formats like "X-A-1234567-Y" (extra characters), or "A-123456789" (too many digits), leading to potential data quality issues. This PR adds start and end anchors to ensure the identifier strictly follows the required format. It also updates the regex description to be more descriptive and accurate.
dkayiwa
approved these changes
Apr 16, 2025
Member
|
Java distinguishes between calls to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous regex for the SSN identifier was missing start (^) and end ($) anchors, allowing partial matches and permitting invalid formats such as extra characters (e.g.,
X-A-1234567-Y) or too many digits (e.g.,A-123456789). This caused the validation to accept identifiers that did not exactly match the required format: one uppercase letter, a dash, and exactly seven digits (e.g.,A-0010902).This commit adds the necessary anchors to enforce strict matching and updates the regex description for clarity and accuracy, improving data quality by ensuring only valid identifiers are accepted.
Relates to: openmrs/openmrs-esm-patient-management#1553