Skip to content

TEST: Migrate ConditionValidatorTest to JUnit 5 #5706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
akshat-s99 wants to merge 2 commits into
base: master
Choose a base branch
from
+22 −11
Open

TEST: Migrate ConditionValidatorTest to JUnit 5 #5706

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3e89f94
TEST: Migrate ConditionValidatorTest to JUnit 5
Jan 27, 2026
9148c11
Merge branch 'master' into GSOC-ConditionValidator-fix
akshat-s99 Jan 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 22 additions & 11 deletions api/src/test/java/org/openmrs/validator/ConditionValidatorTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,14 +11,17 @@

import static org.hamcrest.CoreMatchers.is;
import static org.hamcrest.MatcherAssert.assertThat;
import static org.junit.jupiter.api.Assertions.assertFalse;
import static org.junit.jupiter.api.Assertions.assertThrows;
import static org.junit.jupiter.api.Assertions.assertTrue;

import java.util.Locale;

import org.junit.jupiter.api.BeforeEach;
import org.junit.jupiter.api.Test;
import org.junit.Test;
import org.junit.Before;

import static org.junit.Assert.assertFalse;
import static org.junit.Assert.assertTrue;
import static org.junit.Assert.assertEquals;
import static org.junit.Assert.fail;

import org.openmrs.CodedOrFreeText;
import org.openmrs.Cohort;
import org.openmrs.Concept;
Expand Down Expand Up @@ -71,11 +74,19 @@ public void shouldFailIfGivenConditionWithNullConditionProperties(){

@Test
public void shouldPassIfConditionClassIsPassedWithRequiredConditionProperties(){
Condition condition = new Condition();
condition.setCondition(new CodedOrFreeText(new Concept(), new ConceptName("name", new Locale("en")), "nonCoded"));
condition.setClinicalStatus(ConditionClinicalStatus.ACTIVE);
validator.validate(condition, errors);
assertFalse(errors.hasFieldErrors("condition"));
assertFalse(errors.hasFieldErrors("clinicalStatus"));
Condition condition = new Condition();
Errors errors = new BindException(condition, "condition");

condition.setCondition(new CodedOrFreeText(
new Concept(),
new ConceptName("name", new Locale("en")),
"nonCoded"
));
condition.setClinicalStatus(ConditionClinicalStatus.ACTIVE);

validator.validate(condition, errors);

assertFalse(errors.hasFieldErrors("condition"));
assertFalse(errors.hasFieldErrors("clinicalStatus"));
}
}